fix: sync profile/plugin lists when drawing profile manager

Dalamud/Interface/Internal/Windows/PluginInstaller/ProfileManagerWidget.cs

@@ -111,6 +111,7 @@ internal class ProfileManagerWidget
         {
             Guid? toCloneGuid = null;
 
+            using var syncScope = profman.GetSyncScope();
             foreach (var profile in profman.Profiles)
             {
                 if (profile.IsDefaultProfile)
@@ -329,7 +330,8 @@ internal class ProfileManagerWidget
             var pluginLineHeight = 32 * ImGuiHelpers.GlobalScale;
             string? wantRemovePluginInternalName = null;
 
-            foreach (var plugin in profile.Plugins)
+            using var syncScope = profile.GetSyncScope();
+            foreach (var plugin in profile.Plugins.ToArray())
             {
                 didAny = true;
                 var pmPlugin = pm.InstalledPlugins.FirstOrDefault(x => x.Manifest.InternalName == plugin.InternalName);

Dalamud/Plugin/Internal/Profiles/Profile.cs

@@ -109,6 +109,13 @@ internal class Profile
     /// </summary>
     public ProfileModel Model => this.modelV1;
 
+    /// <summary>
+    /// Get a disposable that will lock the plugin list while it is not disposed.
+    /// You must NEVER use this in async code.
+    /// </summary>
+    /// <returns>The aforementioned disposable.</returns>
+    public IDisposable GetSyncScope() => new ScopedSyncRoot(this);
+
     /// <summary>
     /// Set this profile's state. This cannot be called for the default profile.
     /// This will block until all states have been applied.

Dalamud/Plugin/Internal/Profiles/ProfileManager.cs

@@ -58,6 +58,13 @@ internal class ProfileManager : IServiceType
     /// Gets a value indicating whether or not the profile manager is busy enabling/disabling plugins.
     /// </summary>
     public bool IsBusy => this.isBusy;
+    
+    /// <summary>
+    /// Get a disposable that will lock the profile list while it is not disposed.
+    /// You must NEVER use this in async code.
+    /// </summary>
+    /// <returns>The aforementioned disposable.</returns>
+    public IDisposable GetSyncScope() => new ScopedSyncRoot(this.profiles);
 
     /// <summary>
     /// Check if any enabled profile wants a specific plugin enabled.