ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-13 12:14:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: changelog crashes on improper LastUpdate timestamp (#1493)

Browse source
This commit is contained in:
Sayu 2023-10-24 17:49:33 +02:00 • committed by GitHub
parent fdbdf26da6
commit 041937b2d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Dalamud/Interface/Internal/Windows/PluginInstaller/PluginChangelogEntry.cs
View file

@ -1,7 +1,6 @@
using System; using CheapLoc;
using CheapLoc;
using Dalamud.Plugin.Internal.Types; using Dalamud.Plugin.Internal.Types;
using Serilog;
namespace Dalamud.Interface.Internal.Windows.PluginInstaller; namespace Dalamud.Interface.Internal.Windows.PluginInstaller;
@ -36,7 +35,18 @@ internal class PluginChangelogEntry : IChangelogEntry
this.Version = plugin.EffectiveVersion.ToString(); this.Version = plugin.EffectiveVersion.ToString();
this.Text = plugin.Manifest.Changelog ?? Loc.Localize("ChangelogNoText", "No changelog for this version."); this.Text = plugin.Manifest.Changelog ?? Loc.Localize("ChangelogNoText", "No changelog for this version.");
this.Author = plugin.Manifest.Author; this.Author = plugin.Manifest.Author;
this.Date = DateTimeOffset.FromUnixTimeSeconds(this.Plugin.Manifest.LastUpdate).DateTime;
try
{
this.Date = DateTimeOffset.FromUnixTimeSeconds(this.Plugin.Manifest.LastUpdate).DateTime;
}
catch (ArgumentOutOfRangeException ex)
{
Log.Warning(ex, "Manifest included improper timestamp, e.g. wrong unit: {PluginName}",
plugin.Manifest.Name);
// Create a Date from 0 as with a manifest that does not include a LastUpdate field
this.Date = DateTimeOffset.FromUnixTimeSeconds(0).DateTime;
}
} }
/// <summary> /// <summary>