ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-12 18:27:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove Anonymous Feedback (#1168)

Browse source 
- Removes the submit anonymous feedback checkbox
- Remove relevant wording around anonymous feedback (incl. warning)
- Update anonymous feedback error message
This commit is contained in:
MidoriKami 2023-04-11 10:18:29 -07:00 • committed by GitHub
parent 50458444e7
commit 063a9408e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

48
Dalamud/Interface/Internal/Windows/PluginInstaller/PluginInstallerWindow.cs
View file

@ -86,7 +86,6 @@ internal class PluginInstallerWindow : Window, IDisposable
private bool feedbackModalIncludeException = false; private bool feedbackModalIncludeException = false;
private PluginManifest? feedbackPlugin = null; private PluginManifest? feedbackPlugin = null;
private bool feedbackIsTesting = false; private bool feedbackIsTesting = false;
private bool feedbackIsAnonymous = false;
private int updatePluginCount = 0; private int updatePluginCount = 0;
private List<PluginUpdateStatus>? updatedPlugins; private List<PluginUpdateStatus>? updatedPlugins;
@ -740,42 +739,22 @@ internal class PluginInstallerWindow : Window, IDisposable
ImGui.Spacing(); ImGui.Spacing();
if (ImGui.Checkbox(Locs.FeedbackModal_ContactAnonymous, ref this.feedbackIsAnonymous)) ImGui.InputText(Locs.FeedbackModal_ContactInformation, ref this.feedbackModalContact, 100);
{
if (this.feedbackIsAnonymous)
this.feedbackModalContact = string.Empty;
}
if (this.feedbackIsAnonymous) ImGui.SameLine();
{
ImGui.BeginDisabled();
ImGui.InputText(Locs.FeedbackModal_ContactInformation, ref this.feedbackModalContact, 0);
ImGui.EndDisabled();
ImGui.PushStyleColor(ImGuiCol.Text, ImGuiColors.DalamudRed);
ImGui.Text(Locs.FeedbackModal_ContactAnonymousWarning);
ImGui.PopStyleColor();
}
else
{
ImGui.InputText(Locs.FeedbackModal_ContactInformation, ref this.feedbackModalContact, 100);
ImGui.SameLine(); if (ImGui.Button(Locs.FeedbackModal_ContactInformationDiscordButton))
{
if (ImGui.Button(Locs.FeedbackModal_ContactInformationDiscordButton)) Process.Start(new ProcessStartInfo(Locs.FeedbackModal_ContactInformationDiscordUrl)
{ {
Process.Start(new ProcessStartInfo(Locs.FeedbackModal_ContactInformationDiscordUrl) UseShellExecute = true,
{ });
UseShellExecute = true,
});
}
ImGui.Text(Locs.FeedbackModal_ContactInformationHelp);
ImGui.PushStyleColor(ImGuiCol.Text, ImGuiColors.DalamudRed);
ImGui.Text(Locs.FeedbackModal_ContactInformationWarning);
ImGui.PopStyleColor();
} }
ImGui.Text(Locs.FeedbackModal_ContactInformationHelp);
ImGui.TextColored(ImGuiColors.DalamudRed, Locs.FeedbackModal_ContactInformationWarning);
ImGui.Spacing(); ImGui.Spacing();
ImGui.Checkbox(Locs.FeedbackModal_IncludeLastError, ref this.feedbackModalIncludeException); ImGui.Checkbox(Locs.FeedbackModal_IncludeLastError, ref this.feedbackModalIncludeException);
@ -790,7 +769,7 @@ internal class PluginInstallerWindow : Window, IDisposable
if (ImGui.Button(Locs.ErrorModalButton_Ok, new Vector2(buttonWidth, 40))) if (ImGui.Button(Locs.ErrorModalButton_Ok, new Vector2(buttonWidth, 40)))
{ {
if (!this.feedbackIsAnonymous && string.IsNullOrWhiteSpace(this.feedbackModalContact)) if (string.IsNullOrWhiteSpace(this.feedbackModalContact))
{ {
this.ShowErrorModal(Locs.FeedbackModal_ContactInformationRequired) this.ShowErrorModal(Locs.FeedbackModal_ContactInformationRequired)
.ContinueWith(_ => .ContinueWith(_ =>
@ -856,7 +835,6 @@ internal class PluginInstallerWindow : Window, IDisposable
this.feedbackModalBody = string.Empty; this.feedbackModalBody = string.Empty;
this.feedbackModalContact = Service<DalamudConfiguration>.Get().LastFeedbackContactDetails; this.feedbackModalContact = Service<DalamudConfiguration>.Get().LastFeedbackContactDetails;
this.feedbackModalIncludeException = false; this.feedbackModalIncludeException = false;
this.feedbackIsAnonymous = false;
} }
else else
{ {
@ -3204,7 +3182,7 @@ internal class PluginInstallerWindow : Window, IDisposable
public static string FeedbackModal_ContactInformationWarning => Loc.Localize("InstallerFeedbackContactInfoWarning", "Do not submit in-game character names."); public static string FeedbackModal_ContactInformationWarning => Loc.Localize("InstallerFeedbackContactInfoWarning", "Do not submit in-game character names.");
public static string FeedbackModal_ContactInformationRequired => Loc.Localize("InstallerFeedbackContactInfoRequired", "Contact information has not been provided. If you do not want to provide contact information, tick on \"{0}\" above.").Format(FeedbackModal_ContactAnonymous); public static string FeedbackModal_ContactInformationRequired => Loc.Localize("InstallerFeedbackContactInfoRequired", "Contact information has not been provided. We require contact information to respond to questions, or to request additional information to troubleshoot problems.");
public static string FeedbackModal_ContactInformationDiscordButton => Loc.Localize("ContactInformationDiscordButton", "Join Goat Place Discord"); public static string FeedbackModal_ContactInformationDiscordButton => Loc.Localize("ContactInformationDiscordButton", "Join Goat Place Discord");