ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-12 18:27:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: don't draw changelog twice

Browse source
This commit is contained in:
goat 2023-08-22 21:49:38 +02:00
parent 47a9911e31
commit 07692753db
No known key found for this signature in database
GPG key ID: 49E2AA8C6A76498B
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Dalamud/Interface/Internal/Windows/PluginInstaller/PluginInstallerWindow.cs
View file

@ -2149,6 +2149,7 @@ internal class PluginInstallerWindow : Window, IDisposable
ImGui.PushID($"installed{index}{plugin.Manifest.InternalName}"); ImGui.PushID($"installed{index}{plugin.Manifest.InternalName}");
var hasChangelog = !plugin.Manifest.Changelog.IsNullOrEmpty(); var hasChangelog = !plugin.Manifest.Changelog.IsNullOrEmpty();
var didDrawChangelogInsideCollapsible = false;
if (this.DrawPluginCollapsingHeader(label, plugin, plugin.Manifest, plugin.IsThirdParty, trouble, availablePluginUpdate != default, false, false, plugin.IsOrphaned, () => this.DrawInstalledPluginContextMenu(plugin, testingOptIn), index)) if (this.DrawPluginCollapsingHeader(label, plugin, plugin.Manifest, plugin.IsThirdParty, trouble, availablePluginUpdate != default, false, false, plugin.IsOrphaned, () => this.DrawInstalledPluginContextMenu(plugin, testingOptIn), index))
{ {
@ -2257,6 +2258,7 @@ internal class PluginInstallerWindow : Window, IDisposable
{ {
if (ImGui.TreeNode(Locs.PluginBody_CurrentChangeLog(plugin.EffectiveVersion))) if (ImGui.TreeNode(Locs.PluginBody_CurrentChangeLog(plugin.EffectiveVersion)))
{ {
didDrawChangelogInsideCollapsible = true;
this.DrawInstalledPluginChangelog(plugin.Manifest); this.DrawInstalledPluginChangelog(plugin.Manifest);
ImGui.TreePop(); ImGui.TreePop();
} }
@ -2273,7 +2275,7 @@ internal class PluginInstallerWindow : Window, IDisposable
} }
} }
if (thisWasUpdated && hasChangelog) if (thisWasUpdated && hasChangelog && !didDrawChangelogInsideCollapsible)
{ {
this.DrawInstalledPluginChangelog(plugin.Manifest); this.DrawInstalledPluginChangelog(plugin.Manifest);
} }