From 08100ef572c46d148e5bd60f43fbaf2f0a531f89 Mon Sep 17 00:00:00 2001
From: Haselnussbomber <mail@haselnussbomber.de>
Date: Tue, 1 Aug 2023 18:57:00 +0200
Subject: [PATCH] fix: add a full item link to SeStringBuilder

This changes the behaviour of `AddItemLink` functions.
Previously it just added an `ItemPayload`.
Now, it adds a full item link, as one would expect.
---
 Dalamud/Game/Text/SeStringHandling/SeString.cs        | 1 +
 Dalamud/Game/Text/SeStringHandling/SeStringBuilder.cs | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Dalamud/Game/Text/SeStringHandling/SeString.cs b/Dalamud/Game/Text/SeStringHandling/SeString.cs
index c06cdc6b0..d7d1784f4 100644
--- a/Dalamud/Game/Text/SeStringHandling/SeString.cs
+++ b/Dalamud/Game/Text/SeStringHandling/SeString.cs
@@ -208,6 +208,7 @@ public class SeString
         var textColor = (ushort)(549 + ((rarity - 1) * 2));
         var textGlowColor = (ushort)(textColor + 1);
 
+        // Note: `SeStringBuilder.AddItemLink` uses this function, so don't call it here!
         return new SeStringBuilder()
             .Add(new ItemPayload(itemId, kind))
             .Append(TextArrowPayloads)
diff --git a/Dalamud/Game/Text/SeStringHandling/SeStringBuilder.cs b/Dalamud/Game/Text/SeStringHandling/SeStringBuilder.cs
index 1e3449618..5b6a83f61 100644
--- a/Dalamud/Game/Text/SeStringHandling/SeStringBuilder.cs
+++ b/Dalamud/Game/Text/SeStringHandling/SeStringBuilder.cs
@@ -114,7 +114,7 @@ public class SeStringBuilder
     /// <param name="itemNameOverride">Override for the item's name.</param>
     /// <returns>The current builder.</returns>
     public SeStringBuilder AddItemLink(uint itemId, bool isHq, string? itemNameOverride = null) =>
-        this.Add(new ItemPayload(itemId, isHq, itemNameOverride));
+        this.Append(SeString.CreateItemLink(itemId, isHq, itemNameOverride));
 
     /// <summary>
     /// Add an item link to the builder.
@@ -124,7 +124,7 @@ public class SeStringBuilder
     /// <param name="itemNameOverride">Override for the item's name.</param>
     /// <returns>The current builder.</returns>
     public SeStringBuilder AddItemLink(uint itemId, ItemPayload.ItemKind kind, string? itemNameOverride = null) =>
-        this.Add(new ItemPayload(itemId, kind, itemNameOverride));
+        this.Append(SeString.CreateItemLink(itemId, kind, itemNameOverride));
 
     /// <summary>
     /// Add an item link to the builder.