ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-12 10:17:22 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Build adjustments for code annotation (#2155)

Browse source 
* Drop special formatting, allowing annotations to work properly.

* Suppress duplicate warnings, adding a prefix to prevent annotation

* Tweak message, don't rebuild on test

* Move testing into same job step

* Only run PR build on newly opened PRs

* flip build order, derp

* Test suppressing summary for annotations...

* Get the build order right, testing without conditionals...

* Run tests after compile, suppress warnings from test

* Reverted previous change to `main.yml`.

* Drop special formatting, allowing annotations to work properly.

* Suppress duplicate warnings, adding a prefix to prevent annotation

* Tweak message, don't rebuild on test

* Move testing into same job step

* Only run PR build on newly opened PRs

* flip build order, derp

* Test suppressing summary for annotations...

* Get the build order right, testing without conditionals...

* Run tests after compile, suppress warnings from test

* Reverted previous change to `main.yml`.

* Drop special formatting, allowing annotations to work properly.

* Suppress duplicate warnings, adding a prefix to prevent annotation

* Tweak message, don't rebuild on test

* Move testing into same job step

* Only run PR build on newly opened PRs

* flip build order, derp

* Test suppressing summary for annotations...

* Get the build order right, testing without conditionals...

* Run tests after compile, suppress warnings from test

* Reverted previous change to `main.yml`.

* Add conditional for CI builds, add --skip-tests to make up for the combined build/test step.

* Behavior change, now requires arg `ci` to be passed to trigger tests. Tests can also be manually triggered with `test`.
This commit is contained in:
Nathan C 2025-03-13 17:01:39 -04:00 • committed by goaaats
parent 2c00bf5b21
commit 203d80c602
3 changed files with 50 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

40
build/DalamudBuild.cs
View file

@ -1,3 +1,4 @@
using System;
using System.Collections.Generic;
using System.IO;
using Nuke.Common;
@ -5,6 +6,7 @@ using Nuke.Common.Execution;
using Nuke.Common.Git;
using Nuke.Common.IO;
using Nuke.Common.ProjectModel;
using Nuke.Common.Tooling;
using Nuke.Common.Tools.DotNet;
using Nuke.Common.Tools.MSBuild;
using Serilog;
@ -61,6 +63,9 @@ public class DalamudBuild : NukeBuild
private static Dictionary<string, string> EnvironmentVariables => new(EnvironmentInfo.Variables);
private static string ConsoleTemplate => "{Message:l}{NewLine}{Exception}";
private static bool IsCIBuild => Environment.GetEnvironmentVariable("CI") == "true";
Target Restore => _ => _
.Executes(() =>
{
@ -123,16 +128,20 @@ public class DalamudBuild : NukeBuild
.SetProjectFile(DalamudProjectFile)
.SetConfiguration(Configuration)
.EnableNoRestore();
if (IsCIBuild)
{
s = s
.SetProcessArgumentConfigurator(a => a.Add("/clp:NoSummary")); // Disable MSBuild summary on CI builds
}
// We need to emit compiler generated files for the docs build, since docfx can't run generators directly
// TODO: This fails every build after this because of redefinitions...
// if (IsDocsBuild)
// {
// Log.Warning("Building for documentation, emitting compiler generated files. This can cause issues on Windows due to path-length limitations");
// s = s
// .SetProperty("IsDocsBuild", "true");
// }
return s;
});
});
@ -171,12 +180,28 @@ public class DalamudBuild : NukeBuild
.SetConfiguration(Configuration));
});
Target SetCILogging => _ => _
.DependentFor(Compile)
.OnlyWhenStatic(() => IsCIBuild)
.Executes(() =>
{
Log.Logger = new LoggerConfiguration()
.MinimumLevel.Debug()
.WriteTo.Console(outputTemplate: ConsoleTemplate)
.CreateLogger();
});
Target Compile => _ => _
.DependsOn(CompileDalamud)
.DependsOn(CompileDalamudBoot)
.DependsOn(CompileDalamudCrashHandler)
.DependsOn(CompileInjector)
.DependsOn(CompileInjectorBoot);
.DependsOn(CompileDalamud)
.DependsOn(CompileDalamudBoot)
.DependsOn(CompileDalamudCrashHandler)
.DependsOn(CompileInjector)
.DependsOn(CompileInjectorBoot)
;
Target CI => _ => _
.DependsOn(Compile)
.Triggers(Test);
Target Test => _ => _
.DependsOn(Compile)
@ -185,6 +210,7 @@ public class DalamudBuild : NukeBuild
DotNetTasks.DotNetTest(s => s
.SetProjectFile(TestProjectFile)
.SetConfiguration(Configuration)
.AddProperty("WarningLevel", "0")
.EnableNoRestore());
});