ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-12 18:27:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Minor cleanup

Browse source
This commit is contained in:
MidoriKami 2025-11-25 18:56:34 -08:00
parent 54bac7f32a
commit 27a7adfdb9
4 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Dalamud/Game/Addon/Lifecycle/AddonArgsType.cs
View file

@ -41,7 +41,7 @@ public enum AddonArgsType
ReceiveEvent,
/// <summary>
/// Generic arg type that contains no meaningful data
/// Generic arg type that contains no meaningful data.
/// </summary>
Generic,
}

11
Dalamud/Game/Addon/Lifecycle/AddonLifecycle.cs
View file

@ -33,8 +33,6 @@ internal unsafe class AddonLifecycle : IInternalDisposableService
{
this.onInitializeAddonHook = Hook<AtkUnitBase.Delegates.Initialize>.FromAddress((nint)AtkUnitBase.StaticVirtualTablePointer->Initialize, this.OnAddonInitialize);
this.onInitializeAddonHook.Enable();
Log.Warning($"FOUND INITIALIZE HOOK AT {this.onInitializeAddonHook.Address:X}");
}
/// <summary>
@ -48,10 +46,13 @@ internal unsafe class AddonLifecycle : IInternalDisposableService
this.onInitializeAddonHook?.Dispose();
this.onInitializeAddonHook = null;
foreach (var virtualTable in this.modifiedTables.Values)
this.framework.RunOnFrameworkThread(() =>
{
virtualTable.Dispose();
}
foreach (var virtualTable in this.modifiedTables.Values)
{
virtualTable.Dispose();
}
});
}
/// <summary>

2
Dalamud/Game/Addon/Lifecycle/AddonLifecycleAddressResolver.cs
View file

@ -5,7 +5,7 @@ namespace Dalamud.Game.Addon.Lifecycle;
/// <summary>
/// AddonLifecycleService memory address resolver.
/// </summary>
[Api13ToDo("Remove this class entirely, its not used by AddonLifecycleAnymore, and use something else for HookWidget")]
[Api13ToDo("Remove this class entirely, its not used by AddonLifecycle anymore, also need to use something else for HookWidget")]
internal class AddonLifecycleAddressResolver : BaseAddressResolver
{
/// <summary>

2
Dalamud/Game/Addon/Lifecycle/AddonVirtualTable.cs
View file

@ -19,7 +19,7 @@ internal unsafe class AddonVirtualTable : IDisposable
// Copying extra entries is not problematic, and is considered safe.
private const int VirtualTableEntryCount = 200;
private const bool EnableAdvancedLogging = true;
private const bool EnableAdvancedLogging = false;
private const bool EnableSpammyLogging = false;
private static readonly ModuleLog Log = new("LifecycleVT");