From 2d3e225e2c644577008478dab4f77c15ab8cf964 Mon Sep 17 00:00:00 2001 From: goat <16760685+goaaats@users.noreply.github.com> Date: Tue, 14 Sep 2021 02:44:48 +0200 Subject: [PATCH] fix: reuse HttpClient for icon/image downloads --- .../Internal/Windows/PluginInstallerWindow.cs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/Dalamud/Interface/Internal/Windows/PluginInstallerWindow.cs b/Dalamud/Interface/Internal/Windows/PluginInstallerWindow.cs index 1657c6597..d55e70946 100644 --- a/Dalamud/Interface/Internal/Windows/PluginInstallerWindow.cs +++ b/Dalamud/Interface/Internal/Windows/PluginInstallerWindow.cs @@ -49,6 +49,8 @@ namespace Dalamud.Interface.Internal.Windows private readonly TextureWrap troubleIcon; private readonly TextureWrap updateIcon; + private readonly HttpClient httpClient = new(); + #region Image Tester State private string[] testerImagePaths = new string[5]; @@ -1743,11 +1745,9 @@ namespace Dalamud.Interface.Internal.Windows Log.Verbose($"Icon from {url}"); - var client = new HttpClient(); - if (url != null) { - var data = await client.GetAsync(url); + var data = await this.httpClient.GetAsync(url); if (data.StatusCode == HttpStatusCode.NotFound) return; @@ -1782,8 +1782,6 @@ namespace Dalamud.Interface.Internal.Windows this.pluginImagesMap.Add(manifest.InternalName, (false, null)); - var client = new HttpClient(); - var urls = GetPluginImageUrls(manifest, isThirdParty, pluginManager.UseTesting(manifest)); var didAny = false; @@ -1798,7 +1796,7 @@ namespace Dalamud.Interface.Internal.Windows var pluginImages = new TextureWrap[urls.Count]; for (var i = 0; i < urls.Count; i++) { - var data = await client.GetAsync(urls[i]); + var data = await this.httpClient.GetAsync(urls[i]); Serilog.Log.Information($"Download from {urls[i]}");