From 4f3727c78b8aa51bf340670e8d07a41ac70ce1c8 Mon Sep 17 00:00:00 2001
From: Kaz Wolfe <root@kazwolfe.io>
Date: Fri, 10 Feb 2023 22:37:33 -0800
Subject: [PATCH] chore: Convert Exception to nullable in PluginLog

Allows specifying Exception as a nullable parameter to various Log calls where an Exception may or may not be present in the caller.
---
 Dalamud/Logging/PluginLog.cs | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/Dalamud/Logging/PluginLog.cs b/Dalamud/Logging/PluginLog.cs
index 80edbe430..b2f2a5065 100644
--- a/Dalamud/Logging/PluginLog.cs
+++ b/Dalamud/Logging/PluginLog.cs
@@ -27,7 +27,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void Log(Exception exception, string messageTemplate, params object[] values)
+    public static void Log(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Information, messageTemplate, exception, values);
 
     /// <summary>
@@ -44,7 +44,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void LogVerbose(Exception exception, string messageTemplate, params object[] values)
+    public static void LogVerbose(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Verbose, messageTemplate, exception, values);
 
     /// <summary>
@@ -61,7 +61,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void LogDebug(Exception exception, string messageTemplate, params object[] values)
+    public static void LogDebug(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Debug, messageTemplate, exception, values);
 
     /// <summary>
@@ -78,7 +78,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void LogInformation(Exception exception, string messageTemplate, params object[] values)
+    public static void LogInformation(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Information, messageTemplate, exception, values);
 
     /// <summary>
@@ -95,7 +95,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void LogWarning(Exception exception, string messageTemplate, params object[] values)
+    public static void LogWarning(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Warning, messageTemplate, exception, values);
 
     /// <summary>
@@ -112,7 +112,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void LogError(Exception exception, string messageTemplate, params object[] values)
+    public static void LogError(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Error, messageTemplate, exception, values);
 
     /// <summary>
@@ -129,7 +129,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void LogFatal(Exception exception, string messageTemplate, params object[] values)
+    public static void LogFatal(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Fatal, messageTemplate, exception, values);
 
     #endregion
@@ -150,7 +150,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void Verbose(Exception exception, string messageTemplate, params object[] values)
+    public static void Verbose(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Verbose, messageTemplate, exception, values);
 
     /// <summary>
@@ -167,7 +167,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void Debug(Exception exception, string messageTemplate, params object[] values)
+    public static void Debug(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Debug, messageTemplate, exception, values);
 
     /// <summary>
@@ -184,7 +184,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void Information(Exception exception, string messageTemplate, params object[] values)
+    public static void Information(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Information, messageTemplate, exception, values);
 
     /// <summary>
@@ -201,7 +201,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void Warning(Exception exception, string messageTemplate, params object[] values)
+    public static void Warning(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Warning, messageTemplate, exception, values);
 
     /// <summary>
@@ -218,7 +218,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void Error(Exception exception, string messageTemplate, params object[] values)
+    public static void Error(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Error, messageTemplate, exception, values);
 
     /// <summary>
@@ -235,7 +235,7 @@ public static class PluginLog
     /// <param name="exception">The exception that caused the error.</param>
     /// <param name="messageTemplate">The message template.</param>
     /// <param name="values">Values to log.</param>
-    public static void Fatal(Exception exception, string messageTemplate, params object[] values)
+    public static void Fatal(Exception? exception, string messageTemplate, params object[] values)
         => WriteLog(Assembly.GetCallingAssembly().GetName().Name, LogEventLevel.Fatal, messageTemplate, exception, values);
 
     #endregion