diff --git a/Dalamud/Game/Addon/Lifecycle/AddonLifecycle.cs b/Dalamud/Game/Addon/Lifecycle/AddonLifecycle.cs
index 0c23f5661..cf1270803 100644
--- a/Dalamud/Game/Addon/Lifecycle/AddonLifecycle.cs
+++ b/Dalamud/Game/Addon/Lifecycle/AddonLifecycle.cs
@@ -38,7 +38,7 @@ internal unsafe class AddonLifecycle : IInternalDisposableService
///
/// Gets a list of all AddonLifecycle Event Listeners.
///
- internal List EventListeners { get; } = [];
+ internal Dictionary> EventListeners { get; } = [];
///
void IInternalDisposableService.DisposeService()
@@ -61,10 +61,8 @@ internal unsafe class AddonLifecycle : IInternalDisposableService
/// The listener to register.
internal void RegisterListener(AddonLifecycleEventListener listener)
{
- this.framework.RunOnTick(() =>
- {
- this.EventListeners.Add(listener);
- });
+ this.EventListeners.TryAdd(listener.EventType, [ listener ]);
+ this.EventListeners[listener.EventType].Add(listener);
}
///
@@ -73,13 +71,10 @@ internal unsafe class AddonLifecycle : IInternalDisposableService
/// The listener to unregister.
internal void UnregisterListener(AddonLifecycleEventListener listener)
{
- // Set removed state to true immediately, then lazily remove it from the EventListeners list on next Framework Update.
- listener.Removed = true;
-
- this.framework.RunOnTick(() =>
+ if (this.EventListeners.TryGetValue(listener.EventType, out var listenerList))
{
- this.EventListeners.Remove(listener);
- });
+ listenerList.Remove(listener);
+ }
}
///
@@ -90,16 +85,12 @@ internal unsafe class AddonLifecycle : IInternalDisposableService
/// What to blame on errors.
internal void InvokeListenersSafely(AddonEvent eventType, AddonArgs args, [CallerMemberName] string blame = "")
{
+ // Early return if we don't have any listeners of this type
+ if (!this.EventListeners.TryGetValue(eventType, out var listenerList)) return;
+
// Do not use linq; this is a high-traffic function, and more heap allocations avoided, the better.
- foreach (var listener in this.EventListeners)
+ foreach (var listener in listenerList)
{
- if (listener.EventType != eventType)
- continue;
-
- // If the listener is pending removal, and is waiting until the next Framework Update, don't invoke listener.
- if (listener.Removed)
- continue;
-
// Match on string.empty for listeners that want events for all addons.
if (!string.IsNullOrWhiteSpace(listener.AddonName) && !args.IsAddon(listener.AddonName))
continue;