Revert "emit compiler generated files for docs builds"

This reverts commit df4104d868.
This commit is contained in:
goat 2024-06-29 14:28:46 +02:00
parent df4104d868
commit 51e3db55b3
2 changed files with 5 additions and 28 deletions

View file

@ -43,10 +43,6 @@
"VSCode" "VSCode"
] ]
}, },
"IsDocsBuild": {
"type": "boolean",
"description": "Whether we are building for documentation - emits generated files"
},
"NoLogo": { "NoLogo": {
"type": "boolean", "type": "boolean",
"description": "Disables displaying the NUKE logo" "description": "Disables displaying the NUKE logo"

View file

@ -7,7 +7,6 @@ using Nuke.Common.IO;
using Nuke.Common.ProjectModel; using Nuke.Common.ProjectModel;
using Nuke.Common.Tools.DotNet; using Nuke.Common.Tools.DotNet;
using Nuke.Common.Tools.MSBuild; using Nuke.Common.Tools.MSBuild;
using Serilog;
[UnsetVisualStudioEnvironmentVariables] [UnsetVisualStudioEnvironmentVariables]
public class DalamudBuild : NukeBuild public class DalamudBuild : NukeBuild
@ -23,9 +22,6 @@ public class DalamudBuild : NukeBuild
[Parameter("Configuration to build - Default is 'Debug' (local) or 'Release' (server)")] [Parameter("Configuration to build - Default is 'Debug' (local) or 'Release' (server)")]
readonly Configuration Configuration = IsLocalBuild ? Configuration.Debug : Configuration.Release; readonly Configuration Configuration = IsLocalBuild ? Configuration.Debug : Configuration.Release;
[Parameter("Whether we are building for documentation - emits generated files")]
readonly bool IsDocsBuild = false;
[Solution] Solution Solution; [Solution] Solution Solution;
[GitRepository] GitRepository GitRepository; [GitRepository] GitRepository GitRepository;
@ -64,25 +60,10 @@ public class DalamudBuild : NukeBuild
.DependsOn(Restore) .DependsOn(Restore)
.Executes(() => .Executes(() =>
{ {
DotNetTasks.DotNetBuild(s => DotNetTasks.DotNetBuild(s => s
{
s = s
.SetProjectFile(DalamudProjectFile) .SetProjectFile(DalamudProjectFile)
.SetConfiguration(Configuration) .SetConfiguration(Configuration)
.EnableNoRestore(); .EnableNoRestore());
// We need to emit compiler generated files for the docs build, since docfx can't run generators directly
// TODO: This fails every build after this because of redefinitions...
if (IsDocsBuild)
{
Log.Warning("Building for documentation, emitting compiler generated files. This can cause issues on Windows due to path-length limitations");
s = s
.SetProperty("EmitCompilerGeneratedFiles", "true")
.SetProperty("CompilerGeneratedFilesOutputPath", "Generated");
}
return s;
});
}); });
Target CompileDalamudBoot => _ => _ Target CompileDalamudBoot => _ => _