From 5456cbdb6c87356c4841d89a8e64c66e5e5c6ec6 Mon Sep 17 00:00:00 2001 From: karashiiro <49822414+karashiiro@users.noreply.github.com> Date: Wed, 15 Feb 2023 09:28:46 -0800 Subject: [PATCH] feat(logging): fix IDE warnings in Universalis logging --- .../UniversalisMarketBoardUploader.cs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Dalamud/Game/Network/Internal/MarketBoardUploaders/Universalis/UniversalisMarketBoardUploader.cs b/Dalamud/Game/Network/Internal/MarketBoardUploaders/Universalis/UniversalisMarketBoardUploader.cs index 2e974d4ac..790493129 100644 --- a/Dalamud/Game/Network/Internal/MarketBoardUploaders/Universalis/UniversalisMarketBoardUploader.cs +++ b/Dalamud/Game/Network/Internal/MarketBoardUploaders/Universalis/UniversalisMarketBoardUploader.cs @@ -36,7 +36,7 @@ internal class UniversalisMarketBoardUploader : IMarketBoardUploader if (clientState == null) return; - Log.Verbose("Starting Universalis upload."); + Log.Verbose("Starting Universalis upload"); var uploader = clientState.LocalContentId; // ==================================================================================== @@ -82,7 +82,7 @@ internal class UniversalisMarketBoardUploader : IMarketBoardUploader var listingPath = "/upload"; var listingUpload = JsonConvert.SerializeObject(listingsUploadObject); - Log.Verbose($"{listingPath}: {listingUpload}"); + Log.Verbose("{ListingPath}: {ListingUpload}", listingPath, listingUpload); await Util.HttpClient.PostAsync($"{ApiBase}{listingPath}/{ApiKey}", new StringContent(listingUpload, Encoding.UTF8, "application/json")); // ==================================================================================== @@ -110,12 +110,12 @@ internal class UniversalisMarketBoardUploader : IMarketBoardUploader var historyPath = "/upload"; var historyUpload = JsonConvert.SerializeObject(historyUploadObject); - Log.Verbose($"{historyPath}: {historyUpload}"); + Log.Verbose("{HistoryPath}: {HistoryUpload}", historyPath, historyUpload); await Util.HttpClient.PostAsync($"{ApiBase}{historyPath}/{ApiKey}", new StringContent(historyUpload, Encoding.UTF8, "application/json")); // ==================================================================================== - Log.Verbose("Universalis data upload for item#{0} completed.", request.CatalogId); + Log.Verbose("Universalis data upload for item#{CatalogId} completed", request.CatalogId); } /// @@ -145,13 +145,13 @@ internal class UniversalisMarketBoardUploader : IMarketBoardUploader var taxPath = "/upload"; var taxUpload = JsonConvert.SerializeObject(taxUploadObject); - Log.Verbose($"{taxPath}: {taxUpload}"); + Log.Verbose("{TaxPath}: {TaxUpload}", taxPath, taxUpload); await Util.HttpClient.PostAsync($"{ApiBase}{taxPath}/{ApiKey}", new StringContent(taxUpload, Encoding.UTF8, "application/json")); // ==================================================================================== - Log.Verbose("Universalis tax upload completed."); + Log.Verbose("Universalis tax upload completed"); } /// @@ -182,7 +182,7 @@ internal class UniversalisMarketBoardUploader : IMarketBoardUploader var deletePath = $"/api/{worldId}/{itemId}/delete"; var deleteListing = JsonConvert.SerializeObject(deleteListingObject); - Log.Verbose($"{deletePath}: {deleteListing}"); + Log.Verbose("{DeletePath}: {DeleteListing}", deletePath, deleteListing); var content = new StringContent(deleteListing, Encoding.UTF8, "application/json"); var message = new HttpRequestMessage(HttpMethod.Post, $"{ApiBase}{deletePath}"); @@ -193,6 +193,6 @@ internal class UniversalisMarketBoardUploader : IMarketBoardUploader // ==================================================================================== - Log.Verbose("Universalis purchase upload completed."); + Log.Verbose("Universalis purchase upload completed"); } }