ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-29 11:59:21 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: don't use tables for the installer layout, more ImRaii conversion

Browse source 
Apparently children inside tables is UB
This commit is contained in:
goat 2023-06-21 21:42:00 +02:00
parent 30176e61f5
commit 5a76f3ebe5
No known key found for this signature in database
GPG key ID: 49E2AA8C6A76498B
2 changed files with 31 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Dalamud/Interface/Internal/Windows/PluginInstaller/ProfileManagerWidget.cs
View file

@ -107,7 +107,8 @@ internal class ProfileManagerWidget
var windowSize = ImGui.GetWindowSize();
if (ImGui.BeginChild("###profileChooserScrolling"))
using var profileChooserChild = ImRaii.Child("###profileChooserScrolling");
if (profileChooserChild)
{
Guid? toCloneGuid = null;
@ -180,8 +181,6 @@ internal class ProfileManagerWidget
ImGuiHelpers.CenteredText(Locs.AddProfileHint);
ImGui.PopStyleColor();
}
ImGui.EndChild();
}
}
@ -325,7 +324,8 @@ internal class ProfileManagerWidget
ImGui.Separator();
var wantPluginAddPopup = false;
if (ImGui.BeginChild("###profileEditorPluginList"))
using var pluginListChild = ImRaii.Child("###profileEditorPluginList");
if (pluginListChild)
{
var pluginLineHeight = 32 * ImGuiHelpers.GlobalScale;
string? wantRemovePluginInternalName = null;
@ -439,8 +439,6 @@ internal class ProfileManagerWidget
ImGui.TextUnformatted(addPluginsText);
ImGuiHelpers.ScaledDummy(10);
ImGui.EndChild();
}
if (wantPluginAddPopup)