ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-30 04:13:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: improve SeString integer decoding and encoding

Browse source
This commit is contained in:
Asvel 2021-04-14 07:09:37 +08:00
parent 2aacbee1c8
commit 5d611de8da
5 changed files with 32 additions and 279 deletions
Download patch file Download diff file Expand all files Collapse all files

35
Dalamud/Game/Text/SeStringHandling/Payloads/ItemPayload.cs
View file

@ -175,40 +175,5 @@ namespace Dalamud.Game.Text.SeStringHandling.Payloads
this.displayName = Encoding.UTF8.GetString(itemNameBytes);
}
}
protected override byte[] MakeInteger(uint value, bool withMarker = true, bool incrementSmallInts = true)
{
// TODO: as part of refactor
// linking an item id that is a multiple of 256 seemingly *requires* using byte*256 marker encoding
// or the link will not display correctly
// I am unsure if this applies to other data types as well, so keeping localized here, pending the
// refactor of all this integer handling mess
if (value % 256 == 0)
{
value /= 256;
// this is no longer a small int, but it was likely converted to that range
incrementSmallInts = false;
}
return base.MakeInteger(value, withMarker, incrementSmallInts);
}
protected override byte GetMarkerForIntegerBytes(byte[] bytes)
{
// custom marker just for hq items?
if (bytes.Length == 3 && IsHQ)
{
return (byte)IntegerType.Int24Special;
}
// TODO: as in the above function
if (bytes.Length == 1 && (this.itemId % 256 == 0))
{
return (byte)IntegerType.ByteTimes256;
}
return base.GetMarkerForIntegerBytes(bytes);
}
}
}