From 5dd627d18ecf7d66c10f8e54cf8839e1571c0174 Mon Sep 17 00:00:00 2001 From: MidoriKami <9083275+MidoriKami@users.noreply.github.com> Date: Sun, 28 Apr 2024 11:02:42 -0700 Subject: [PATCH] Fix ContextMenu LogicError (#1790) --- Dalamud/Game/Gui/ContextMenu/ContextMenu.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Dalamud/Game/Gui/ContextMenu/ContextMenu.cs b/Dalamud/Game/Gui/ContextMenu/ContextMenu.cs index abbfc6a5b..1bd8ce882 100644 --- a/Dalamud/Game/Gui/ContextMenu/ContextMenu.cs +++ b/Dalamud/Game/Gui/ContextMenu/ContextMenu.cs @@ -268,11 +268,15 @@ internal sealed unsafe class ContextMenu : IInternalDisposableService, IContextM foreach (var item in items) { - if (!item.Prefix.HasValue && !item.UseDefaultPrefix) + if (!item.Prefix.HasValue) { item.Prefix = MenuItem.DalamudDefaultPrefix; item.PrefixColor = MenuItem.DalamudDefaultPrefixColor; - Log.Warning($"Menu item \"{item.Name}\" has no prefix, defaulting to Dalamud's. Menu items outside of a submenu must have a prefix."); + + if (!item.UseDefaultPrefix) + { + Log.Warning($"Menu item \"{item.Name}\" has no prefix, defaulting to Dalamud's. Menu items outside of a submenu must have a prefix."); + } } }