ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-15 13:14:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(ContextMenu): more self tests for edge cases

Browse source
This commit is contained in:
goaaats 2022-01-29 00:02:50 +01:00
parent 7a242c962a
commit 6475da469b
No known key found for this signature in database
GPG key ID: 49E2AA8C6A76498B
1 changed files with 108 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

144
Dalamud/Interface/Internal/Windows/SelfTest/AgingSteps/ContextMenuAgingStep.cs
View file

@ -20,16 +20,21 @@ namespace Dalamud.Interface.Internal.Windows.SelfTest.AgingSteps
private bool clickedItemHq; private bool clickedItemHq;
private uint clickedItemCount; private uint clickedItemCount;
private string clickedPlayerName; private string? clickedPlayerName;
private ushort? clickedPlayerWorld; private ushort? clickedPlayerWorld;
private ulong? clickedPlayerCid; private ulong? clickedPlayerCid;
private uint? clickedPlayerId; private uint? clickedPlayerId;
private bool multipleTriggerOne;
private bool multipleTriggerTwo;
private enum SubStep private enum SubStep
{ {
Start, Start,
TestItem, TestItem,
TestGameObject, TestGameObject,
TestSubMenu,
TestMultiple,
} }
/// <inheritdoc/> /// <inheritdoc/>
@ -41,6 +46,8 @@ namespace Dalamud.Interface.Internal.Windows.SelfTest.AgingSteps
var contextMenu = Service<ContextMenu>.Get(); var contextMenu = Service<ContextMenu>.Get();
var dataMgr = Service<DataManager>.Get(); var dataMgr = Service<DataManager>.Get();
ImGui.Text(this.currentSubStep.ToString());
switch (this.currentSubStep) switch (this.currentSubStep)
{ {
case SubStep.Start: case SubStep.Start:
@ -64,6 +71,9 @@ namespace Dalamud.Interface.Internal.Windows.SelfTest.AgingSteps
else else
{ {
ImGui.Text("Right-click an item."); ImGui.Text("Right-click an item.");
if (ImGui.Button("Skip"))
this.currentSubStep++;
} }
break; break;
@ -74,7 +84,7 @@ namespace Dalamud.Interface.Internal.Windows.SelfTest.AgingSteps
ImGui.Text($"Did you click \"{this.clickedPlayerName}\", world:{this.clickedPlayerWorld}, cid:{this.clickedPlayerCid}, id:{this.clickedPlayerId}?"); ImGui.Text($"Did you click \"{this.clickedPlayerName}\", world:{this.clickedPlayerWorld}, cid:{this.clickedPlayerCid}, id:{this.clickedPlayerId}?");
if (ImGui.Button("Yes")) if (ImGui.Button("Yes"))
return SelfTestStepResult.Pass; this.currentSubStep++;
ImGui.SameLine(); ImGui.SameLine();
@ -83,10 +93,37 @@ namespace Dalamud.Interface.Internal.Windows.SelfTest.AgingSteps
} }
else else
{ {
ImGui.Text("Right-click an item."); ImGui.Text("Right-click a character.");
if (ImGui.Button("Skip"))
this.currentSubStep++;
} }
break; break;
case SubStep.TestSubMenu:
if (this.multipleTriggerOne && this.multipleTriggerTwo)
{
this.currentSubStep++;
this.multipleTriggerOne = this.multipleTriggerTwo = false;
}
else
{
ImGui.Text("Right-click a character and select both options in the submenu.");
if (ImGui.Button("Skip"))
this.currentSubStep++;
}
break;
case SubStep.TestMultiple:
if (this.multipleTriggerOne && this.multipleTriggerTwo)
return SelfTestStepResult.Pass;
ImGui.Text("Select both options on any context menu.");
if (ImGui.Button("Skip"))
this.currentSubStep++;
break;
default: default:
throw new ArgumentOutOfRangeException(); throw new ArgumentOutOfRangeException();
} }
@ -107,45 +144,80 @@ namespace Dalamud.Interface.Internal.Windows.SelfTest.AgingSteps
private void ContextMenuOnContextMenuOpened(ContextMenuOpenedArgs args) private void ContextMenuOnContextMenuOpened(ContextMenuOpenedArgs args)
{ {
Log.Information("Got context menu with parent addon: {ParentAddonName}", args.ParentAddonName); Log.Information("Got context menu with parent addon: {ParentAddonName}", args.ParentAddonName);
switch (args.ParentAddonName)
switch (this.currentSubStep)
{ {
case "Inventory": case SubStep.TestSubMenu:
if (this.currentSubStep != SubStep.TestItem) args.Items.Add(new OpenSubContextMenuItem("Aging Submenu", openedArgs =>
return;
args.Items.Add(new CustomContextMenuItem("Aging Item Test", selectedArgs =>
{ {
this.clickedItemId = args.InventoryItemContext!.Id; openedArgs.Items.Add(new CustomContextMenuItem("Submenu Item 1", args =>
this.clickedItemHq = args.InventoryItemContext!.IsHighQuality; {
this.clickedItemCount = args.InventoryItemContext!.Count; this.multipleTriggerOne = true;
Log.Warning("Clicked item: {Id} hq:{Hq} count:{Count}", this.clickedItemId, this.clickedItemHq, this.clickedItemCount); }));
openedArgs.Items.Add(new CustomContextMenuItem("Submenu Item 2", args =>
{
this.multipleTriggerTwo = true;
}));
})); }));
break;
case null: return;
case "_PartyList": case SubStep.TestMultiple:
case "ChatLog": args.Items.Insert(0, new CustomContextMenuItem("Aging Item 1", args =>
case "ContactList":
case "ContentMemberList":
case "CrossWorldLinkshell":
case "FreeCompany":
case "FriendList":
case "LookingForGroup":
case "LinkShell":
case "PartyMemberList":
case "SocialList":
if (this.currentSubStep != SubStep.TestGameObject || args.GameObjectContext == null || args.GameObjectContext.Name.IsNullOrEmpty())
return;
args.Items.Add(new CustomContextMenuItem("Aging Character Test", selectedArgs =>
{ {
this.clickedPlayerName = args.GameObjectContext.Name!; this.multipleTriggerOne = true;
this.clickedPlayerWorld = args.GameObjectContext.WorldId;
this.clickedPlayerCid = args.GameObjectContext.ContentId;
this.clickedPlayerId = args.GameObjectContext.Id;
Log.Warning("Clicked player: {Name} world:{World} cid:{Cid} id:{Id}", this.clickedPlayerName, this.clickedPlayerWorld, this.clickedPlayerCid, this.clickedPlayerId);
})); }));
args.Items.Add(new CustomContextMenuItem("Aging Item 2", args =>
{
this.multipleTriggerTwo = true;
}));
return;
default:
switch (args.ParentAddonName)
{
case "Inventory":
if (this.currentSubStep != SubStep.TestItem)
return;
args.Items.Add(new CustomContextMenuItem("Aging Item", selectedArgs =>
{
this.clickedItemId = args.InventoryItemContext!.Id;
this.clickedItemHq = args.InventoryItemContext!.IsHighQuality;
this.clickedItemCount = args.InventoryItemContext!.Count;
Log.Warning("Clicked item: {Id} hq:{Hq} count:{Count}", this.clickedItemId, this.clickedItemHq, this.clickedItemCount);
}));
break;
case null:
case "_PartyList":
case "ChatLog":
case "ContactList":
case "ContentMemberList":
case "CrossWorldLinkshell":
case "FreeCompany":
case "FriendList":
case "LookingForGroup":
case "LinkShell":
case "PartyMemberList":
case "SocialList":
if (this.currentSubStep != SubStep.TestGameObject || args.GameObjectContext == null || args.GameObjectContext.Name.IsNullOrEmpty())
return;
args.Items.Add(new CustomContextMenuItem("Aging Character", selectedArgs =>
{
this.clickedPlayerName = args.GameObjectContext.Name!;
this.clickedPlayerWorld = args.GameObjectContext.WorldId;
this.clickedPlayerCid = args.GameObjectContext.ContentId;
this.clickedPlayerId = args.GameObjectContext.Id;
Log.Warning("Clicked player: {Name} world:{World} cid:{Cid} id:{Id}", this.clickedPlayerName, this.clickedPlayerWorld, this.clickedPlayerCid, this.clickedPlayerId);
}));
break;
}
break; break;
} }
} }