ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-12 18:27:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: don't create plugin output dir before downloading

Browse source
This commit is contained in:
goat 2021-08-24 14:26:12 +02:00
parent 0c52f8099e
commit 66daa03da3
No known key found for this signature in database
GPG key ID: F18F057873895461
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Dalamud/Plugin/Internal/PluginManager.cs
View file

@ -394,6 +394,10 @@ namespace Dalamud.Plugin.Internal
var downloadUrl = useTesting ? repoManifest.DownloadLinkTesting : repoManifest.DownloadLinkInstall; var downloadUrl = useTesting ? repoManifest.DownloadLinkTesting : repoManifest.DownloadLinkInstall;
var version = useTesting ? repoManifest.TestingAssemblyVersion : repoManifest.AssemblyVersion; var version = useTesting ? repoManifest.TestingAssemblyVersion : repoManifest.AssemblyVersion;
using var client = new HttpClient();
var response = await client.GetAsync(downloadUrl);
response.EnsureSuccessStatusCode();
var outputDir = new DirectoryInfo(Path.Combine(this.pluginDirectory.FullName, repoManifest.InternalName, version.ToString())); var outputDir = new DirectoryInfo(Path.Combine(this.pluginDirectory.FullName, repoManifest.InternalName, version.ToString()));
try try
@ -408,10 +412,6 @@ namespace Dalamud.Plugin.Internal
// ignored, since the plugin may be loaded already // ignored, since the plugin may be loaded already
} }
using var client = new HttpClient();
var response = await client.GetAsync(downloadUrl);
response.EnsureSuccessStatusCode();
Log.Debug($"Extracting to {outputDir}"); Log.Debug($"Extracting to {outputDir}");
// This throws an error, even with overwrite=false // This throws an error, even with overwrite=false
// ZipFile.ExtractToDirectory(tempZip.FullName, outputDir.FullName, false); // ZipFile.ExtractToDirectory(tempZip.FullName, outputDir.FullName, false);