From 70af62885b105ad98df341b50841b5fdb93ce95c Mon Sep 17 00:00:00 2001 From: srkizer Date: Wed, 18 Dec 2024 00:31:44 +0900 Subject: [PATCH] chore: remove [Experimental] from SeStringRenderer (#2144) It hasn't caused problem for a while (though performance probably can be better), and looks good enough to remove this attribute. --- Dalamud/Interface/Internal/UiDebug2/Browsing/NodeTree.Text.cs | 2 -- .../Internal/Windows/Data/Widgets/AtkArrayDataBrowserWidget.cs | 2 -- .../Interface/Internal/Windows/Data/Widgets/InventoryWidget.cs | 2 -- .../Internal/Windows/Data/Widgets/SeStringRendererTestWidget.cs | 2 -- Dalamud/Interface/Utility/ImGuiHelpers.cs | 2 -- 5 files changed, 10 deletions(-) diff --git a/Dalamud/Interface/Internal/UiDebug2/Browsing/NodeTree.Text.cs b/Dalamud/Interface/Internal/UiDebug2/Browsing/NodeTree.Text.cs index 7c924f503..61e0e79b8 100644 --- a/Dalamud/Interface/Internal/UiDebug2/Browsing/NodeTree.Text.cs +++ b/Dalamud/Interface/Internal/UiDebug2/Browsing/NodeTree.Text.cs @@ -60,9 +60,7 @@ internal unsafe partial class TextNodeTree : ResNodeTree EdgeStrength = 1f, }; -#pragma warning disable SeStringRenderer ImGuiHelpers.SeStringWrapped(this.NodeText.AsSpan(), style); -#pragma warning restore SeStringRenderer } catch { diff --git a/Dalamud/Interface/Internal/Windows/Data/Widgets/AtkArrayDataBrowserWidget.cs b/Dalamud/Interface/Internal/Windows/Data/Widgets/AtkArrayDataBrowserWidget.cs index c134e02c3..791dc5310 100644 --- a/Dalamud/Interface/Internal/Windows/Data/Widgets/AtkArrayDataBrowserWidget.cs +++ b/Dalamud/Interface/Internal/Windows/Data/Widgets/AtkArrayDataBrowserWidget.cs @@ -12,8 +12,6 @@ using Lumina.Text.ReadOnly; namespace Dalamud.Interface.Internal.Windows.Data.Widgets; -#pragma warning disable SeStringRenderer - /// /// Widget for displaying AtkArrayData. /// diff --git a/Dalamud/Interface/Internal/Windows/Data/Widgets/InventoryWidget.cs b/Dalamud/Interface/Internal/Windows/Data/Widgets/InventoryWidget.cs index ac576da77..5cefc0853 100644 --- a/Dalamud/Interface/Internal/Windows/Data/Widgets/InventoryWidget.cs +++ b/Dalamud/Interface/Internal/Windows/Data/Widgets/InventoryWidget.cs @@ -18,8 +18,6 @@ using Lumina.Excel.Sheets; namespace Dalamud.Interface.Internal.Windows.Data.Widgets; -#pragma warning disable SeStringRenderer - /// /// Widget for displaying inventory data. /// diff --git a/Dalamud/Interface/Internal/Windows/Data/Widgets/SeStringRendererTestWidget.cs b/Dalamud/Interface/Internal/Windows/Data/Widgets/SeStringRendererTestWidget.cs index e026a6d2f..5afda62ac 100644 --- a/Dalamud/Interface/Internal/Windows/Data/Widgets/SeStringRendererTestWidget.cs +++ b/Dalamud/Interface/Internal/Windows/Data/Widgets/SeStringRendererTestWidget.cs @@ -23,8 +23,6 @@ using Lumina.Text.ReadOnly; namespace Dalamud.Interface.Internal.Windows.Data.Widgets; -#pragma warning disable SeStringRenderer - /// /// Widget for displaying Addon Data. /// diff --git a/Dalamud/Interface/Utility/ImGuiHelpers.cs b/Dalamud/Interface/Utility/ImGuiHelpers.cs index 8dedae5cd..2093d9bcb 100644 --- a/Dalamud/Interface/Utility/ImGuiHelpers.cs +++ b/Dalamud/Interface/Utility/ImGuiHelpers.cs @@ -212,7 +212,6 @@ public static class ImGuiHelpers /// Interaction result of the rendered text. /// This function is experimental. Report any issues to GitHub issues or to Discord #dalamud-dev channel. /// The function definition is stable; only in the next API version a function may be removed. - [Experimental("SeStringRenderer")] public static SeStringDrawResult SeStringWrapped( ReadOnlySpan sss, scoped in SeStringDrawParams style = default, @@ -229,7 +228,6 @@ public static class ImGuiHelpers /// Interaction result of the rendered text. /// This function is experimental. Report any issues to GitHub issues or to Discord #dalamud-dev channel. /// The function definition is stable; only in the next API version a function may be removed. - [Experimental("SeStringRenderer")] public static SeStringDrawResult CompileSeStringWrapped( string text, scoped in SeStringDrawParams style = default,