ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-12 18:27:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: PM should not depend on scoped plugin services, their lifetime is managed by scopes

Browse source
This commit is contained in:
goat 2023-05-22 21:34:43 +02:00
parent 6a055783ba
commit 71bf9fdcf2
No known key found for this signature in database
GPG key ID: 49E2AA8C6A76498B
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Dalamud/Service{T}.cs
View file

@ -154,6 +154,10 @@ internal static class Service<T> where T : IServiceType
if (attr == null) if (attr == null)
continue; continue;
// Scoped plugin services lifetime is tied to their scopes. They go away when LocalPlugin goes away.
if (serviceType.GetServiceKind() == ServiceManager.ServiceKind.ScopedService)
continue;
ServiceManager.Log.Verbose("PluginManager MUST depend on {Type}", serviceType.FullName!); ServiceManager.Log.Verbose("PluginManager MUST depend on {Type}", serviceType.FullName!);
res.Add(serviceType); res.Add(serviceType);
} }