ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-12 10:17:22 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Comments on RemoveNonDalamudInvocations

Browse source
This commit is contained in:
Soreepeong 2024-03-14 12:54:12 +09:00
parent 16022ea46a
commit 76ca202f38
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Dalamud/Interface/ImGuiNotification/Internal/ActiveNotification.cs
View file

@ -252,6 +252,14 @@ internal sealed partial class ActiveNotification : IActiveNotification
}
/// <summary>Removes non-Dalamud invocation targets from events.</summary>
/// <remarks>
/// This is done to prevent references of plugins being unloaded from outliving the plugin itself.
/// Anything that can contain plugin-provided types and functions count, which effectively means that events and
/// interface/object-typed fields need to be scrubbed.
/// As a notification can be marked as non-user-dismissable, in which case after removing event handlers there will
/// be no way to remove the notification, we force the notification to become user-dismissable, and reset the expiry
/// to the default duration on unload.
/// </remarks>
internal void RemoveNonDalamudInvocations()
{
var dalamudContext = AssemblyLoadContext.GetLoadContext(typeof(NotificationManager).Assembly);