ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-13 12:14:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix AddRectFilledDetour typo (#1667)

Browse source 
* Fix AddRectFilledDetour typo

* Skip drawing if zero opacity is specified for drawing
This commit is contained in:
srkizer 2024-02-18 16:03:51 +09:00 • committed by GitHub
parent 7da47a8a33
commit 7dc99c9307
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Dalamud/Interface/Internal/ImGuiDrawListFixProvider.cs
View file

@ -83,8 +83,14 @@ internal sealed unsafe class ImGuiDrawListFixProvider : IServiceType, IDisposabl
float rounding, float rounding,
ImDrawFlags flags) ImDrawFlags flags)
{ {
if (rounding < 0 || (flags & ImDrawFlags.RoundCornersMask) == ImDrawFlags.RoundCornersMask) // Skip drawing if we're drawing something with alpha value of 0.
if ((col & 0xFF000000) == 0)
return;
if (rounding < 0.5f || (flags & ImDrawFlags.RoundCornersMask) == ImDrawFlags.RoundCornersMask)
{ {
// Take the fast path of drawing two triangles if no rounded corners are required.
var texIdCommon = *(nint*)(drawListPtr._Data + CImGuiImDrawListSharedDataTexIdCommonOffset); var texIdCommon = *(nint*)(drawListPtr._Data + CImGuiImDrawListSharedDataTexIdCommonOffset);
var pushTextureId = texIdCommon != drawListPtr._CmdHeader.TextureId; var pushTextureId = texIdCommon != drawListPtr._CmdHeader.TextureId;
if (pushTextureId) if (pushTextureId)
@ -98,6 +104,9 @@ internal sealed unsafe class ImGuiDrawListFixProvider : IServiceType, IDisposabl
} }
else else
{ {
// Defer drawing rectangle with rounded corners to path drawing operations.
// Note that this may have a slightly different extent behaviors from the above if case.
// This is how it is in imgui_draw.cpp.
drawListPtr.PathRect(min, max, rounding, flags); drawListPtr.PathRect(min, max, rounding, flags);
drawListPtr.PathFillConvex(col); drawListPtr.PathFillConvex(col);
} }