ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-12 10:17:22 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: improve custom repo disclaimer a bit

Browse source
This commit is contained in:
goat 2023-08-30 23:53:24 +02:00
parent efefcd70cf
commit 8a267e51bf
No known key found for this signature in database
GPG key ID: 49E2AA8C6A76498B
4 changed files with 75 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Dalamud/Configuration/Internal/DalamudConfiguration.cs
View file

@ -100,6 +100,11 @@ internal sealed class DalamudConfiguration : IServiceType
/// </summary>
public List<ThirdPartyRepoSettings> ThirdRepoList { get; set; } = new();
/// <summary>
/// Gets or sets a value indicating whether or not a disclaimer regarding third-party repos has been dismissed.
/// </summary>
public bool? ThirdRepoSpeedbumpDismissed { get; set; } = null;
/// <summary>
/// Gets or sets a list of hidden plugins.
/// </summary>

8
Dalamud/Interface/Internal/Windows/Settings/SettingsEntry.cs
View file

@ -42,6 +42,14 @@ public abstract class SettingsEntry
/// </summary>
public abstract void Draw();
/// <summary>
/// Function to be called when the tab is opened.
/// </summary>
public virtual void OnOpen()
{
// ignored
}
/// <summary>
/// Function to be called when the tab is closed.
/// </summary>

5
Dalamud/Interface/Internal/Windows/Settings/SettingsTab.cs
View file

@ -16,7 +16,10 @@ public abstract class SettingsTab : IDisposable
public virtual void OnOpen()
{
// ignored
foreach (var settingsEntry in this.Entries)
{
settingsEntry.OnOpen();
}
}
public virtual void OnClose()

61
Dalamud/Interface/Internal/Windows/Settings/Widgets/ThirdRepoSettingsEntry.cs
View file

@ -12,6 +12,7 @@ using Dalamud.Interface.Colors;
using Dalamud.Interface.Components;
using Dalamud.Interface.Raii;
using Dalamud.Plugin.Internal;
using Dalamud.Utility;
using ImGuiNET;
namespace Dalamud.Interface.Internal.Windows.Settings.Widgets;
@ -23,7 +24,13 @@ public class ThirdRepoSettingsEntry : SettingsEntry
private bool thirdRepoListChanged;
private string thirdRepoTempUrl = string.Empty;
private string thirdRepoAddError = string.Empty;
private DateTime timeSinceOpened;
public override void OnOpen()
{
this.timeSinceOpened = DateTime.Now;
}
public override void OnClose()
{
this.thirdRepoList =
@ -51,6 +58,8 @@ public class ThirdRepoSettingsEntry : SettingsEntry
public override void Draw()
{
var config = Service<DalamudConfiguration>.Get();
using var id = ImRaii.PushId("thirdRepo");
ImGui.TextUnformatted(Loc.Localize("DalamudSettingsCustomRepo", "Custom Plugin Repositories"));
if (this.thirdRepoListChanged)
@ -61,13 +70,59 @@ public class ThirdRepoSettingsEntry : SettingsEntry
ImGui.TextUnformatted(Loc.Localize("DalamudSettingsChanged", "(Changed)"));
}
}
ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudGrey, Loc.Localize("DalamudSettingCustomRepoHint", "Add custom plugin repositories."));
ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudRed, Loc.Localize("DalamudSettingCustomRepoWarning", "We cannot take any responsibility for third-party plugins and repositories."));
ImGuiHelpers.ScaledDummy(2);
config.ThirdRepoSpeedbumpDismissed ??= config.ThirdRepoList.Any(x => x.IsEnabled);
var disclaimerDismissed = config.ThirdRepoSpeedbumpDismissed.Value;
ImGui.PushFont(InterfaceManager.IconFont);
ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudRed, FontAwesomeIcon.ExclamationTriangle.ToIconString());
ImGui.PopFont();
ImGui.SameLine();
ImGuiHelpers.ScaledDummy(2);
ImGui.SameLine();
ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudRed, Loc.Localize("DalamudSettingCustomRepoWarningReadThis", "READ THIS FIRST!"));
ImGui.SameLine();
ImGuiHelpers.ScaledDummy(2);
ImGui.SameLine();
ImGui.PushFont(InterfaceManager.IconFont);
ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudRed, FontAwesomeIcon.ExclamationTriangle.ToIconString());
ImGui.PopFont();
ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudRed, Loc.Localize("DalamudSettingCustomRepoWarning", "We cannot take any responsibility for custom plugins and repositories."));
ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudRed, Loc.Localize("DalamudSettingCustomRepoWarning5", "If someone told you to copy/paste something here, it's very possible that you are being scammed or taken advantage of."));
ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudRed, Loc.Localize("DalamudSettingCustomRepoWarning2", "Plugins have full control over your PC, like any other program, and may cause harm or crashes."));
ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudRed, Loc.Localize("DalamudSettingCustomRepoWarning4", "They can delete your character, upload your family photos and burn down your house."));
ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudRed, Loc.Localize("DalamudSettingCustomRepoWarning4", "They can delete your character, steal your FC or Discord account, and burn down your house."));
ImGuiHelpers.SafeTextColoredWrapped(ImGuiColors.DalamudRed, Loc.Localize("DalamudSettingCustomRepoWarning3", "Please make absolutely sure that you only install third-party plugins from developers you trust."));
if (!disclaimerDismissed)
{
const int speedbumpTime = 15;
var elapsed = DateTime.Now - this.timeSinceOpened;
if (elapsed < TimeSpan.FromSeconds(speedbumpTime))
{
ImGui.BeginDisabled();
ImGui.Button(
Loc.Localize("DalamudSettingCustomRepoWarningPleaseWait", "Please wait {0} seconds...").Format(speedbumpTime - elapsed.Seconds));
ImGui.EndDisabled();
}
else
{
if (ImGui.Button(Loc.Localize("DalamudSettingCustomRepoWarningIReadIt", "Ok, I have read and understood this warning")))
{
config.ThirdRepoSpeedbumpDismissed = true;
config.QueueSave();
}
}
}
ImGuiHelpers.ScaledDummy(2);
using var disabled = ImRaii.Disabled(!disclaimerDismissed);
ImGuiHelpers.ScaledDummy(5);
ImGui.Columns(4);