From 9472a315dfee04ca6b418f4a7110db60b72c97eb Mon Sep 17 00:00:00 2001 From: Kaz Wolfe Date: Sun, 30 Jun 2024 13:48:57 -0700 Subject: [PATCH] doc reshade changes --- .../Game/Internal/DXGI/SwapChainVtableResolver.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Dalamud/Game/Internal/DXGI/SwapChainVtableResolver.cs b/Dalamud/Game/Internal/DXGI/SwapChainVtableResolver.cs index b7d703151..3a9f93c48 100644 --- a/Dalamud/Game/Internal/DXGI/SwapChainVtableResolver.cs +++ b/Dalamud/Game/Internal/DXGI/SwapChainVtableResolver.cs @@ -67,15 +67,15 @@ internal class SwapChainVtableResolver : BaseAddressResolver, ISwapChainAddressR if (!fileInfo.FileDescription.Contains("GShade") && !fileInfo.FileDescription.Contains("ReShade")) break; - + + // warning: these comments may no longer be accurate. // reshade master@4232872 RVA // var p = processModule.BaseAddress + 0x82C7E0; // DXGISwapChain::Present // var p = processModule.BaseAddress + 0x82FAC0; // DXGISwapChain::runtime_present - // DXGISwapChain::handle_device_loss => DXGISwapChain::Present => DXGISwapChain::runtime_present var scanner = new SigScanner(processModule); - var runtimePresentSig = "F6 C2 01 0F 85 88"; + var runtimePresentSig = "F6 C2 01 0F 85 88"; // NOTE: This sig is from reshade's DLL, normally dxgi.dll. try { @@ -88,13 +88,13 @@ internal class SwapChainVtableResolver : BaseAddressResolver, ISwapChainAddressR } catch (Exception ex) { - Log.Error(ex, "Failed to get reshade version info - falling back to default DXGISwapChain::runtime_present signature"); + Log.Error(ex, "Failed to get reshade version info - falling back to default DXGISwapChain::on_present signature"); } try { var p = scanner.ScanText(runtimePresentSig); - Log.Information($"ReShade DLL: {processModule.FileName} with DXGISwapChain::runtime_present at {p:X}"); + Log.Information($"ReShade DLL: {processModule.FileName} with DXGISwapChain::on_present at {p:X}"); this.Present = p; this.IsReshade = true; @@ -102,7 +102,7 @@ internal class SwapChainVtableResolver : BaseAddressResolver, ISwapChainAddressR } catch (Exception ex) { - Log.Error(ex, "Could not find reshade DXGISwapChain::runtime_present offset!"); + Log.Error(ex, "Could not find reshade DXGISwapChain::on_present offset!"); } } }