ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-15 05:04:15 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

api10 todo: fix cast times (#1861)

Browse source
This commit is contained in:
Aireil 2024-06-29 00:51:30 +02:00 • committed by GitHub
parent 1d1b60b011
commit 9815087e54
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Dalamud/Game/ClientState/Objects/Types/BattleChara.cs
View file

@ -40,12 +40,10 @@ internal unsafe class BattleChara : Character, IBattleChara
public float CurrentCastTime => this.Struct->GetCastInfo()->CurrentCastTime; public float CurrentCastTime => this.Struct->GetCastInfo()->CurrentCastTime;
/// <inheritdoc/> /// <inheritdoc/>
[Api10ToDo("Rename so it is not confused with AdjustedTotalCastTime")] public float BaseCastTime => this.Struct->GetCastInfo()->BaseCastTime;
public float TotalCastTime => this.Struct->GetCastInfo()->TotalCastTime;
/// <inheritdoc/> /// <inheritdoc/>
[Api10ToDo("Rename so it is not confused with TotalCastTime")] public float TotalCastTime => this.Struct->GetCastInfo()->TotalCastTime;
public float AdjustedTotalCastTime => this.Struct->GetCastInfo()->AdjustedTotalCastTime;
/// <summary> /// <summary>
/// Gets the underlying structure. /// Gets the underlying structure.
@ -94,19 +92,16 @@ public interface IBattleChara : ICharacter
public float CurrentCastTime { get; } public float CurrentCastTime { get; }
/// <summary> /// <summary>
/// Gets the total casting time of the spell being cast by the chara. /// Gets the base casting time of the spell being cast by the chara.
/// </summary> /// </summary>
/// <remarks> /// <remarks>
/// This can only be a portion of the total cast for some actions. /// This can only be a portion of the total cast for some actions.
/// Use AdjustedTotalCastTime if you always need the total cast time. /// Use TotalCastTime if you always need the total cast time.
/// </remarks> /// </remarks>
public float TotalCastTime { get; } public float BaseCastTime { get; }
/// <summary> /// <summary>
/// Gets the <see cref="TotalCastTime"/> plus any adjustments from the game, such as Action offset 2B. Used for display purposes. /// Gets the <see cref="BaseCastTime"/> plus any adjustments from the game, such as Action offset 2B. Used for display purposes.
/// </summary> /// </summary>
/// <remarks> public float TotalCastTime { get; }
/// This is the actual total cast time for all actions.
/// </remarks>
public float AdjustedTotalCastTime { get; }
} }