Merge pull request #413 from daemitus/italics

This commit is contained in:
goaaats 2021-07-16 14:36:45 +02:00 committed by GitHub
commit 9d9a80e75d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 22 deletions

View file

@ -1,6 +1,5 @@
using System;
using System.Collections.Generic;
using System.Drawing;
using System.Linq;
using System.Reflection;
using System.Text;
@ -11,7 +10,6 @@ using CheapLoc;
using Dalamud.Game.Text;
using Dalamud.Game.Text.SeStringHandling;
using Dalamud.Game.Text.SeStringHandling.Payloads;
using Dalamud.Interface.Internal.Windows;
using Serilog;
namespace Dalamud.Game
@ -121,24 +119,21 @@ namespace Dalamud.Game
/// </summary>
public string LastLink { get; private set; }
// /// <summary>
// /// Convert a string to SeString and wrap in italics payloads.
// /// </summary>
// /// <param name="text">Text to convert.</param>
// /// <returns>SeString payload of italicized text.</returns>
// private static SeString MakeItalics(string text)
// {
// // TODO: when the code OnCharMessage is switched to SeString, this can be a straight insertion of the
// // italics payloads only, and be a lot cleaner
// var italicString = new SeString(new List<Payload>(new Payload[]
// {
// EmphasisItalicPayload.ItalicsOn,
// new TextPayload(text),
// EmphasisItalicPayload.ItalicsOff,
// }));
//
// return italicString;
// }
/// <summary>
/// Convert a TextPayload to SeString and wrap in italics payloads.
/// </summary>
/// <param name="text">Text to convert.</param>
/// <returns>SeString payload of italicized text.</returns>
public static SeString MakeItalics(string text)
=> MakeItalics(new TextPayload(text));
/// <summary>
/// Convert a TextPayload to SeString and wrap in italics payloads.
/// </summary>
/// <param name="text">Text to convert.</param>
/// <returns>SeString payload of italicized text.</returns>
public static SeString MakeItalics(TextPayload text)
=> new(EmphasisItalicPayload.ItalicsOn, text, EmphasisItalicPayload.ItalicsOff);
private void OnCheckMessageHandled(XivChatType type, uint senderid, ref SeString sender, ref SeString message, ref bool isHandled)
{

View file

@ -38,7 +38,7 @@ namespace Dalamud.Game.Text.SeStringHandling
/// Creates a new SeString from an ordered list of payloads.
/// </summary>
/// <param name="payloads">The Payload objects to make up this string.</param>
public SeString(Payload[] payloads)
public SeString(params Payload[] payloads)
{
this.Payloads = new List<Payload>(payloads);
}
@ -70,7 +70,7 @@ namespace Dalamud.Game.Text.SeStringHandling
/// </summary>
/// <param name="str">string to convert.</param>
/// <returns>Equivalent SeString.</returns>
public static implicit operator SeString(string str) => new(new Payload[] { new TextPayload(str) });
public static implicit operator SeString(string str) => new(new TextPayload(str));
/// <summary>
/// Creates a SeString from a json. (For testing - not recommended for production use.)