ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-15 13:14:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix duplicate imgui ID on plugin control buttons

Browse source
This commit is contained in:
Raymond 2021-08-10 08:35:21 -04:00
parent ec7a4076d5
commit bc024b17e1
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Dalamud/Interface/Internal/Windows/PluginInstallerWindow.cs
View file

@ -614,7 +614,9 @@ namespace Dalamud.Interface.Internal.Windows
label += Locs.PluginTitleMod_TestingVersion; label += Locs.PluginTitleMod_TestingVersion;
} }
if (this.DrawPluginCollapsingHeader(label, manifest, false, false, index)) ImGui.PushID($"available{index}{manifest.InternalName}");
if (ImGui.CollapsingHeader($"{label}###Header"))
{ {
ImGuiHelpers.ScaledDummy(5); ImGuiHelpers.ScaledDummy(5);
@ -709,6 +711,8 @@ namespace Dalamud.Interface.Internal.Windows
ImGui.EndPopup(); ImGui.EndPopup();
} }
ImGui.PopID();
} }
private void DrawInstalledPlugin(LocalPlugin plugin, int index, bool showInstalled = false) private void DrawInstalledPlugin(LocalPlugin plugin, int index, bool showInstalled = false)
@ -782,7 +786,9 @@ namespace Dalamud.Interface.Internal.Windows
trouble = true; trouble = true;
} }
if (this.DrawPluginCollapsingHeader(label, plugin.Manifest, trouble, availablePluginUpdate != default, index)) ImGui.PushID($"installed{index}{plugin.Manifest.InternalName}");
if (ImGui.CollapsingHeader($"{label}###Header"))
{ {
var manifest = plugin.Manifest; var manifest = plugin.Manifest;
@ -880,6 +886,8 @@ namespace Dalamud.Interface.Internal.Windows
ImGui.EndPopup(); ImGui.EndPopup();
} }
ImGui.PopID();
} }
private void DrawPluginControlButton(LocalPlugin plugin) private void DrawPluginControlButton(LocalPlugin plugin)