From c55b93d3c2bd6fe3b71919d5c873028fc6de7adf Mon Sep 17 00:00:00 2001
From: goat <goatsdev@protonmail.com>
Date: Sat, 23 Sep 2023 11:17:53 +0200
Subject: [PATCH] chore: remove IDalamudPlugin.Name

---
 Dalamud.CorePlugin/PluginImpl.cs             | 9 ++-------
 Dalamud/Plugin/IDalamudPlugin.cs             | 4 ----
 Dalamud/Plugin/Internal/Types/LocalPlugin.cs | 7 -------
 3 files changed, 2 insertions(+), 18 deletions(-)

diff --git a/Dalamud.CorePlugin/PluginImpl.cs b/Dalamud.CorePlugin/PluginImpl.cs
index e2b373d42..5ed672f2d 100644
--- a/Dalamud.CorePlugin/PluginImpl.cs
+++ b/Dalamud.CorePlugin/PluginImpl.cs
@@ -1,5 +1,6 @@
 using System;
 using System.IO;
+
 using Dalamud.Configuration.Internal;
 using Dalamud.Game.Command;
 using Dalamud.Interface.Windowing;
@@ -37,9 +38,6 @@ namespace Dalamud.CorePlugin
         {
         }
 
-        /// <inheritdoc/>
-        public string Name => "Dalamud.CorePlugin";
-
         /// <inheritdoc/>
         public void Dispose()
         {
@@ -71,7 +69,7 @@ namespace Dalamud.CorePlugin
                 this.Interface.UiBuilder.OpenConfigUi += this.OnOpenConfigUi;
                 this.Interface.UiBuilder.OpenMainUi += this.OnOpenMainUi;
 
-                Service<CommandManager>.Get().AddHandler("/coreplug", new(this.OnCommand) { HelpMessage = $"Access the {this.Name} plugin." });
+                Service<CommandManager>.Get().AddHandler("/coreplug", new(this.OnCommand) { HelpMessage = "Access the plugin." });
 
                 log.Information("CorePlugin ctor!");
             }
@@ -81,9 +79,6 @@ namespace Dalamud.CorePlugin
             }
         }
 
-        /// <inheritdoc/>
-        public string Name => "Dalamud.CorePlugin";
-
         /// <summary>
         /// Gets the plugin interface.
         /// </summary>
diff --git a/Dalamud/Plugin/IDalamudPlugin.cs b/Dalamud/Plugin/IDalamudPlugin.cs
index c752df3d6..b48d55d1c 100644
--- a/Dalamud/Plugin/IDalamudPlugin.cs
+++ b/Dalamud/Plugin/IDalamudPlugin.cs
@@ -7,8 +7,4 @@ namespace Dalamud.Plugin;
 /// </summary>
 public interface IDalamudPlugin : IDisposable
 {
-    /// <summary>
-    /// Gets the name of the plugin.
-    /// </summary>
-    string Name { get; }
 }
diff --git a/Dalamud/Plugin/Internal/Types/LocalPlugin.cs b/Dalamud/Plugin/Internal/Types/LocalPlugin.cs
index f7306b5a7..80d6edfd3 100644
--- a/Dalamud/Plugin/Internal/Types/LocalPlugin.cs
+++ b/Dalamud/Plugin/Internal/Types/LocalPlugin.cs
@@ -505,13 +505,6 @@ internal class LocalPlugin : IDisposable
                 return;
             }
 
-            // In-case the manifest name was a placeholder. Can occur when no manifest was included.
-            if (this.manifest.Name.IsNullOrEmpty() && !this.IsDev)
-            {
-                this.manifest.Name = this.instance.Name;
-                this.manifest.Save(this.manifestFile, "manifest name null or empty");
-            }
-
             this.State = PluginState.Loaded;
             Log.Information($"Finished loading {this.DllFile.Name}");
         }