ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-28 03:19:19 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

hooking ResizeBuffers() appears to be unnecessary, even though we maintain a view to the backbuffer. Leaving the signature (commented out) for now in case it does end up being something we have to handle

Browse source
This commit is contained in:
meli 2020-01-09 19:02:40 -08:00
parent 5623b2ceb8
commit c80f400a2f
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Dalamud/Interface/InterfaceManager.cs
View file

@ -11,7 +11,7 @@ using Serilog;
// general dev notes, here because it's easiest
/*
* - We probably need to hook ResizeBuffers too at a minimum.. not releasing things may cause crashes.
* - Hooking ResizeBuffers seemed to be unnecessary, though I'm not sure why. Left out for now since it seems to work without it.
* - It's probably virtually impossible to remove the present hook once we set it, which again may lead to crashes in various situations.
* - We may want to build our ImGui command list in a thread to keep it divorced from present. We'd still have to block in present to
* synchronize on the list and render it, but ideally the overall delay we add to present would then be shorter. This may cause minor