From c8566fc9b23948a241343ff4f177fb5b990a5377 Mon Sep 17 00:00:00 2001
From: goat <16760685+goaaats@users.noreply.github.com>
Date: Sat, 28 Aug 2021 19:05:48 +0200
Subject: [PATCH] refactor: make Lumina=>Dalamud conversion explicit extension
 method

---
 Dalamud/Game/Text/SeStringHandling/SeString.cs |  7 -------
 Dalamud/Utility/SeStringExtensions.cs          | 18 ++++++++++++++++++
 2 files changed, 18 insertions(+), 7 deletions(-)
 create mode 100644 Dalamud/Utility/SeStringExtensions.cs

diff --git a/Dalamud/Game/Text/SeStringHandling/SeString.cs b/Dalamud/Game/Text/SeStringHandling/SeString.cs
index 76efcf707..8538d554e 100644
--- a/Dalamud/Game/Text/SeStringHandling/SeString.cs
+++ b/Dalamud/Game/Text/SeStringHandling/SeString.cs
@@ -89,13 +89,6 @@ namespace Dalamud.Game.Text.SeStringHandling
         /// <returns>Equivalent SeString.</returns>
         public static implicit operator SeString(string str) => new(new TextPayload(str));
 
-        /// <summary>
-        /// Implicitly parse a Lumina SeString into a Dalamud SeString.
-        /// </summary>
-        /// <param name="luminaString">The Lumina SeString.</param>
-        /// <returns>The re-parsed Dalamud SeString.</returns>
-        public static implicit operator SeString(Lumina.Text.SeString luminaString) => Parse(luminaString.RawData);
-
         /// <summary>
         /// Parse a binary game message into an SeString.
         /// </summary>
diff --git a/Dalamud/Utility/SeStringExtensions.cs b/Dalamud/Utility/SeStringExtensions.cs
new file mode 100644
index 000000000..dca423eab
--- /dev/null
+++ b/Dalamud/Utility/SeStringExtensions.cs
@@ -0,0 +1,18 @@
+using Dalamud.Game.Text.SeStringHandling;
+
+namespace Dalamud.Utility
+{
+    /// <summary>
+    /// Extension methods for SeStrings.
+    /// </summary>
+    public static class SeStringExtensions
+    {
+        /// <summary>
+        /// Convert a Lumina SeString into a Dalamud SeString.
+        /// This conversion re-parses the string.
+        /// </summary>
+        /// <param name="originalString">The original Lumina SeString.</param>
+        /// <returns>The re-parsed Dalamud SeString.</returns>
+        public static SeString ToDalamudString(this Lumina.Text.SeString originalString) => SeString.Parse(originalString.RawData);
+    }
+}