Move Game/Network files to the appropriate internal namespaces

Replace WebClient with HttpClient

Dalamud/Game/Network/Structures/MarketBoardCurrentOfferings.cs

@@ -5,14 +5,43 @@ using System.Text;
 
 namespace Dalamud.Game.Network.Structures
 {
+    /// <summary>
+    /// This class represents the current market board offerings from a game network packet.
+    /// </summary>
     public class MarketBoardCurrentOfferings
     {
-        public List<MarketBoardItemListing> ItemListings;
+        /// <summary>
+        /// Initializes a new instance of the <see cref="MarketBoardCurrentOfferings"/> class.
+        /// </summary>
+        internal MarketBoardCurrentOfferings()
+        {
+        }
 
-        public int ListingIndexEnd;
-        public int ListingIndexStart;
-        public int RequestId;
+        /// <summary>
+        /// Gets the list of individual item listings.
+        /// </summary>
+        public List<MarketBoardItemListing> ItemListings { get; internal set; }
 
+        /// <summary>
+        /// Gets the listing end index.
+        /// </summary>
+        public int ListingIndexEnd { get; internal set; }
+
+        /// <summary>
+        /// Gets the listing start index.
+        /// </summary>
+        public int ListingIndexStart { get; internal set; }
+
+        /// <summary>
+        /// Gets the request ID.
+        /// </summary>
+        public int RequestId { get; internal set; }
+
+        /// <summary>
+        /// Read a <see cref="MarketBoardCurrentOfferings"/> object from memory.
+        /// </summary>
+        /// <param name="dataPtr">Address to read.</param>
+        /// <returns>A new <see cref="MarketBoardCurrentOfferings"/> object.</returns>
         public static unsafe MarketBoardCurrentOfferings Read(IntPtr dataPtr)
         {
             var output = new MarketBoardCurrentOfferings();
@@ -80,32 +109,124 @@ namespace Dalamud.Game.Network.Structures
             return output;
         }
 
+        /// <summary>
+        /// This class represents the current market board offering of a single item from the <see cref="MarketBoardCurrentOfferings"/> network packet.
+        /// </summary>
         public class MarketBoardItemListing
         {
-            public ulong ArtisanId;
-            public uint CatalogId;
-            public bool IsHq;
-            public uint ItemQuantity;
-            public DateTime LastReviewTime;
-            public ulong ListingId;
+            /// <summary>
+            /// Initializes a new instance of the <see cref="MarketBoardItemListing"/> class.
+            /// </summary>
+            internal MarketBoardItemListing()
+            {
+            }
 
-            public List<ItemMateria> Materia;
-            public int MateriaCount;
-            public bool OnMannequin;
-            public string PlayerName;
-            public uint PricePerUnit;
-            public int RetainerCityId;
-            public ulong RetainerId;
+            /// <summary>
+            /// Gets the artisan ID.
+            /// </summary>
+            public ulong ArtisanId { get; internal set; }
 
-            public string RetainerName;
-            public ulong RetainerOwnerId;
-            public int StainId;
-            public uint TotalTax;
+            /// <summary>
+            /// Gets the catalog ID.
+            /// </summary>
+            public uint CatalogId { get; internal set; }
 
+            /// <summary>
+            /// Gets a value indicating whether the item is HQ.
+            /// </summary>
+            public bool IsHq { get; internal set; }
+
+            /// <summary>
+            /// Gets the item quantity.
+            /// </summary>
+            public uint ItemQuantity { get; internal set; }
+
+            /// <summary>
+            /// Gets the time this offering was last reviewed.
+            /// </summary>
+            public DateTime LastReviewTime { get; internal set; }
+
+            /// <summary>
+            /// Gets the listing ID.
+            /// </summary>
+            public ulong ListingId { get; internal set; }
+
+            /// <summary>
+            /// Gets the list of materia attached to this item.
+            /// </summary>
+            public List<ItemMateria> Materia { get; internal set; }
+
+            /// <summary>
+            /// Gets the amount of attached materia.
+            /// </summary>
+            public int MateriaCount { get; internal set; }
+
+            /// <summary>
+            /// Gets a value indicating whether this item is on a mannequin.
+            /// </summary>
+            public bool OnMannequin { get; internal set; }
+
+            /// <summary>
+            /// Gets the player name.
+            /// </summary>
+            public string PlayerName { get; internal set; }
+
+            /// <summary>
+            /// Gets the price per unit.
+            /// </summary>
+            public uint PricePerUnit { get; internal set; }
+
+            /// <summary>
+            /// Gets the city ID of the retainer selling the item.
+            /// </summary>
+            public int RetainerCityId { get; internal set; }
+
+            /// <summary>
+            /// Gets the ID of the retainer selling the item.
+            /// </summary>
+            public ulong RetainerId { get; internal set; }
+
+            /// <summary>
+            /// Gets the name of the retainer.
+            /// </summary>
+            public string RetainerName { get; internal set; }
+
+            /// <summary>
+            /// Gets the ID of the retainer's owner.
+            /// </summary>
+            public ulong RetainerOwnerId { get; internal set; }
+
+            /// <summary>
+            /// Gets the stain or applied dye of the item.
+            /// </summary>
+            public int StainId { get; internal set; }
+
+            /// <summary>
+            /// Gets the total tax.
+            /// </summary>
+            public uint TotalTax { get; internal set; }
+
+            /// <summary>
+            /// This represents the materia slotted to an <see cref="MarketBoardItemListing"/>.
+            /// </summary>
             public class ItemMateria
             {
-                public int Index;
-                public int MateriaId;
+                /// <summary>
+                /// Initializes a new instance of the <see cref="ItemMateria"/> class.
+                /// </summary>
+                internal ItemMateria()
+                {
+                }
+
+                /// <summary>
+                /// Gets the materia index.
+                /// </summary>
+                public int Index { get; internal set; }
+
+                /// <summary>
+                /// Gets the materia ID.
+                /// </summary>
+                public int MateriaId { get; internal set; }
             }
         }
     }

Dalamud/Game/Network/Structures/MarketBoardHistory.cs

@@ -5,13 +5,38 @@ using System.Text;
 
 namespace Dalamud.Game.Network.Structures
 {
+    /// <summary>
+    /// This class represents the market board history from a game network packet.
+    /// </summary>
     public class MarketBoardHistory
     {
-        public uint CatalogId;
-        public uint CatalogId2;
+        /// <summary>
+        /// Initializes a new instance of the <see cref="MarketBoardHistory"/> class.
+        /// </summary>
+        internal MarketBoardHistory()
+        {
+        }
 
-        public List<MarketBoardHistoryListing> HistoryListings;
+        /// <summary>
+        /// Gets the catalog ID.
+        /// </summary>
+        public uint CatalogId { get; internal set; }
 
+        /// <summary>
+        /// Gets the second catalog ID.
+        /// </summary>
+        public uint CatalogId2 { get; internal set; }
+
+        /// <summary>
+        /// Gets the list of individual item history listings.
+        /// </summary>
+        public List<MarketBoardHistoryListing> HistoryListings { get; internal set; }
+
+        /// <summary>
+        /// Read a <see cref="MarketBoardHistory"/> object from memory.
+        /// </summary>
+        /// <param name="dataPtr">Address to read.</param>
+        /// <returns>A new <see cref="MarketBoardHistory"/> object.</returns>
         public static unsafe MarketBoardHistory Read(IntPtr dataPtr)
         {
             var output = new MarketBoardHistory();
@@ -47,16 +72,52 @@ namespace Dalamud.Game.Network.Structures
             return output;
         }
 
+        /// <summary>
+        /// This class represents the market board history of a single item from the <see cref="MarketBoardHistory"/> network packet.
+        /// </summary>
         public class MarketBoardHistoryListing
         {
-            public string BuyerName;
+            /// <summary>
+            /// Initializes a new instance of the <see cref="MarketBoardHistoryListing"/> class.
+            /// </summary>
+            internal MarketBoardHistoryListing()
+            {
+            }
 
-            public uint CatalogId;
-            public bool IsHq;
-            public bool OnMannequin;
-            public DateTime PurchaseTime;
-            public uint Quantity;
-            public uint SalePrice;
+            /// <summary>
+            /// Gets the buyer's name.
+            /// </summary>
+            public string BuyerName { get; internal set; }
+
+            /// <summary>
+            /// Gets the catalog ID.
+            /// </summary>
+            public uint CatalogId { get; internal set; }
+
+            /// <summary>
+            /// Gets a value indicating whether the item is HQ.
+            /// </summary>
+            public bool IsHq { get; internal set; }
+
+            /// <summary>
+            /// Gets a value indicating whether the item is on a mannequin.
+            /// </summary>
+            public bool OnMannequin { get; internal set; }
+
+            /// <summary>
+            /// Gets the time of purchase.
+            /// </summary>
+            public DateTime PurchaseTime { get; internal set; }
+
+            /// <summary>
+            /// Gets the quantity.
+            /// </summary>
+            public uint Quantity { get; internal set; }
+
+            /// <summary>
+            /// Gets the sale price.
+            /// </summary>
+            public uint SalePrice { get; internal set; }
         }
     }
 }

Dalamud/Game/Network/Structures/MarketTaxRates.cs

@@ -3,15 +3,53 @@ using System.IO;
 
 namespace Dalamud.Game.Network.Structures
 {
+    /// <summary>
+    /// This class represents the market tax rates from a game network packet.
+    /// </summary>
     public class MarketTaxRates
     {
-        public uint LimsaLominsaTax;
-        public uint GridaniaTax;
-        public uint UldahTax;
-        public uint IshgardTax;
-        public uint KuganeTax;
-        public uint CrystariumTax;
+        /// <summary>
+        /// Initializes a new instance of the <see cref="MarketTaxRates"/> class.
+        /// </summary>
+        internal MarketTaxRates()
+        {
+        }
 
+        /// <summary>
+        /// Gets the tax rate in Limsa Lominsa.
+        /// </summary>
+        public uint LimsaLominsaTax { get; internal set; }
+
+        /// <summary>
+        /// Gets the tax rate in Gridania.
+        /// </summary>
+        public uint GridaniaTax { get; internal set; }
+
+        /// <summary>
+        /// Gets the tax rate in Ul'dah.
+        /// </summary>
+        public uint UldahTax { get; internal set; }
+
+        /// <summary>
+        /// Gets the tax rate in Ishgard.
+        /// </summary>
+        public uint IshgardTax { get; internal set; }
+
+        /// <summary>
+        /// Gets the tax rate in Kugane.
+        /// </summary>
+        public uint KuganeTax { get; internal set; }
+
+        /// <summary>
+        /// Gets the tax rate in the Crystarium.
+        /// </summary>
+        public uint CrystariumTax { get; internal set; }
+
+        /// <summary>
+        /// Read a <see cref="MarketTaxRates"/> object from memory.
+        /// </summary>
+        /// <param name="dataPtr">Address to read.</param>
+        /// <returns>A new <see cref="MarketTaxRates"/> object.</returns>
         public static unsafe MarketTaxRates Read(IntPtr dataPtr)
         {
             var output = new MarketTaxRates();