From d41682b66e0da3eea80d40722a201a3fc2649303 Mon Sep 17 00:00:00 2001 From: goat Date: Sun, 7 Jul 2024 12:42:46 +0200 Subject: [PATCH] fix warnings --- .../JobGauge/Enums/CreatureFlags.cs | 10 +++++----- .../ClientState/JobGauge/Types/PCTGauge.cs | 18 +++++++++--------- .../ClientState/JobGauge/Types/VPRGauge.cs | 8 ++++---- Dalamud/Game/Gui/GameGui.cs | 1 + Dalamud/Game/Gui/GameGuiAddressResolver.cs | 1 + .../Internal/PartyFinderPacketListing.cs | 14 +++++++------- .../MarketBoardItemRequest.cs | 2 +- 7 files changed, 28 insertions(+), 26 deletions(-) diff --git a/Dalamud/Game/ClientState/JobGauge/Enums/CreatureFlags.cs b/Dalamud/Game/ClientState/JobGauge/Enums/CreatureFlags.cs index 72b880ad8..3a22c8590 100644 --- a/Dalamud/Game/ClientState/JobGauge/Enums/CreatureFlags.cs +++ b/Dalamud/Game/ClientState/JobGauge/Enums/CreatureFlags.cs @@ -6,27 +6,27 @@ public enum CreatureFlags : byte { /// - /// Pom flag present + /// Pom flag present. /// Pom = 1, /// - /// Wings flag present + /// Wings flag present. /// Wings = 2, /// - /// Claw flag present + /// Claw flag present. /// Claw = 4, /// - /// Moogle portrait present + /// Moogle portrait present. /// MooglePortait = 16, /// - /// Madeen portrait present + /// Madeen portrait present. /// MadeenPortrait = 32, } diff --git a/Dalamud/Game/ClientState/JobGauge/Types/PCTGauge.cs b/Dalamud/Game/ClientState/JobGauge/Types/PCTGauge.cs index d7cdc3229..db9d51dc4 100644 --- a/Dalamud/Game/ClientState/JobGauge/Types/PCTGauge.cs +++ b/Dalamud/Game/ClientState/JobGauge/Types/PCTGauge.cs @@ -20,47 +20,47 @@ public unsafe class PCTGauge : JobGaugeBase } /// - /// Tracks use of subjective pallete + /// Gets the use of subjective pallete. /// public byte PalleteGauge => Struct->PalleteGauge; /// - /// Number of paint the player has. + /// Gets the amount of paint the player has. /// public byte Paint => Struct->Paint; /// - /// Creature Motif Stack + /// Gets a value indicating whether or not a creature motif is drawn. /// public bool CreatureMotifDrawn => Struct->CreatureMotifDrawn; /// - /// Weapon Motif Stack + /// Gets a value indicating whether or not a weapon motif is drawn. /// public bool WeaponMotifDrawn => Struct->WeaponMotifDrawn; /// - /// Landscape Motif Stack + /// Gets a value indicating whether or not a landscape motif is drawn. /// public bool LandscapeMotifDrawn => Struct->LandscapeMotifDrawn; /// - /// Moogle Portrait Stack + /// Gets a value indicating whether or not a moogle portrait is ready. /// public bool MooglePortraitReady => Struct->MooglePortraitReady; /// - /// Madeen Portrait Stack + /// Gets a value indicating whether or not a madeen portrait is ready. /// public bool MadeenPortraitReady => Struct->MadeenPortraitReady; /// - /// Which creature flags are present. + /// Gets which creature flags are present. /// public CreatureFlags CreatureFlags => (CreatureFlags)Struct->CreatureFlags; /// - /// Which canvas flags are present. + /// Gets which canvas flags are present. /// public CanvasFlags CanvasFlags => (CanvasFlags)Struct->CanvasFlags; } diff --git a/Dalamud/Game/ClientState/JobGauge/Types/VPRGauge.cs b/Dalamud/Game/ClientState/JobGauge/Types/VPRGauge.cs index 079f8b93b..a889c3482 100644 --- a/Dalamud/Game/ClientState/JobGauge/Types/VPRGauge.cs +++ b/Dalamud/Game/ClientState/JobGauge/Types/VPRGauge.cs @@ -21,22 +21,22 @@ public unsafe class VPRGauge : JobGaugeBase } /// - /// How many uses of uncoiled fury the player has. + /// Gets how many uses of uncoiled fury the player has. /// public byte RattlingCoilStacks => Struct->RattlingCoilStacks; /// - /// Tracks AnguineTribute stacks and gauge. + /// Gets Serpent Offering stacks and gauge. /// public byte SerpentOffering => Struct->SerpentOffering; /// - /// Allows the use of 1st, 2nd, 3rd, 4th generation and Ouroboros. + /// Gets value indicating the use of 1st, 2nd, 3rd, 4th generation and Ouroboros. /// public byte AnguineTribute => Struct->AnguineTribute; /// - /// Keeps track of last Weaponskill used in DreadWinder/Pit of Dread combo. + /// Gets the last Weaponskill used in DreadWinder/Pit of Dread combo. /// public DreadCombo DreadCombo => (DreadCombo)Struct->DreadCombo; } diff --git a/Dalamud/Game/Gui/GameGui.cs b/Dalamud/Game/Gui/GameGui.cs index a79a840dd..e92473539 100644 --- a/Dalamud/Game/Gui/GameGui.cs +++ b/Dalamud/Game/Gui/GameGui.cs @@ -223,6 +223,7 @@ internal sealed unsafe class GameGui : IInternalDisposableService, IGameGui worldPos = Vector3.Zero; return false; } + var ray = camera->ScreenPointToRay(screenPos); var result = BGCollisionModule.RaycastMaterialFilter(ray.Origin, ray.Direction, out var hit); worldPos = hit.Point; diff --git a/Dalamud/Game/Gui/GameGuiAddressResolver.cs b/Dalamud/Game/Gui/GameGuiAddressResolver.cs index e0ffe41dd..5b02a2d09 100644 --- a/Dalamud/Game/Gui/GameGuiAddressResolver.cs +++ b/Dalamud/Game/Gui/GameGuiAddressResolver.cs @@ -39,6 +39,7 @@ internal sealed class GameGuiAddressResolver : BaseAddressResolver /// Gets the address of the native HandleImm method. /// public IntPtr HandleImm { get; private set; } + /// /// Gets the address of the native ToggleUiHide method. /// diff --git a/Dalamud/Game/Gui/PartyFinder/Internal/PartyFinderPacketListing.cs b/Dalamud/Game/Gui/PartyFinder/Internal/PartyFinderPacketListing.cs index 9c39e4f97..847fb781d 100644 --- a/Dalamud/Game/Gui/PartyFinder/Internal/PartyFinderPacketListing.cs +++ b/Dalamud/Game/Gui/PartyFinder/Internal/PartyFinderPacketListing.cs @@ -64,13 +64,7 @@ internal unsafe struct PartyFinderPacketListing private fixed byte description[192]; private fixed byte padding14[4]; - - internal bool IsNull() - { - // a valid party finder must have at least one slot set - return this.Slots.All(slot => slot == 0); - } - + #region Helper internal ulong[] Slots @@ -118,4 +112,10 @@ internal unsafe struct PartyFinderPacketListing } #endregion + + internal bool IsNull() + { + // a valid party finder must have at least one slot set + return this.Slots.All(slot => slot == 0); + } } diff --git a/Dalamud/Game/Network/Internal/MarketBoardUploaders/MarketBoardItemRequest.cs b/Dalamud/Game/Network/Internal/MarketBoardUploaders/MarketBoardItemRequest.cs index aa112753f..7af647867 100644 --- a/Dalamud/Game/Network/Internal/MarketBoardUploaders/MarketBoardItemRequest.cs +++ b/Dalamud/Game/Network/Internal/MarketBoardUploaders/MarketBoardItemRequest.cs @@ -16,7 +16,7 @@ internal class MarketBoardItemRequest /// /// Gets the request status. Nonzero statuses are errors. - /// Known values: default=0; rate limited=0x70000003 + /// Known values: default=0; rate limited=0x70000003. /// public uint Status { get; private set; }