ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-15 21:24:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Revert "feat(PluginInstaller): implement AcceptsFeedback, FeedbackMessage"

Browse source 
This reverts commit 785df95071.
This commit is contained in:
goat 2021-11-18 15:18:14 +01:00
parent 0ef97c3b7c
commit dde9c7eb85
No known key found for this signature in database
GPG key ID: 7773BB5B43BA52E5
2 changed files with 2 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Dalamud/Interface/Internal/Windows/PluginInstallerWindow.cs
View file

@ -387,11 +387,6 @@ internal class PluginInstallerWindow : Window, IDisposable
{ {
ImGui.Text(Locs.FeedbackModal_Text(this.feedbackPlugin.Name)); ImGui.Text(Locs.FeedbackModal_Text(this.feedbackPlugin.Name));
if (this.feedbackPlugin?.FeedbackMessage != null)
{
ImGui.TextWrapped(this.feedbackPlugin.FeedbackMessage);
}
if (this.pluginListUpdatable.Any( if (this.pluginListUpdatable.Any(
up => up.InstalledPlugin.Manifest.InternalName == this.feedbackPlugin?.InternalName)) up => up.InstalledPlugin.Manifest.InternalName == this.feedbackPlugin?.InternalName))
{ {
@ -1231,7 +1226,7 @@ internal class PluginInstallerWindow : Window, IDisposable
this.DrawVisitRepoUrlButton(manifest.RepoUrl); this.DrawVisitRepoUrlButton(manifest.RepoUrl);
if (!manifest.SourceRepo.IsThirdParty && manifest.AcceptsFeedback) if (!manifest.SourceRepo.IsThirdParty)
{ {
this.DrawSendFeedbackButton(manifest); this.DrawSendFeedbackButton(manifest);
} }
@ -1406,7 +1401,7 @@ internal class PluginInstallerWindow : Window, IDisposable
ImGui.TextColored(ImGuiColors.DalamudGrey3, downloadText); ImGui.TextColored(ImGuiColors.DalamudGrey3, downloadText);
var isThirdParty = manifest.IsThirdParty; var isThirdParty = manifest.IsThirdParty;
var canFeedback = !isThirdParty && !plugin.IsDev && plugin.Manifest.DalamudApiLevel == PluginManager.DalamudApiLevel && plugin.Manifest.AcceptsFeedback; var canFeedback = !isThirdParty && !plugin.IsDev && plugin.Manifest.DalamudApiLevel == PluginManager.DalamudApiLevel;
// Installed from // Installed from
if (plugin.IsDev) if (plugin.IsDev)

15
Dalamud/Plugin/Internal/Types/PluginManifest.cs
View file

@ -161,19 +161,4 @@ internal record PluginManifest
/// Gets an URL for the plugin's icon. /// Gets an URL for the plugin's icon.
/// </summary> /// </summary>
public string? IconUrl { get; init; } public string? IconUrl { get; init; }
/// <summary>
/// Gets a value that indicates whether or not this plugin accepts feedback.
/// </summary>
public bool AcceptsFeedback { get; init; } = true;
/// <summary>
/// Gets a message that is shown to users when sending feedback.
/// </summary>
public string? FeedbackMessage { get; init; }
/// <summary>
/// Gets a value indicating the webhook URL feedback is sent to.
/// </summary>
public string? FeedbackWebhook { get; init; }
} }