feat: attempt to prevent some plugin disposal crashes by stopping Framework::Update event dispatching before unloading

Dalamud/Dalamud.cs

@@ -358,6 +358,10 @@ namespace Dalamud
         {
             try
             {
+                // this must be done before unloading plugins, to prevent crashes due to errors
+                // in plugin cleanup
+                this.Framework.DispatchUpdateEvents = false;
+
                 // this must be done before unloading plugins, or it can cause a race condition
                 // due to rendering happening on another thread, where a plugin might receive
                 // a render call after it has been disposed, which can crash if it attempts to

Dalamud/Game/Internal/Framework.cs

@@ -17,6 +17,8 @@ namespace Dalamud.Game.Internal {
     public sealed class Framework : IDisposable {
         private readonly Dalamud dalamud;
 
+        internal bool DispatchUpdateEvents { get; set; } = true;
+
         [UnmanagedFunctionPointer(CallingConvention.ThisCall)]
         private delegate bool OnUpdateDetour(IntPtr framework);
 
@@ -40,7 +42,7 @@ namespace Dalamud.Game.Internal {
         /// </summary>
         public FrameworkAddressResolver Address { get; }
 
-#region Stats
+        #region Stats
         public static bool StatsEnabled { get; set; }
         public static Dictionary<string, List<double>> StatsHistory = new Dictionary<string, List<double>>();
         private static Stopwatch statsStopwatch = new Stopwatch();
@@ -126,6 +128,8 @@ namespace Dalamud.Game.Internal {
                 Log.Error(ex, "Exception while handling Framework::Update hook.");
             }
 
+            if (this.DispatchUpdateEvents)
+            {
                 try {
                     if (StatsEnabled && OnUpdateEvent != null) {
                         // Stat Tracking for Framework Updates
@@ -159,6 +163,7 @@ namespace Dalamud.Game.Internal {
                 } catch (Exception ex) {
                     Log.Error(ex, "Exception while dispatching Framework::Update event.");
                 }
+            }
 
             return this.updateHook.Original(framework);
         }
@@ -166,6 +171,8 @@ namespace Dalamud.Game.Internal {
         private IntPtr HandleFrameworkDestroy() {
             Log.Information("Framework::OnDestroy!");
 
+            this.DispatchUpdateEvents = false;
+
             // Store the pointer to the original trampoline location
             var originalPtr = Marshal.GetFunctionPointerForDelegate(this.destroyHook.Original);