ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-12 10:17:22 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix CA2263: Prefer generic overload when type is known

Browse source
This commit is contained in:
Haselnussbomber 2025-10-24 02:52:13 +02:00
parent a8b8bce628
commit e34c480290
No known key found for this signature in database
GPG key ID: BB905BB49E7295D1
7 changed files with 9 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Dalamud/Game/Gui/PartyFinder/Types/PartyFinderSlot.cs
View file

@ -23,23 +23,7 @@ public class PartyFinderSlot
/// <summary>
/// Gets a list of jobs that this slot is accepting.
/// </summary>
public IReadOnlyCollection<JobFlags> Accepting
{
get
{
if (this.listAccepting != null)
{
return this.listAccepting;
}
this.listAccepting = Enum.GetValues(typeof(JobFlags))
.Cast<JobFlags>()
.Where(flag => this[flag])
.ToArray();
return this.listAccepting;
}
}
public IReadOnlyCollection<JobFlags> Accepting => this.listAccepting ??= Enum.GetValues<JobFlags>().Where(flag => this[flag]).ToArray();
/// <summary>
/// Tests if this slot is accepting a job.

9
Dalamud/Interface/FontAwesome/FontAwesomeHelpers.cs
View file

@ -16,14 +16,7 @@ public static class FontAwesomeHelpers
/// <returns>list of font awesome icons.</returns>
public static List<FontAwesomeIcon> GetIcons()
{
var icons = new List<FontAwesomeIcon>();
foreach (var icon in Enum.GetValues(typeof(FontAwesomeIcon)).Cast<FontAwesomeIcon>().ToList())
{
if (icon.IsObsolete()) continue;
icons.Add(icon);
}
return icons;
return [.. Enum.GetValues<FontAwesomeIcon>().Where(icon => !icon.IsObsolete())];
}
/// <summary>

2
Dalamud/Interface/Internal/DalamudInterface.cs
View file

@ -683,7 +683,7 @@ internal class DalamudInterface : IInternalDisposableService
if (ImGui.BeginMenu("Set log level..."u8))
{
foreach (var logLevel in Enum.GetValues(typeof(LogEventLevel)).Cast<LogEventLevel>())
foreach (var logLevel in Enum.GetValues<LogEventLevel>())
{
if (ImGui.MenuItem(logLevel + "##logLevelSwitch", (byte*)null, EntryPoint.LogLevelSwitch.MinimumLevel == logLevel))
{

4
Dalamud/Interface/Internal/UiDebug2/Browsing/AddonTree.FieldNames.cs
View file

@ -41,7 +41,7 @@ public unsafe partial class AddonTree
{
foreach (var t in from t in ClientStructsAssembly.GetTypes()
where t.IsPublic
let xivAddonAttr = (AddonAttribute?)t.GetCustomAttribute(typeof(AddonAttribute), false)
let xivAddonAttr = t.GetCustomAttribute<AddonAttribute>(false)
where xivAddonAttr != null
where xivAddonAttr.AddonIdentifiers.Contains(this.AddonName)
select t)
@ -83,7 +83,7 @@ public unsafe partial class AddonTree
foreach (var field in baseType.GetFields(Static | Public | NonPublic | Instance))
{
if (field.GetCustomAttribute(typeof(FieldOffsetAttribute)) is FieldOffsetAttribute offset)
if (field.GetCustomAttribute<FieldOffsetAttribute>() is FieldOffsetAttribute offset)
{
try
{

2
Dalamud/Interface/Internal/Windows/PluginInstaller/ProfileManagerWidget.cs
View file

@ -403,7 +403,7 @@ internal class ProfileManagerWidget
ImGui.Text(Locs.StartupBehavior);
if (ImGui.BeginCombo("##startupBehaviorPicker"u8, Locs.PolicyToLocalisedName(profile.StartupPolicy)))
{
foreach (var policy in Enum.GetValues(typeof(ProfileModelV1.ProfileStartupPolicy)).Cast<ProfileModelV1.ProfileStartupPolicy>())
foreach (var policy in Enum.GetValues<ProfileModelV1.ProfileStartupPolicy>())
{
var name = Locs.PolicyToLocalisedName(policy);
if (ImGui.Selectable(name, profile.StartupPolicy == policy))

2
Dalamud/SafeMemory.cs
View file

@ -292,7 +292,7 @@ public static class SafeMemory
return bytes;
}
public T Read<T>(int offset = 0) => (T)Marshal.PtrToStructure(this.hGlobal + offset, typeof(T));
public T Read<T>(int offset = 0) => Marshal.PtrToStructure<T>(this.hGlobal + offset);
public object? Read(Type type, int offset = 0) => Marshal.PtrToStructure(this.hGlobal + offset, type);

4
Dalamud/Utility/Util.cs
View file

@ -1116,8 +1116,8 @@ public static partial class Util
foreach (var f in obj.GetType()
.GetFields(BindingFlags.Static | BindingFlags.Public | BindingFlags.Instance))
{
var fixedBuffer = (FixedBufferAttribute)f.GetCustomAttribute(typeof(FixedBufferAttribute));
var offset = (FieldOffsetAttribute)f.GetCustomAttribute(typeof(FieldOffsetAttribute));
var fixedBuffer = f.GetCustomAttribute<FixedBufferAttribute>();
var offset = f.GetCustomAttribute<FieldOffsetAttribute>();
if (fixedBuffer != null)
{