Fix CA2263: Prefer generic overload when type is known

Dalamud/Game/Gui/PartyFinder/Types/PartyFinderSlot.cs

@@ -23,23 +23,7 @@ public class PartyFinderSlot
     /// <summary>
     /// Gets a list of jobs that this slot is accepting.
     /// </summary>
-    public IReadOnlyCollection<JobFlags> Accepting
+    public IReadOnlyCollection<JobFlags> Accepting => this.listAccepting ??= Enum.GetValues<JobFlags>().Where(flag => this[flag]).ToArray();
-    {
-        get
-        {
-            if (this.listAccepting != null)
-            {
-                return this.listAccepting;
-            }
-
-            this.listAccepting = Enum.GetValues(typeof(JobFlags))
-                                     .Cast<JobFlags>()
-                                     .Where(flag => this[flag])
-                                     .ToArray();
-
-            return this.listAccepting;
-        }
-    }
 
     /// <summary>
     /// Tests if this slot is accepting a job.

Dalamud/Interface/FontAwesome/FontAwesomeHelpers.cs

@@ -16,14 +16,7 @@ public static class FontAwesomeHelpers
     /// <returns>list of font awesome icons.</returns>
     public static List<FontAwesomeIcon> GetIcons()
     {
-        var icons = new List<FontAwesomeIcon>();
+        return [.. Enum.GetValues<FontAwesomeIcon>().Where(icon => !icon.IsObsolete())];
-        foreach (var icon in Enum.GetValues(typeof(FontAwesomeIcon)).Cast<FontAwesomeIcon>().ToList())
-        {
-            if (icon.IsObsolete()) continue;
-            icons.Add(icon);
-        }
-
-        return icons;
     }
 
     /// <summary>

Dalamud/Interface/Internal/DalamudInterface.cs

@@ -683,7 +683,7 @@ internal class DalamudInterface : IInternalDisposableService
 
                     if (ImGui.BeginMenu("Set log level..."u8))
                     {
-                        foreach (var logLevel in Enum.GetValues(typeof(LogEventLevel)).Cast<LogEventLevel>())
+                        foreach (var logLevel in Enum.GetValues<LogEventLevel>())
                         {
                             if (ImGui.MenuItem(logLevel + "##logLevelSwitch", (byte*)null, EntryPoint.LogLevelSwitch.MinimumLevel == logLevel))
                             {

Dalamud/Interface/Internal/UiDebug2/Browsing/AddonTree.FieldNames.cs

@@ -41,7 +41,7 @@ public unsafe partial class AddonTree
             {
                 foreach (var t in from t in ClientStructsAssembly.GetTypes()
                                   where t.IsPublic
-                                  let xivAddonAttr = (AddonAttribute?)t.GetCustomAttribute(typeof(AddonAttribute), false)
+                                  let xivAddonAttr = t.GetCustomAttribute<AddonAttribute>(false)
                                   where xivAddonAttr != null
                                   where xivAddonAttr.AddonIdentifiers.Contains(this.AddonName)
                                   select t)
@@ -83,7 +83,7 @@ public unsafe partial class AddonTree
 
         foreach (var field in baseType.GetFields(Static | Public | NonPublic | Instance))
         {
-            if (field.GetCustomAttribute(typeof(FieldOffsetAttribute)) is FieldOffsetAttribute offset)
+            if (field.GetCustomAttribute<FieldOffsetAttribute>() is FieldOffsetAttribute offset)
             {
                 try
                 {

Dalamud/Interface/Internal/Windows/PluginInstaller/ProfileManagerWidget.cs

@@ -403,7 +403,7 @@ internal class ProfileManagerWidget
         ImGui.Text(Locs.StartupBehavior);
         if (ImGui.BeginCombo("##startupBehaviorPicker"u8, Locs.PolicyToLocalisedName(profile.StartupPolicy)))
         {
-            foreach (var policy in Enum.GetValues(typeof(ProfileModelV1.ProfileStartupPolicy)).Cast<ProfileModelV1.ProfileStartupPolicy>())
+            foreach (var policy in Enum.GetValues<ProfileModelV1.ProfileStartupPolicy>())
             {
                 var name = Locs.PolicyToLocalisedName(policy);
                 if (ImGui.Selectable(name, profile.StartupPolicy == policy))

Dalamud/SafeMemory.cs

@@ -292,7 +292,7 @@ public static class SafeMemory
             return bytes;
         }
 
-        public T Read<T>(int offset = 0) => (T)Marshal.PtrToStructure(this.hGlobal + offset, typeof(T));
+        public T Read<T>(int offset = 0) => Marshal.PtrToStructure<T>(this.hGlobal + offset);
 
         public object? Read(Type type, int offset = 0) => Marshal.PtrToStructure(this.hGlobal + offset, type);
 

Dalamud/Utility/Util.cs

@@ -1116,8 +1116,8 @@ public static partial class Util
                 foreach (var f in obj.GetType()
                                      .GetFields(BindingFlags.Static | BindingFlags.Public | BindingFlags.Instance))
                 {
-                    var fixedBuffer = (FixedBufferAttribute)f.GetCustomAttribute(typeof(FixedBufferAttribute));
+                    var fixedBuffer = f.GetCustomAttribute<FixedBufferAttribute>();
-                    var offset = (FieldOffsetAttribute)f.GetCustomAttribute(typeof(FieldOffsetAttribute));
+                    var offset = f.GetCustomAttribute<FieldOffsetAttribute>();
 
                     if (fixedBuffer != null)
                     {