diff --git a/Dalamud/Configuration/Internal/DalamudConfiguration.cs b/Dalamud/Configuration/Internal/DalamudConfiguration.cs
index b2a11d774..2ee31c4f7 100644
--- a/Dalamud/Configuration/Internal/DalamudConfiguration.cs
+++ b/Dalamud/Configuration/Internal/DalamudConfiguration.cs
@@ -141,7 +141,12 @@ namespace Dalamud.Configuration.Internal
/// * ...TTF fonts loaded with stb or FreeType are in linear space.
/// * ...the game's prebaked AXIS fonts are in gamma space with gamma value of 1.4.
///
- public float FontGamma { get; set; } = 1.0f;
+ public float FontGamma { get; set; } = 1.4f;
+
+ ///
+ /// Gets or sets a value indicating whether to allow big font atlas.
+ ///
+ public bool AllowBigFontAtlas { get; set; } = false;
///
/// Gets or sets a value indicating whether or not plugin UI should be hidden.
diff --git a/Dalamud/Interface/GameFonts/GameFontManager.cs b/Dalamud/Interface/GameFonts/GameFontManager.cs
index 83178acc9..adbe6dfa4 100644
--- a/Dalamud/Interface/GameFonts/GameFontManager.cs
+++ b/Dalamud/Interface/GameFonts/GameFontManager.cs
@@ -141,9 +141,9 @@ namespace Dalamud.Interface.GameFonts
target.Value!.ConfigData,
(ushort)glyph->Codepoint,
glyph->X0 * scale,
- glyph->Y0 * scale,
+ ((glyph->Y0 - source.Value!.Ascent) * scale) + target.Value!.Ascent,
glyph->X1 * scale,
- glyph->Y1 * scale,
+ ((glyph->Y1 - source.Value!.Ascent) * scale) + target.Value!.Ascent,
glyph->U0,
glyph->V0,
glyph->U1,
@@ -153,9 +153,9 @@ namespace Dalamud.Interface.GameFonts
else if (!missingOnly)
{
prevGlyphPtr->X0 = glyph->X0 * scale;
- prevGlyphPtr->Y0 = glyph->Y0 * scale;
+ prevGlyphPtr->Y0 = ((glyph->Y0 - source.Value!.Ascent) * scale) + target.Value!.Ascent;
prevGlyphPtr->X1 = glyph->X1 * scale;
- prevGlyphPtr->Y1 = glyph->Y1 * scale;
+ prevGlyphPtr->Y1 = ((glyph->Y1 - source.Value!.Ascent) * scale) + target.Value!.Ascent;
prevGlyphPtr->U0 = glyph->U0;
prevGlyphPtr->V0 = glyph->V0;
prevGlyphPtr->U1 = glyph->U1;
@@ -343,7 +343,7 @@ namespace Dalamud.Interface.GameFonts
{
var fdt = this.fdts[(int)style.FamilyAndSize];
var fontPtr = font.NativePtr;
- fontPtr->ConfigData->SizePixels = fontPtr->FontSize = fdt.FontHeader.LineHeight;
+ fontPtr->ConfigData->SizePixels = fontPtr->FontSize = fdt.FontHeader.Size * 4 / 3;
fontPtr->Ascent = fdt.FontHeader.Ascent;
fontPtr->Descent = fdt.FontHeader.Descent;
fontPtr->EllipsisChar = '…';
@@ -444,6 +444,9 @@ namespace Dalamud.Interface.GameFonts
{
lock (this.syncRoot)
{
+ if (!this.fontUseCounter.ContainsKey(style))
+ return;
+
if ((this.fontUseCounter[style] -= 1) == 0)
this.fontUseCounter.Remove(style);
}
diff --git a/Dalamud/Interface/Internal/InterfaceManager.cs b/Dalamud/Interface/Internal/InterfaceManager.cs
index 8872fc45f..50304e89c 100644
--- a/Dalamud/Interface/Internal/InterfaceManager.cs
+++ b/Dalamud/Interface/Internal/InterfaceManager.cs
@@ -55,6 +55,7 @@ namespace Dalamud.Interface.Internal
private readonly string rtssPath;
private readonly HashSet glyphRequests = new();
+ private readonly List axisFontHandles = new();
private readonly Hook presentHook;
private readonly Hook resizeBuffersHook;
@@ -64,9 +65,6 @@ namespace Dalamud.Interface.Internal
private readonly SwapChainVtableResolver address;
private RawDX11Scene? scene;
- private GameFontHandle[] axisFontHandles;
- private bool overwriteAllNotoGlyphsWithAxis;
-
// can't access imgui IO before first present call
private bool lastWantCapture = false;
private bool isRebuildingFonts = false;
@@ -197,6 +195,16 @@ namespace Dalamud.Interface.Internal
///
public bool IsReady => this.scene != null;
+ ///
+ /// Gets or sets a value indicating whether to override configuration for UseAxis.
+ ///
+ public bool? UseAxisOverride { get; set; } = null;
+
+ ///
+ /// Gets a value indicating whether to use AXIS fonts.
+ ///
+ public bool UseAxis => this.UseAxisOverride ?? Service.Get().UseAxisFontsFromGame;
+
///
/// Gets or sets the overrided font gamma value, instead of using the value from configuration.
///
@@ -207,6 +215,16 @@ namespace Dalamud.Interface.Internal
///
public float FontGamma => Math.Max(0.1f, this.FontGammaOverride.GetValueOrDefault(Service.Get().FontGamma));
+ ///
+ /// Gets or sets a value indicating whether to override configuration for AllowBigFontAtlas.
+ ///
+ public bool? AllowBigFontAtlasOverride { get; set; } = null;
+
+ ///
+ /// Gets a value indicating whether to allow big font atlas.
+ ///
+ public bool AllowBigFontAtlas => this.AllowBigFontAtlasOverride ?? Service.Get().AllowBigFontAtlas;
+
///
/// Enable this module.
///
@@ -330,8 +348,6 @@ namespace Dalamud.Interface.Internal
if (!this.isRebuildingFonts)
{
Log.Verbose("[FONT] RebuildFonts() trigger");
- this.SetAxisFonts();
-
this.isRebuildingFonts = true;
this.scene.OnNewRenderFrame += this.RebuildFontsInternal;
}
@@ -414,24 +430,6 @@ namespace Dalamud.Interface.Internal
Util.Fatal($"One or more files required by XIVLauncher were not found.\nPlease restart and report this error if it occurs again.\n\n{path}", "Error");
}
- private void SetAxisFonts()
- {
- var configuration = Service.Get();
- this.overwriteAllNotoGlyphsWithAxis = configuration.UseAxisFontsFromGame;
-
- if (this.axisFontHandles == null)
- {
- this.axisFontHandles = new GameFontHandle[]
- {
- Service.Get().NewFontRef(new(GameFontFamilyAndSize.Axis96)),
- Service.Get().NewFontRef(new(GameFontFamilyAndSize.Axis12)),
- Service.Get().NewFontRef(new(GameFontFamilyAndSize.Axis14)),
- Service.Get().NewFontRef(new(GameFontFamilyAndSize.Axis18)),
- Service.Get().NewFontRef(new(GameFontFamilyAndSize.Axis36)),
- };
- }
- }
-
/*
* NOTE(goat): When hooking ReShade DXGISwapChain::runtime_present, this is missing the syncInterval arg.
* Seems to work fine regardless, I guess, so whatever.
@@ -493,8 +491,6 @@ namespace Dalamud.Interface.Internal
this.scene.OnBuildUI += this.Display;
this.scene.OnNewInputFrame += this.OnNewInputFrame;
- this.SetAxisFonts();
-
this.SetupFonts();
StyleModel.TransferOldModels();
@@ -600,22 +596,40 @@ namespace Dalamud.Interface.Internal
private unsafe void SetupFonts()
{
+ var gameFontManager = Service.Get();
var dalamud = Service.Get();
var io = ImGui.GetIO();
var ioFonts = io.Fonts;
- var fontScale = io.FontGlobalScale;
+ var fontLoadScale = this.AllowBigFontAtlas ? io.FontGlobalScale : 1;
var fontGamma = this.FontGamma;
List fontsToUnscale = new();
+ List fontsToOverwriteFromAxis = new();
+ List fontsToReassignSizes = new();
this.fontBuildSignal.Reset();
ioFonts.Clear();
- ioFonts.TexDesiredWidth = 4096;
+ ioFonts.TexDesiredWidth = this.AllowBigFontAtlas ? 4096 : 2048;
+
+ Log.Verbose("[FONT] SetupFonts - 1");
+
+ foreach (var v in this.axisFontHandles)
+ {
+ if (v != null)
+ v.Dispose();
+ }
+
+ this.axisFontHandles.Clear();
+
+ Log.Verbose("[FONT] SetupFonts - 2");
ImFontConfigPtr fontConfig = null;
List garbageList = new();
try
{
+ var dummyRangeHandle = GCHandle.Alloc(new ushort[] { '0', '0', 0 }, GCHandleType.Pinned);
+ garbageList.Add(dummyRangeHandle);
+
fontConfig = ImGuiNative.ImFontConfig_ImFontConfig();
fontConfig.OversampleH = 1;
fontConfig.OversampleV = 1;
@@ -626,15 +640,31 @@ namespace Dalamud.Interface.Internal
ShowFontError(fontPathJp);
// Default font
+ Log.Verbose("[FONT] SetupFonts - Default font");
+ this.axisFontHandles.Add(gameFontManager.NewFontRef(this.AllowBigFontAtlas ? new(GameFontFamily.Axis, DefaultFontSizePt * fontLoadScale) : new(GameFontFamilyAndSize.Axis12)));
+ if (this.UseAxis)
+ {
+ fontConfig.GlyphRanges = dummyRangeHandle.AddrOfPinnedObject();
+ fontConfig.SizePixels = DefaultFontSizePx * fontLoadScale;
+ DefaultFont = ioFonts.AddFontDefault(fontConfig);
+ fontsToUnscale.Add(DefaultFont);
+ fontsToOverwriteFromAxis.Add(true);
+ fontsToReassignSizes.Add(null);
+ }
+ else
{
var japaneseRangeHandle = GCHandle.Alloc(GlyphRangesJapanese.GlyphRanges, GCHandleType.Pinned);
garbageList.Add(japaneseRangeHandle);
- DefaultFont = ioFonts.AddFontFromFileTTF(fontPathJp, (DefaultFontSizePx + 1) * fontScale, fontConfig, japaneseRangeHandle.AddrOfPinnedObject());
+ fontConfig.GlyphRanges = japaneseRangeHandle.AddrOfPinnedObject();
+ DefaultFont = ioFonts.AddFontFromFileTTF(fontPathJp, (DefaultFontSizePx + 1) * fontLoadScale, fontConfig);
fontsToUnscale.Add(DefaultFont);
+ fontsToOverwriteFromAxis.Add(false);
+ fontsToReassignSizes.Add(null);
}
// FontAwesome icon font
+ Log.Verbose("[FONT] SetupFonts - FontAwesome icon font");
{
var fontPathIcon = Path.Combine(dalamud.AssetDirectory.FullName, "UIRes", "FontAwesome5FreeSolid.otf");
if (!File.Exists(fontPathIcon))
@@ -643,20 +673,31 @@ namespace Dalamud.Interface.Internal
var iconRangeHandle = GCHandle.Alloc(new ushort[] { 0xE000, 0xF8FF, 0, }, GCHandleType.Pinned);
garbageList.Add(iconRangeHandle);
- IconFont = ioFonts.AddFontFromFileTTF(fontPathIcon, DefaultFontSizePx * fontScale, fontConfig, iconRangeHandle.AddrOfPinnedObject());
+ fontConfig.GlyphRanges = iconRangeHandle.AddrOfPinnedObject();
+ IconFont = ioFonts.AddFontFromFileTTF(fontPathIcon, DefaultFontSizePx * fontLoadScale, fontConfig);
fontsToUnscale.Add(IconFont);
+ this.axisFontHandles.Add(null);
+ fontsToOverwriteFromAxis.Add(false);
+ fontsToReassignSizes.Add(null);
}
// Monospace font
+ Log.Verbose("[FONT] SetupFonts - Monospace font");
{
var fontPathMono = Path.Combine(dalamud.AssetDirectory.FullName, "UIRes", "Inconsolata-Regular.ttf");
if (!File.Exists(fontPathMono))
ShowFontError(fontPathMono);
- MonoFont = ioFonts.AddFontFromFileTTF(fontPathMono, DefaultFontSizePx * fontScale, fontConfig);
+
+ fontConfig.GlyphRanges = IntPtr.Zero;
+ MonoFont = ioFonts.AddFontFromFileTTF(fontPathMono, DefaultFontSizePx * fontLoadScale, fontConfig);
fontsToUnscale.Add(MonoFont);
+ this.axisFontHandles.Add(null);
+ fontsToOverwriteFromAxis.Add(false);
+ fontsToReassignSizes.Add(null);
}
// Default font but in requested size for requested glyphs
+ Log.Verbose("[FONT] SetupFonts - Default font but in requested size for requested glyphs");
{
Dictionary> extraFontRequests = new();
foreach (var extraFontRequest in this.glyphRequests)
@@ -700,18 +741,30 @@ namespace Dalamud.Interface.Internal
flattenedRanges.Add(0);
- var rangeHandle = GCHandle.Alloc(flattenedRanges.ToArray(), GCHandleType.Pinned);
- garbageList.Add(rangeHandle);
+ ImFontPtr sizedFont;
+ this.axisFontHandles.Add(gameFontManager.NewFontRef(this.AllowBigFontAtlas ? new(GameFontFamily.Axis, fontSize * 3 / 4 * fontLoadScale) : new(GameFontFamilyAndSize.Axis12)));
+ if (this.UseAxis)
+ {
+ fontConfig.GlyphRanges = dummyRangeHandle.AddrOfPinnedObject();
+ fontConfig.SizePixels = (this.AllowBigFontAtlas ? fontSize : DefaultFontSizePx) * fontLoadScale;
+ sizedFont = ioFonts.AddFontDefault(fontConfig);
+ }
+ else
+ {
+ var rangeHandle = GCHandle.Alloc(flattenedRanges.ToArray(), GCHandleType.Pinned);
+ garbageList.Add(rangeHandle);
+ sizedFont = ioFonts.AddFontFromFileTTF(fontPathJp, (this.AllowBigFontAtlas ? fontSize : DefaultFontSizePx) * fontLoadScale, fontConfig, rangeHandle.AddrOfPinnedObject());
+ }
- var sizedFont = ioFonts.AddFontFromFileTTF(fontPathJp, fontSize * fontScale, fontConfig, rangeHandle.AddrOfPinnedObject());
fontsToUnscale.Add(sizedFont);
+ fontsToOverwriteFromAxis.Add(true);
+ fontsToReassignSizes.Add(this.AllowBigFontAtlas ? null : fontSize);
foreach (var request in requests)
request.FontInternal = sizedFont;
}
}
- var gameFontManager = Service.Get();
gameFontManager.BuildFonts();
Log.Verbose("[FONT] Invoke OnBuildFonts");
@@ -734,37 +787,53 @@ namespace Dalamud.Interface.Internal
}
foreach (var font in fontsToUnscale)
- GameFontManager.UnscaleFont(font, fontScale, false);
+ GameFontManager.UnscaleFont(font, fontLoadScale, false);
gameFontManager.AfterBuildFonts();
- foreach (var font in fontsToUnscale)
+ for (var i = 0; i < fontsToUnscale.Count; i++)
{
- // Leave IconFont alone.
- if (font.NativePtr == IconFont.NativePtr)
+ var font = fontsToUnscale[i];
+ var fontPtr = font.NativePtr;
+ var correspondingAxis = this.axisFontHandles[i];
+ var overwrite = fontsToOverwriteFromAxis[i];
+ var overwriteSize = fontsToReassignSizes[i];
+
+ if (correspondingAxis == null)
continue;
- // MonoFont will be filled later from DefaultFont.
- if (font.NativePtr == MonoFont.NativePtr)
- continue;
-
- var axisFont = this.axisFontHandles[^1];
- for (var i = this.axisFontHandles.Length - 2; i >= 0; i--)
+ if (overwrite)
{
- if (this.axisFontHandles[i].Style.Size >= (font.FontSize - 1) * fontScale * 3 / 4)
- axisFont = this.axisFontHandles[i];
- else
- break;
+ var srcPtr = correspondingAxis.ImFont.NativePtr;
+ var scale = fontPtr->ConfigData->SizePixels / srcPtr->ConfigData->SizePixels / fontLoadScale;
+ Log.Verbose("[FONT] Font {0}: scale {1}", i, scale);
+ fontPtr->FontSize = srcPtr->FontSize * scale;
+ fontPtr->Ascent = srcPtr->Ascent * scale;
+ fontPtr->Descent = srcPtr->Descent * scale;
+ fontPtr->FallbackChar = srcPtr->FallbackChar;
+ fontPtr->EllipsisChar = srcPtr->EllipsisChar;
}
- if (this.overwriteAllNotoGlyphsWithAxis)
- GameFontManager.CopyGlyphsAcrossFonts(axisFont.ImFont, font, false, false);
- else
- GameFontManager.CopyGlyphsAcrossFonts(axisFont.ImFont, font, false, false, 0xE020, 0xE0DB);
+ if (overwriteSize != null)
+ {
+ var scale = overwriteSize.Value / fontPtr->ConfigData->SizePixels;
+ fontPtr->FontSize *= scale;
+ fontPtr->Ascent *= scale;
+ fontPtr->Descent *= scale;
+ }
- // Fill missing glyphs in DefaultFont from Axis
- if (font.NativePtr == DefaultFont.NativePtr)
- GameFontManager.CopyGlyphsAcrossFonts(axisFont.ImFont, DefaultFont, true, false);
+ GameFontManager.CopyGlyphsAcrossFonts(correspondingAxis.ImFont, font, !overwrite, false);
+
+ if (!this.UseAxis && fontPtr == DefaultFont.NativePtr)
+ {
+ fontPtr->FontSize -= 1;
+ GameFontManager.CopyGlyphsAcrossFonts(correspondingAxis.ImFont, font, true, false, 0xE020, 0xE0DB);
+ fontPtr->FontSize += 1;
+ }
+ else
+ {
+ GameFontManager.CopyGlyphsAcrossFonts(correspondingAxis.ImFont, font, true, false, 0xE020, 0xE0DB);
+ }
}
// Fill missing glyphs in MonoFont from DefaultFont
diff --git a/Dalamud/Interface/Internal/Windows/SettingsWindow.cs b/Dalamud/Interface/Internal/Windows/SettingsWindow.cs
index 9ff94f42e..493725d92 100644
--- a/Dalamud/Interface/Internal/Windows/SettingsWindow.cs
+++ b/Dalamud/Interface/Internal/Windows/SettingsWindow.cs
@@ -39,6 +39,7 @@ namespace Dalamud.Interface.Internal.Windows
private float globalUiScale;
private bool doUseAxisFontsFromGame;
+ private bool doAllowBigFontAtlas;
private float fontGamma;
private bool doToggleUiHide;
private bool doToggleUiHideDuringCutscenes;
@@ -96,6 +97,7 @@ namespace Dalamud.Interface.Internal.Windows
this.globalUiScale = configuration.GlobalUiScale;
this.fontGamma = configuration.FontGamma;
this.doUseAxisFontsFromGame = configuration.UseAxisFontsFromGame;
+ this.doAllowBigFontAtlas = configuration.AllowBigFontAtlas;
this.doToggleUiHide = configuration.ToggleUiHide;
this.doToggleUiHideDuringCutscenes = configuration.ToggleUiHideDuringCutscenes;
this.doToggleUiHideDuringGpose = configuration.ToggleUiHideDuringGpose;
@@ -188,6 +190,8 @@ namespace Dalamud.Interface.Internal.Windows
ImGui.GetIO().FontGlobalScale = configuration.GlobalUiScale;
interfaceManager.FontGammaOverride = null;
+ interfaceManager.AllowBigFontAtlasOverride = null;
+ interfaceManager.UseAxisOverride = null;
this.thirdRepoList = configuration.ThirdRepoList.Select(x => x.Clone()).ToList();
this.devPluginLocations = configuration.DevPluginLoadLocations.Select(x => x.Clone()).ToList();
@@ -325,9 +329,22 @@ namespace Dalamud.Interface.Internal.Windows
ImGui.TextColored(ImGuiColors.DalamudGrey, Loc.Localize("DalamudSettingToggleUiHideOptOutNote", "Plugins may independently opt out of the settings below."));
- ImGui.Checkbox(Loc.Localize("DalamudSettingToggleAxisFonts", "Use AXIS fonts as default Dalamud font"), ref this.doUseAxisFontsFromGame);
+ if (ImGui.Checkbox(Loc.Localize("DalamudSettingToggleAxisFonts", "Use AXIS fonts as default Dalamud font"), ref this.doUseAxisFontsFromGame))
+ {
+ interfaceManager.UseAxisOverride = this.doUseAxisFontsFromGame;
+ interfaceManager.RebuildFonts();
+ }
+
ImGui.TextColored(ImGuiColors.DalamudGrey, Loc.Localize("DalamudSettingToggleUiAxisFontsHint", "Use AXIS fonts (the game's main UI fonts) as default Dalamud font."));
+ if (ImGui.Checkbox(Loc.Localize("DalamudSettingAllowBigFontAtlas", "Allow big font atlas"), ref this.doAllowBigFontAtlas))
+ {
+ interfaceManager.AllowBigFontAtlasOverride = this.doAllowBigFontAtlas;
+ interfaceManager.RebuildFonts();
+ }
+
+ ImGui.TextColored(ImGuiColors.DalamudGrey, string.Format(Loc.Localize("DalamudSettingAllowBigFontAtlas", "Displays text crisply, but may crash if your GPU does not support it.\nCurrent size: {0}px * {1}px"), ImGui.GetIO().Fonts.TexWidth, ImGui.GetIO().Fonts.TexHeight));
+
ImGui.Checkbox(Loc.Localize("DalamudSettingToggleUiHide", "Hide plugin UI when the game UI is toggled off"), ref this.doToggleUiHide);
ImGui.TextColored(ImGuiColors.DalamudGrey, Loc.Localize("DalamudSettingToggleUiHideHint", "Hide any open windows by plugins when toggling the game overlay."));
@@ -856,6 +873,7 @@ namespace Dalamud.Interface.Internal.Windows
configuration.Fools22 = this.doFools22;
configuration.UseAxisFontsFromGame = this.doUseAxisFontsFromGame;
+ configuration.AllowBigFontAtlas = this.doAllowBigFontAtlas;
configuration.FontGamma = this.fontGamma;
// This is applied every frame in InterfaceManager::CheckViewportState()