ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-12 18:27:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: use LastUpdated in remote manifest when sorting installed plugins

Browse source 
Will make sure installed plugins with pending updates will still be sorted as expected
This commit is contained in:
goat 2023-07-30 22:16:03 +02:00
parent b75b30c03d
commit f69fb6cc03
No known key found for this signature in database
GPG key ID: 49E2AA8C6A76498B
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Dalamud/Interface/Internal/Windows/PluginInstaller/PluginInstallerWindow.cs
View file

@ -2968,7 +2968,18 @@ internal class PluginInstallerWindow : Window, IDisposable
break;
case PluginSortKind.LastUpdate:
this.pluginListAvailable.Sort((p1, p2) => p2.LastUpdate.CompareTo(p1.LastUpdate));
this.pluginListInstalled.Sort((p1, p2) => p2.Manifest.LastUpdate.CompareTo(p1.Manifest.LastUpdate));
this.pluginListInstalled.Sort((p1, p2) =>
{
// We need to get remote manifests here, as the local manifests will have the time when the current version is installed,
// not the actual time of the last update, as the plugin may be pending an update
IPluginManifest? p2Considered = this.pluginListAvailable.FirstOrDefault(x => x.InternalName == p2.InternalName);
p2Considered ??= p2.Manifest;
IPluginManifest? p1Considered = this.pluginListAvailable.FirstOrDefault(x => x.InternalName == p1.InternalName);
p1Considered ??= p1.Manifest;
return p2Considered.LastUpdate.CompareTo(p1Considered.LastUpdate);
});
break;
case PluginSortKind.NewOrNot:
this.pluginListAvailable.Sort((p1, p2) => this.WasPluginSeen(p1.InternalName)