From f747b2f9c080e89dc5cd51c70b63730d3e1143dc Mon Sep 17 00:00:00 2001 From: goat Date: Fri, 13 Mar 2020 20:52:29 +0900 Subject: [PATCH] fix: don't instantiate plugins from duplicated AssemblyNames --- Dalamud/Plugin/PluginManager.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Dalamud/Plugin/PluginManager.cs b/Dalamud/Plugin/PluginManager.cs index 7e4182849..828f91c96 100644 --- a/Dalamud/Plugin/PluginManager.cs +++ b/Dalamud/Plugin/PluginManager.cs @@ -123,6 +123,11 @@ namespace Dalamud.Plugin return false; } + if (this.Plugins.Any(x => x.Plugin.GetType().Assembly.GetName().Name == type.Assembly.GetName().Name)) { + Log.Error("Duplicate plugin found: {0}", dllFile.FullName); + return false; + } + var plugin = (IDalamudPlugin)Activator.CreateInstance(type); // this happens for raw plugins that don't specify a PluginDefinition - just generate a dummy one to avoid crashes anywhere