From f8e51feb13563bcc7ca2aa412b470c5e88c3ac25 Mon Sep 17 00:00:00 2001 From: goat Date: Wed, 24 Aug 2022 23:07:12 +0200 Subject: [PATCH] chore: check if internalname is null for devplugin --- Dalamud/Plugin/Internal/PluginManager.cs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Dalamud/Plugin/Internal/PluginManager.cs b/Dalamud/Plugin/Internal/PluginManager.cs index b879d8756..f9c86587c 100644 --- a/Dalamud/Plugin/Internal/PluginManager.cs +++ b/Dalamud/Plugin/Internal/PluginManager.cs @@ -398,6 +398,13 @@ internal partial class PluginManager : IDisposable, IServiceType // Manifests are not required for devPlugins. the Plugin type will handle any null manifests. var manifestFile = LocalPluginManifest.GetManifestFile(dllFile); var manifest = manifestFile.Exists ? LocalPluginManifest.Load(manifestFile) : null; + + if (manifest != null && manifest.InternalName.IsNullOrEmpty()) + { + Log.Error("InternalName for dll at {Path} was null", manifestFile.FullName); + continue; + } + devPluginDefs.Add(new PluginDef(dllFile, manifest, true)); }