Commit graph

1616 commits

Author SHA1 Message Date
Haselnussbomber
c93f04f0e4
Code cleanup (#2439)
* Use new Lock objects

* Fix CA1513: Use ObjectDisposedException.ThrowIf

* Fix CA1860: Avoid using 'Enumerable.Any()' extension method

* Fix IDE0028: Use collection initializers or expressions

* Fix CA2263: Prefer generic overload when type is known

* Fix CA1862: Use the 'StringComparison' method overloads to perform case-insensitive string comparisons

* Fix IDE0270: Null check can be simplified

* Fix IDE0280: Use 'nameof'

* Fix IDE0009: Add '.this'

* Fix IDE0007: Use 'var' instead of explicit type

* Fix IDE0062: Make local function static

* Fix CA1859: Use concrete types when possible for improved performance

* Fix IDE0066: Use switch expression

Only applied to where it doesn't look horrendous.

* Use is over switch

* Fix CA1847: Use String.Contains(char) instead of String.Contains(string) with single characters

* Fix SYSLIB1045: Use 'GeneratedRegexAttribute' to generate the regular expression implementation at compile-time.

* Fix CA1866: Use 'string.EndsWith(char)' instead of 'string.EndsWith(string)' when you have a string with a single char

* Fix IDE0057: Substring can be simplified

* Fix IDE0059: Remove unnecessary value assignment

* Fix CA1510: Use ArgumentNullException throw helper

* Fix IDE0300: Use collection expression for array

* Fix IDE0250: Struct can be made 'readonly'

* Fix IDE0018: Inline variable declaration

* Fix CA1850: Prefer static HashData method over ComputeHash

* Fi CA1872: Prefer 'Convert.ToHexString' and 'Convert.ToHexStringLower' over call chains based on 'BitConverter.ToString'

* Update ModuleLog instantiations

* Organize usings
2026-01-06 08:36:55 -08:00
goat
f803dfbd44
Merge pull request #2546 from Infiziert90/todo-contentid
Mark PartyMember.ContentId type for API15
2025-12-21 14:46:53 +01:00
Infi
4dcfa9da98 - Add ToDo for ulong change 2025-12-21 14:37:03 +01:00
goat
1b39040072
Merge pull request #2535 from Haselnussbomber/rssb
Slight SeString code updates
2025-12-21 13:04:24 +01:00
KazWolfe
f307aded73
Lumina revert (#2544)
Some checks are pending
Build Dalamud / Build on Windows (push) Waiting to run
Build Dalamud / Check API Compatibility (push) Blocked by required conditions
Build Dalamud / Deploy dalamud-distrib staging (push) Blocked by required conditions
Tag Build / Tag Build (push) Successful in 3s
2025-12-21 02:31:17 +00:00
goat
a59efbd84c Fixes for excel renamings 2025-12-21 02:41:22 +01:00
Haselnussbomber
3ef6135f15
Fix reading ActiveFestivals in ZoneInitEventArgs 2025-12-20 21:26:10 +01:00
Haselnussbomber
6374c0d6ae
Use UIModuleHandlePacketDetour for ZoneInit 2025-12-20 21:25:49 +01:00
Haselnussbomber
8a49a5ee48
Use spread element for TextArrowPayloads
Also changes CreatePartyFinderLink to use client-language-based text.
2025-12-19 17:39:31 +01:00
Haselnussbomber
a3d930b8e2
Use RentedSeStringBuilder more 2025-12-19 17:34:42 +01:00
goaaats
c005bae265 Revert obsolete as error again, fix warnings, Api14ToDo => Api15ToDo
Some checks are pending
Build Dalamud / Build on Windows (push) Waiting to run
Build Dalamud / Check API Compatibility (push) Blocked by required conditions
Build Dalamud / Deploy dalamud-distrib staging (push) Blocked by required conditions
Tag Build / Tag Build (push) Successful in 4s
2025-12-18 21:00:07 +01:00
MidoriKami
37fa40ab58 Make stylecop happy 2025-12-17 16:44:04 -08:00
MidoriKami
7f4352dc43 Add address resolver 2025-12-17 16:38:34 -08:00
goat
355ad64eb9
Merge pull request #2508 from Haselnussbomber/excel-bump
Update Lumina and Lumina.Excel
2025-12-18 01:23:18 +01:00
goat
108a7a2c2d
Merge pull request #2510 from Haselnussbomber/conditions
Some checks failed
Build Dalamud / Build on Windows (push) Waiting to run
Build Dalamud / Check API Compatibility (push) Blocked by required conditions
Build Dalamud / Deploy dalamud-distrib staging (push) Blocked by required conditions
Rollup changes to next version / check (api14) (push) Failing after 7s
Tag Build / Tag Build (push) Successful in 4s
Update Condition/ConditionFlag
2025-12-17 18:48:25 +01:00
goat
c5d90aef64
Merge pull request #2511 from Haselnussbomber/context-menu-fix
Fix crashing Context Menu
2025-12-17 18:42:32 +01:00
Haselnussbomber
2fc9884aad
Update HoverActionKind 2025-12-17 18:17:44 +01:00
Haselnussbomber
b3c4363e0f
Fix crashing Context Menu 2025-12-17 17:09:18 +01:00
Haselnussbomber
841cdf52bd
Update Lumina and Lumina.Excel 2025-12-17 16:15:33 +01:00
Haselnussbomber
19660a20d9
Update Condition/ConditionFlag 2025-12-17 16:12:33 +01:00
Haselnussbomber
89fbe6c8b0
Update UiConfigOption 2025-12-16 17:21:19 +01:00
Haselnussbomber
1c1b60efee
Better enumerator code 2025-12-16 09:48:59 +01:00
goat
2e7c48316f
Merge pull request #2481 from MidoriKami/AddonLifecycleRefactor
Some checks failed
Build Dalamud / Build on Windows (push) Has been cancelled
Build Dalamud / Check API Compatibility (push) Has been cancelled
Build Dalamud / Deploy dalamud-distrib staging (push) Has been cancelled
[API14] AddonLifecycle Refactor
2025-12-16 00:32:09 +01:00
Aireil
56325afa7f
Remove obsolete enum values from FlyTextKind
They have been obsolete for nearly 7 months (before 7.3).
2025-12-15 23:14:46 +01:00
MidoriKami
1bff6abae9 Fix oopsie 2025-12-15 13:22:39 -08:00
MidoriKami
d7935d6dd4 Merge remote-tracking branch 'origin/AddonLifecycleRefactor' into AddonLifecycleRefactor 2025-12-15 13:13:19 -08:00
MidoriKami
a715725a9d Add enumerable AtkValue helper 2025-12-15 13:13:08 -08:00
MidoriKami
bc8e986c11
Merge branch 'api14' into AddonLifecycleRefactor 2025-12-15 12:55:35 -08:00
goaaats
20af5b40c7 Make all versioning functions internal, move to separate class 2025-12-15 21:31:25 +01:00
github-actions[bot]
180676fe47 Merge remote-tracking branch 'origin/master' into api14-rollup
Some checks failed
Build Dalamud / Build on Windows (push) Has been cancelled
Build Dalamud / Check API Compatibility (push) Has been cancelled
Build Dalamud / Deploy dalamud-distrib staging (push) Has been cancelled
2025-12-13 04:05:56 +00:00
Haselnussbomber
2d096d9b33
Properly initialize GameInventoryItems (#2504)
Some checks failed
Rollup changes to next version / check (api14) (push) Failing after 20s
Tag Build / Tag Build (push) Successful in 5s
Build Dalamud / Build on Windows (push) Has been cancelled
Build Dalamud / Check API Compatibility (push) Has been cancelled
Build Dalamud / Deploy dalamud-distrib staging (push) Has been cancelled
2025-12-13 14:05:03 +10:00
MidoriKami
4d9751ea5f
Merge branch 'api14' into AddonLifecycleRefactor 2025-12-10 14:16:56 -08:00
MidoriKami
2dbae05522 Add very thurough exception handling 2025-12-07 16:45:59 -08:00
Haselnussbomber
9e5723359a
Remove obsolete casts from Lumina.Text.SeString 2025-12-07 15:35:38 +01:00
goaaats
9fd59f736d Merge from master
Some checks are pending
Build Dalamud / Build on Windows (push) Waiting to run
Build Dalamud / Check API Compatibility (push) Blocked by required conditions
Build Dalamud / Deploy dalamud-distrib staging (push) Blocked by required conditions
2025-12-06 18:48:31 +01:00
MidoriKami
45366efd9f Remove SigScanner from ctor 2025-12-05 17:10:58 -08:00
MidoriKami
3c7dbf9f81 Remove AddonEventManagerAddressResolver.cs 2025-12-05 16:59:17 -08:00
github-actions[bot]
6f8e33a39c Merge remote-tracking branch 'origin/master' into api14-rollup
Some checks failed
Build Dalamud / Build on Windows (push) Has been cancelled
Build Dalamud / Check API Compatibility (push) Has been cancelled
Build Dalamud / Deploy dalamud-distrib staging (push) Has been cancelled
2025-12-04 22:03:13 +00:00
MidoriKami
0480693f92 Merge branch 'api14' into AddonLifecycleRefactor
# Conflicts:
#	Dalamud/Game/Addon/Lifecycle/AddonLifecycleAddressResolver.cs
2025-12-03 16:08:31 -08:00
goat
5bb212bfaa
Merge pull request #2424 from Haselnussbomber/fix-service-namespaces
Some checks failed
Build Dalamud / Build on Windows (push) Has been cancelled
Build Dalamud / Check API Compatibility (push) Has been cancelled
Build Dalamud / Deploy dalamud-distrib staging (push) Has been cancelled
[API14] Fix services using wrong namespaces
2025-12-04 00:56:10 +01:00
Haselnussbomber
518b3a4fb3
Fix NounProcessor BeastTribe column offset 2025-12-03 16:43:12 +01:00
Haselnussbomber
fb229a0a12
Fix PlayerState.Level being synced 2025-12-01 12:09:24 +01:00
MidoriKami
85a7c60dae Fix name inconsistency 2025-11-30 22:20:02 -08:00
MidoriKami
c923884626 Disable Logging 2025-11-30 22:15:32 -08:00
MidoriKami
78781c8988 Add Move, MouseOver, MouseOut, Focus 2025-11-30 21:43:26 -08:00
MidoriKami
b81cb9c74c Remove generic args class 2025-11-30 14:07:44 -08:00
MidoriKami
c9276b1771 Merge remote-tracking branch 'origin/AddonLifecycleRefactor' into AddonLifecycleRefactor
# Conflicts:
#	Dalamud/Game/Addon/Lifecycle/AddonArgTypes/AddonArgs.cs
#	Dalamud/Game/Addon/Lifecycle/AddonArgTypes/AddonDrawArgs.cs
#	Dalamud/Game/Addon/Lifecycle/AddonArgTypes/AddonFinalizeArgs.cs
#	Dalamud/Game/Addon/Lifecycle/AddonArgTypes/AddonReceiveEventArgs.cs
#	Dalamud/Game/Addon/Lifecycle/AddonArgTypes/AddonUpdateArgs.cs
#	Dalamud/Game/Addon/Lifecycle/AddonArgsType.cs
#	Dalamud/Game/Addon/Lifecycle/AddonLifecycle.cs
#	Dalamud/Game/Addon/Lifecycle/AddonLifecycleAddressResolver.cs
#	Dalamud/Game/Addon/Lifecycle/AddonVirtualTable.cs
2025-11-30 12:38:37 -08:00
MidoriKami
386828005b Apply breaking changes 2025-11-30 12:37:51 -08:00
MidoriKami
08c1768286 Bunch of stuff... 2025-11-30 11:33:06 -08:00
MidoriKami
eb9555ee22 Better unload 2025-11-30 11:33:06 -08:00