Merge pull request #2436 from Haselnussbomber/public-end-objects

Small ImRaii update
Provide PopupModal with flags
2026-02-18 13:57:43 +01:00 · 2025-10-22 15:10:41 +02:00 · 2025-10-22 07:18:43 +02:00 · 2025-10-22 07:16:13 +02:00
1 changed files with 5 additions and 2 deletions
--- a/Dalamud/Interface/Utility/Raii/EndObjects.cs
+++ b/Dalamud/Interface/Utility/Raii/EndObjects.cs
@ -40,6 +40,9 @@ public static partial class ImRaii
    public static IEndObject PopupModal(ImU8String id)
        => new EndConditionally(ImGui.EndPopup, ImGui.BeginPopupModal(id));

+    public static IEndObject PopupModal(ImU8String id, ImGuiWindowFlags flags)
+        => new EndConditionally(ImGui.EndPopup, ImGui.BeginPopupModal(id, flags));
+
    public static IEndObject PopupModal(ImU8String id, ref bool open)
        => new EndConditionally(ImGui.EndPopup, ImGui.BeginPopupModal(id, ref open));

@ -242,7 +245,7 @@ public static partial class ImRaii

    // Use end-function regardless of success.
    // Used by Child, Group and Tooltip.
-    private struct EndUnconditionally : IEndObject
+    public struct EndUnconditionally : IEndObject
    {
        private Action EndAction { get; }

@ -268,7 +271,7 @@ public static partial class ImRaii
    }

    // Use end-function only on success.
-    private struct EndConditionally : IEndObject
+    public struct EndConditionally : IEndObject
    {
        public EndConditionally(Action endAction, bool success)
        {
Author	SHA1	Message	Date
goat	21d4dbec66	Merge pull request #2436 from Haselnussbomber/public-end-objects Some checks are pending Build Dalamud / Build on Windows (push) Waiting to run Details Build Dalamud / Check API Compatibility (push) Blocked by required conditions Details Build Dalamud / Deploy dalamud-distrib staging (push) Blocked by required conditions Details Tag Build / Tag Build (push) Successful in 3s Details Small ImRaii update	2025-10-22 15:10:41 +02:00
Haselnussbomber	f0568216cb	Provide PopupModal with flags	2025-10-22 07:18:43 +02:00
Haselnussbomber	8ed21b4645	Public ImRaii end objects	2025-10-22 07:16:13 +02:00