Merge pull request #2437 from Haselnussbomber/fix-NotifyPluginsForStateChange

Lock plugin list in NotifyPluginsForStateChange
2026-02-23 08:17:47 +01:00 · 2025-10-22 21:50:40 +02:00 · 2025-10-22 19:14:29 +02:00
1 changed files with 8 additions and 5 deletions
--- a/Dalamud/Plugin/Internal/PluginManager.cs
+++ b/Dalamud/Plugin/Internal/PluginManager.cs
@ -1299,13 +1299,16 @@ internal class PluginManager : IInternalDisposableService
    /// <param name="affectedInternalNames">The affected plugins.</param>
    public void NotifyPluginsForStateChange(PluginListInvalidationKind kind, IEnumerable<string> affectedInternalNames)
    {
-        foreach (var installedPlugin in this.installedPluginsList)
+        lock (this.pluginListLock)
        {
-            if (!installedPlugin.IsLoaded || installedPlugin.DalamudInterface == null)
-                continue;
+            foreach (var installedPlugin in this.installedPluginsList)
+            {
+                if (!installedPlugin.IsLoaded || installedPlugin.DalamudInterface == null)
+                    continue;

-            installedPlugin.DalamudInterface.NotifyActivePluginsChanged(
-                new ActivePluginsChangedEventArgs(kind, affectedInternalNames));
+                installedPlugin.DalamudInterface.NotifyActivePluginsChanged(
+                    new ActivePluginsChangedEventArgs(kind, affectedInternalNames));
+            }
        }
    }
Author	SHA1	Message	Date
goat	7a45c0d661	Merge pull request #2437 from Haselnussbomber/fix-NotifyPluginsForStateChange Some checks failed Tag Build / Tag Build (push) Successful in 4s Details Build Dalamud / Build on Windows (push) Has been cancelled Details Build Dalamud / Check API Compatibility (push) Has been cancelled Details Build Dalamud / Deploy dalamud-distrib staging (push) Has been cancelled Details Lock plugin list in NotifyPluginsForStateChange	2025-10-22 21:50:40 +02:00
Haselnussbomber	87e391958e	Lock plugin list in NotifyPluginsForStateChange	2025-10-22 19:14:29 +02:00