diff --git a/Dalamud/Dalamud.csproj b/Dalamud/Dalamud.csproj index ce140b8c9..b5062438a 100644 --- a/Dalamud/Dalamud.csproj +++ b/Dalamud/Dalamud.csproj @@ -6,7 +6,7 @@ XIV Launcher addon framework - 13.0.0.11 + 13.0.0.10 $(DalamudVersion) $(DalamudVersion) $(DalamudVersion) diff --git a/Dalamud/Interface/Internal/DalamudInterface.cs b/Dalamud/Interface/Internal/DalamudInterface.cs index 202334580..f2ffc7a4c 100644 --- a/Dalamud/Interface/Internal/DalamudInterface.cs +++ b/Dalamud/Interface/Internal/DalamudInterface.cs @@ -1060,7 +1060,7 @@ internal class DalamudInterface : IInternalDisposableService { ImGui.PushFont(InterfaceManager.MonoFont); - ImGui.BeginMenu($"{Util.GetActiveTrack() ?? "???"} on {Util.GetGitBranch() ?? "???"}", false); + ImGui.BeginMenu(Util.GetBranch() ?? "???", false); ImGui.BeginMenu($"{Util.GetScmVersion()}", false); ImGui.BeginMenu(this.FrameCount.ToString("000000"), false); ImGui.BeginMenu(ImGui.GetIO().Framerate.ToString("000"), false); diff --git a/Dalamud/Interface/Internal/Windows/BranchSwitcherWindow.cs b/Dalamud/Interface/Internal/Windows/BranchSwitcherWindow.cs index 4e95b718e..da6217aca 100644 --- a/Dalamud/Interface/Internal/Windows/BranchSwitcherWindow.cs +++ b/Dalamud/Interface/Internal/Windows/BranchSwitcherWindow.cs @@ -46,12 +46,10 @@ public class BranchSwitcherWindow : Window this.branches = await client.GetFromJsonAsync>(BranchInfoUrl); Debug.Assert(this.branches != null, "this.branches != null"); - var trackName = Util.GetActiveTrack(); - this.selectedBranchIndex = this.branches.IndexOf(x => x.Value.Track != trackName); - if (this.selectedBranchIndex == -1) - { - this.selectedBranchIndex = 0; - } + var branch = Util.GetBranch(); + this.selectedBranchIndex = this.branches!.Any(x => x.Value.Track == branch) ? + this.branches.TakeWhile(x => x.Value.Track != branch).Count() + : 0; }); base.OnOpen(); @@ -105,7 +103,7 @@ public class BranchSwitcherWindow : Window }; ps.ArgumentList.Add($"--dalamud-beta-kind={config.DalamudBetaKind}"); - ps.ArgumentList.Add($"--dalamud-beta-key={(config.DalamudBetaKey.IsNullOrEmpty() ? "invalid" : config.DalamudBetaKey)}"); + ps.ArgumentList.Add($"--dalamud-beta-key={config.DalamudBetaKey}"); Process.Start(ps); Environment.Exit(0); diff --git a/Dalamud/Interface/Windowing/Window.cs b/Dalamud/Interface/Windowing/Window.cs index 44ff62199..d4f0070db 100644 --- a/Dalamud/Interface/Windowing/Window.cs +++ b/Dalamud/Interface/Windowing/Window.cs @@ -55,9 +55,6 @@ public abstract class Window private Vector2 fadeOutSize = Vector2.Zero; private Vector2 fadeOutOrigin = Vector2.Zero; - private bool hasError = false; - private Exception? lastError; - /// /// Initializes a new instance of the class. /// @@ -461,24 +458,14 @@ public abstract class Window this.presetDirty = true; } - if (this.hasError) + // Draw the actual window contents + try { - this.DrawErrorMessage(); + this.Draw(); } - else + catch (Exception ex) { - // Draw the actual window contents - try - { - this.Draw(); - } - catch (Exception ex) - { - Log.Error(ex, "Error during Draw(): {WindowName}", this.WindowName); - - this.hasError = true; - this.lastError = ex; - } + Log.Error(ex, "Error during Draw(): {WindowName}", this.WindowName); } } @@ -806,7 +793,7 @@ public abstract class Window hovered = true; // We can't use ImGui native functions here, because they don't work with clickthrough - if ((Windows.Win32.PInvoke.GetKeyState((int)VirtualKey.LBUTTON) & 0x8000) != 0) + if ((global::Windows.Win32.PInvoke.GetKeyState((int)VirtualKey.LBUTTON) & 0x8000) != 0) { held = true; pressed = true; @@ -884,52 +871,6 @@ public abstract class Window ImGui.End(); } - private void DrawErrorMessage() - { - // TODO: Once window systems are services, offer to reload the plugin - ImGui.TextColoredWrapped(ImGuiColors.DalamudRed,Loc.Localize("WindowSystemErrorOccurred", "An error occurred while rendering this window. Please contact the developer for details.")); - - ImGuiHelpers.ScaledDummy(5); - - if (ImGui.Button(Loc.Localize("WindowSystemErrorRecoverButton", "Attempt to retry"))) - { - this.hasError = false; - this.lastError = null; - } - - ImGui.SameLine(); - - if (ImGui.Button(Loc.Localize("WindowSystemErrorClose", "Close Window"))) - { - this.IsOpen = false; - this.hasError = false; - this.lastError = null; - } - - ImGuiHelpers.ScaledDummy(10); - - if (this.lastError != null) - { - using var child = ImRaii.Child("##ErrorDetails", new Vector2(0, 200 * ImGuiHelpers.GlobalScale), true); - using (ImRaii.PushColor(ImGuiCol.Text, ImGuiColors.DalamudGrey)) - { - ImGui.TextWrapped(Loc.Localize("WindowSystemErrorDetails", "Error Details:")); - ImGui.Separator(); - ImGui.TextWrapped(this.lastError.ToString()); - } - - var childWindowSize = ImGui.GetWindowSize(); - var copyText = Loc.Localize("WindowSystemErrorCopy", "Copy"); - var buttonWidth = ImGuiComponents.GetIconButtonWithTextWidth(FontAwesomeIcon.Copy, copyText); - ImGui.SetCursorPos(new Vector2(childWindowSize.X - buttonWidth - ImGui.GetStyle().FramePadding.X, - ImGui.GetStyle().FramePadding.Y)); - if (ImGuiComponents.IconButtonWithText(FontAwesomeIcon.Copy, copyText)) - { - ImGui.SetClipboardText(this.lastError.ToString()); - } - } - } - /// /// Structure detailing the size constraints of a window. /// diff --git a/Dalamud/Utility/Util.cs b/Dalamud/Utility/Util.cs index 19610ef64..2a3733303 100644 --- a/Dalamud/Utility/Util.cs +++ b/Dalamud/Utility/Util.cs @@ -140,10 +140,10 @@ public static partial class Util } /// - /// Gets the Git branch name this version of Dalamud was built from, or null, if this is a Debug build. + /// Gets the Dalamud branch name this version of Dalamud was built from, or null, if this is a Debug build. /// /// The branch name. - public static string? GetGitBranch() + public static string? GetBranch() { if (branchInternal != null) return branchInternal; @@ -155,17 +155,7 @@ public static partial class Util if (gitBranch == null) return null; - return branchInternal = gitBranch; - } - - /// - /// Gets the active Dalamud track, if this instance was launched through XIVLauncher and used a version - /// downloaded from webservices. - /// - /// The name of the track, or null. - internal static string? GetActiveTrack() - { - return Environment.GetEnvironmentVariable("DALAMUD_BRANCH"); + return branchInternal = gitBranch == "master" ? "release" : gitBranch; } ///