Fix crashes on custom faces.

This commit is contained in:
Ottermandias 2021-11-16 14:36:39 +01:00
parent 31cbff497f
commit 68552cb48f
2 changed files with 197 additions and 179 deletions

View file

@ -1,14 +1,16 @@
using System.Collections.Generic;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Numerics;
using Dalamud.Game.ClientState.Objects.Enums;
using Dalamud.Game.ClientState.Objects.Types;
using Dalamud.Interface;
using Dalamud.Logging;
using ImGuiNET;
using Penumbra.PlayerWatch;
namespace Glamourer.Gui
{
namespace Glamourer.Gui;
internal partial class Interface
{
public const int CharacterScreenIndex = 240;
@ -99,10 +101,17 @@ namespace Glamourer.Gui
if (_currentLabel != label)
return;
try
{
_currentSave.LoadCharacter(player);
_player = player;
_currentSave.WriteProtected = !modifiable;
}
catch (Exception e)
{
PluginLog.Error($"Could not load character {player.Name}s information:\n{e}");
}
}
private void DrawSelectionButtons()
{
@ -136,11 +145,18 @@ namespace Glamourer.Gui
if (select == null)
return;
try
{
_currentSave.LoadCharacter(select);
_player = select;
_currentLabel = _player.Name.ToString();
_currentSave.LoadCharacter(_player);
_currentSave.WriteProtected = false;
}
catch (Exception e)
{
PluginLog.Error($"Could not load character {select.Name}s information:\n{e}");
}
}
private void DrawPlayerSelector()
{
@ -205,4 +221,3 @@ namespace Glamourer.Gui
DrawActorPanel();
}
}
}

View file

@ -162,10 +162,13 @@ namespace Glamourer.Gui
var count = set.Count(CustomizationId.FacialFeaturesTattoos);
using (var _ = ImGuiRaii.NewGroup())
{
var face = set.Race == Race.Hrothgar ? customization.Hairstyle : customization.Face;
if (set.Faces.Count <= face)
face = 1;
for (var i = 0; i < count; ++i)
{
var enabled = customization.FacialFeature(i);
var feature = set.FacialFeature(set.Race == Race.Hrothgar ? customization.Hairstyle : customization.Face, i);
var feature = set.FacialFeature(face, i);
var icon = i == count - 1
? _legacyTattooIcon ?? Glamourer.Customization.GetIcon(feature.IconId)
: Glamourer.Customization.GetIcon(feature.IconId);
@ -249,7 +252,7 @@ namespace Glamourer.Gui
var current = set.DataByValue(id, customization[id], out var custom);
if (current < 0)
{
PluginLog.Warning($"Read invalid customization value {customization[id]} for {id}.");
label = $"{label} (Custom #{customization[id]})";
current = 0;
custom = set.Data(id, 0);
}