Finalize unlockstable, update design combos, add events for favorites, minor fixes.

This commit is contained in:
Ottermandias 2026-02-13 17:08:25 +01:00
parent a04042d6e8
commit f54ac8b0e5
15 changed files with 817 additions and 837 deletions

View file

@ -1,6 +1,5 @@
using Luna.Generators;
using ImSharp;
using Luna;
namespace Glamourer;
@ -41,8 +40,8 @@ public enum DesignPanelFlag : uint
public static partial class DesignPanelFlagExtensions
{
private static readonly SizedString Expand = new("Expand"u8);
private static readonly SizedString AdvancedCustomization = new(DesignPanelFlag.AdvancedCustomizations.ToNameU8());
private static readonly StringU8 Expand = new("Expand"u8);
private static readonly StringU8 AdvancedCustomization = DesignPanelFlag.AdvancedCustomizations.ToNameU8();
public static Im.HeaderDisposable Header(this DesignPanelFlag flag, Configuration config)
{
@ -56,8 +55,8 @@ public static partial class DesignPanelFlagExtensions
public static void DrawTable(ReadOnlySpan<byte> label, DesignPanelFlag hidden, DesignPanelFlag expanded, Action<DesignPanelFlag> setterHide,
Action<DesignPanelFlag> setterExpand)
{
var checkBoxWidth = Math.Max(Im.Style.FrameHeight, Expand.Size.X);
var textWidth = AdvancedCustomization.Size.X;
var checkBoxWidth = Math.Max(Im.Style.FrameHeight, Expand.CalculateSize().X);
var textWidth = AdvancedCustomization.CalculateSize().X;
var tableSize = 2 * (textWidth + 2 * checkBoxWidth)
+ 10 * Im.Style.CellPadding.X
+ 2 * Im.Style.WindowPadding.X

View file

@ -20,18 +20,18 @@ public class QuickSelectedDesign(QuickDesignCombo combo) : IDesignStandIn, IServ
=> ResolvedName;
public Design? CurrentDesign
=> combo.Design as Design;
=> combo.QuickDesign as Design;
public ref readonly DesignData GetDesignData(in DesignData baseRef)
{
if (combo.Design != null)
return ref combo.Design.GetDesignData(baseRef);
if (combo.QuickDesign is not null)
return ref combo.QuickDesign.GetDesignData(baseRef);
return ref baseRef;
}
public IReadOnlyList<(uint, MaterialValueDesign)> GetMaterialData()
=> combo.Design?.GetMaterialData() ?? [];
=> combo.QuickDesign?.GetMaterialData() ?? [];
public string SerializeName()
=> SerializedName;
@ -40,7 +40,7 @@ public class QuickSelectedDesign(QuickDesignCombo combo) : IDesignStandIn, IServ
=> StateSource.Manual;
public IEnumerable<(IDesignStandIn Design, ApplicationType Flags, JobFlag Jobs)> AllLinks(bool newApplication)
=> combo.Design?.AllLinks(newApplication) ?? [];
=> combo.QuickDesign?.AllLinks(newApplication) ?? [];
public void AddData(JObject jObj)
{ }
@ -52,11 +52,11 @@ public class QuickSelectedDesign(QuickDesignCombo combo) : IDesignStandIn, IServ
=> false;
public bool ForcedRedraw
=> combo.Design?.ForcedRedraw ?? false;
=> combo.QuickDesign?.ForcedRedraw ?? false;
public bool ResetAdvancedDyes
=> combo.Design?.ResetAdvancedDyes ?? false;
=> combo.QuickDesign?.ResetAdvancedDyes ?? false;
public bool ResetTemporarySettings
=> combo.Design?.ResetTemporarySettings ?? false;
=> combo.QuickDesign?.ResetTemporarySettings ?? false;
}

View file

@ -1,427 +1,383 @@
using Dalamud.Interface.Utility.Raii;
using Glamourer.Automation;
using Glamourer.Automation;
using Glamourer.Designs;
using Glamourer.Designs.History;
using Glamourer.Designs.Special;
using Glamourer.Events;
using Dalamud.Bindings.ImGui;
using ImSharp;
using OtterGui;
using OtterGui.Classes;
using OtterGui.Extensions;
using OtterGui.Log;
using OtterGui.Widgets;
using MouseWheelType = OtterGui.Widgets.MouseWheelType;
using Luna;
namespace Glamourer.Gui;
//public abstract class DesignComboBase2 : ImSharp.FilterComboBase<DesignComboBase2.CacheItem>, IDisposable
//{
// protected readonly EphemeralConfig Config;
// protected readonly DesignChanged DesignChanged;
// protected readonly DesignColors DesignColors;
// protected readonly TabSelected TabSelected;
// protected IDesignStandIn? _currentDesign;
//
// private CacheItem CreateItem(IDesignStandIn design)
// {
//
// }
//
// public readonly struct CacheItem(IDesignStandIn design, Vector4 color)
// {
// public readonly IDesignStandIn Design = design;
// public readonly StringPair Name = new(design.ResolveName(false));
// public readonly StringPair Incognito = new(design.ResolveName(true));
// public readonly StringPair FullPath = StringPair.Empty;
// public readonly Vector4 Color = color;
// }
//
// public DesignComboBase2(EphemeralConfig config, DesignChanged designChanged, DesignColors designColors, TabSelected tabSelected)
// {
// Config = config;
// DesignChanged = designChanged;
// DesignColors = designColors;
// TabSelected = tabSelected;
//
// DesignChanged.Subscribe(OnDesignChanged, DesignChanged.Priority.DesignCombo);
// }
//
// private void OnDesignChanged(DesignChanged.Type type, Design? _1, ITransaction? _2 = null)
// {
// _isCurrentSelectionDirty = type switch
// {
// DesignChanged.Type.Created => true,
// DesignChanged.Type.Renamed => true,
// DesignChanged.Type.ChangedColor => true,
// DesignChanged.Type.Deleted => true,
// DesignChanged.Type.QuickDesignBar => true,
// _ => _isCurrentSelectionDirty,
// };
// }
//
// protected override bool DrawItem(in CacheItem item, int globalIndex, bool selected)
// {
//
// }
//
// public void Dispose()
// {
// DesignChanged.Unsubscribe(OnDesignChanged);
// }
//}
public abstract class DesignComboBase : FilterComboCache<Tuple<IDesignStandIn, string>>, IDisposable
public abstract class DesignComboBase(
EphemeralConfig config,
DesignManager designs,
DesignChanged designChanged,
DesignColors designColors,
TabSelected tabSelected,
DesignFileSystem designFileSystem)
: FilterComboBase<DesignComboBase.CacheItem>(new DesignFilter(), ConfigData.Default with { ComputeWidth = true })
{
protected readonly EphemeralConfig Config;
protected readonly DesignChanged DesignChanged;
protected readonly DesignColors DesignColors;
protected readonly TabSelected TabSelected;
protected float InnerWidth;
private IDesignStandIn? _currentDesign;
private bool _isCurrentSelectionDirty;
protected readonly EphemeralConfig Config = config;
protected readonly DesignChanged DesignChanged = designChanged;
protected readonly DesignColors DesignColors = designColors;
protected readonly DesignFileSystem DesignFileSystem = designFileSystem;
protected readonly TabSelected TabSelected = tabSelected;
protected readonly DesignManager Designs = designs;
protected IDesignStandIn? CurrentDesign;
protected DesignComboBase(Func<IReadOnlyList<Tuple<IDesignStandIn, string>>> generator, Logger log, DesignChanged designChanged,
TabSelected tabSelected, EphemeralConfig config, DesignColors designColors)
: base(generator, MouseWheelType.Control, log)
protected CacheItem CreateItem(IDesignStandIn design)
{
DesignChanged = designChanged;
TabSelected = tabSelected;
Config = config;
DesignColors = designColors;
DesignChanged.Subscribe(OnDesignChanged, DesignChanged.Priority.DesignCombo);
var color = design is Design d1 ? DesignColors.GetColor(d1).ToVector() : ColorId.NormalDesign.Value().ToVector();
var path = design is Design d2 && DesignFileSystem.TryGetValue(d2, out var leaf) ? leaf.FullName() : string.Empty;
var name = design.ResolveName(false);
if (path == name)
path = string.Empty;
return new CacheItem(design, color, path, name);
}
void IDisposable.Dispose()
{
DesignChanged.Unsubscribe(OnDesignChanged);
GC.SuppressFinalize(this);
}
protected override bool IsSelected(CacheItem item, int globalIndex)
=> item.Design == CurrentDesign;
protected override bool DrawSelectable(int globalIdx, bool selected)
public virtual bool Draw(Utf8StringHandler<LabelStringHandlerBuffer> label, IDesignStandIn? currentDesign, out IDesignStandIn? newSelection,
float width)
{
var (design, path) = Items[globalIdx];
CurrentDesign = currentDesign;
bool ret;
switch (design)
using (ImGuiColor.Text.Push(DesignColors.GetColor(CurrentDesign as Design)))
{
case Design realDesign:
{
using var color = ImGuiColor.Text.Push(DesignColors.GetColor(realDesign));
ret = base.DrawSelectable(globalIdx, selected);
DrawPath(path, realDesign);
return ret;
}
case QuickSelectedDesign quickDesign:
{
using var color = ImGuiColor.Text.Push(ColorId.NormalDesign.Value());
ret = base.DrawSelectable(globalIdx, selected);
DrawResolvedDesign(quickDesign);
return ret;
}
default: return base.DrawSelectable(globalIdx, selected);
}
}
private static void DrawPath(string path, Design realDesign)
{
if (path.Length <= 0 || realDesign.Name == path)
return;
DrawRightAligned(realDesign.Name, path, ImGuiColor.TextDisabled.Get().Color);
}
private void DrawResolvedDesign(QuickSelectedDesign quickDesign)
{
var linkedDesign = quickDesign.CurrentDesign;
if (linkedDesign != null)
DrawRightAligned(quickDesign.ResolveName(false), linkedDesign.Name.Text, DesignColors.GetColor(linkedDesign));
else
DrawRightAligned(quickDesign.ResolveName(false), "[Nothing]", DesignColors.MissingColor);
}
protected bool Draw(IDesignStandIn? currentDesign, string? label, float width)
{
_currentDesign = currentDesign;
UpdateCurrentSelection();
InnerWidth = 400 * Im.Style.GlobalScale;
var name = label ?? "Select Design Here...";
bool ret;
using (currentDesign is not null ? ImGuiColor.Text.Push(DesignColors.GetColor(currentDesign as Design)) : null)
{
ret = Draw("##design", name, string.Empty, width, Im.Style.TextHeightWithSpacing) && CurrentSelection is not null;
ret = currentDesign is null
? base.Draw(label, "Select Design Here..."u8, StringU8.Empty, width, out var result)
: base.Draw(label, currentDesign.ResolveName(Config.IncognitoMode), StringU8.Empty, width, out result);
newSelection = ret ? result.Design : currentDesign;
}
if (currentDesign is Design design)
if (CurrentDesign is Design design)
{
if (Im.Item.RightClicked() && Im.Io.KeyControl)
TabSelected.Invoke(MainTabType.Designs, design);
ImGuiUtil.HoverTooltip("Control + Right-Click to move to design.");
Im.Tooltip.OnHover("Control + Right-Click to move to design."u8);
}
else
{
QuickSelectedDesignTooltip(CurrentDesign as QuickSelectedDesign);
}
QuickSelectedDesignTooltip(currentDesign);
_currentDesign = null;
CurrentDesign = null;
return ret;
}
protected override string ToString(Tuple<IDesignStandIn, string> obj)
=> obj.Item1.ResolveName(Config.IncognitoMode);
protected override float GetFilterWidth()
=> InnerWidth - 2 * Im.Style.FramePadding.X;
protected override bool IsVisible(int globalIndex, LowerString filter)
private void QuickSelectedDesignTooltip(QuickSelectedDesign? design)
{
var (design, path) = Items[globalIndex];
return filter.IsContained(path) || filter.IsContained(design.ResolveName(false));
}
protected override void OnMouseWheel(string preview, ref int _2, int steps)
{
if (!ReferenceEquals(_currentDesign, CurrentSelection?.Item1))
CurrentSelectionIdx = -1;
base.OnMouseWheel(preview, ref _2, steps);
}
private void UpdateCurrentSelection()
{
if (!_isCurrentSelectionDirty)
if (design is null)
return;
var priorState = IsInitialized;
if (priorState)
Cleanup();
CurrentSelectionIdx = Items.IndexOf(s => ReferenceEquals(s.Item1, CurrentSelection?.Item1));
if (CurrentSelectionIdx >= 0)
{
UpdateSelection(Items[CurrentSelectionIdx]);
}
else if (Items.Count > 0)
{
CurrentSelectionIdx = 0;
UpdateSelection(Items[0]);
}
else
{
UpdateSelection(null);
}
if (!priorState)
Cleanup();
_isCurrentSelectionDirty = false;
}
protected override int UpdateCurrentSelected(int currentSelected)
{
CurrentSelectionIdx = Items.IndexOf(p => _currentDesign == p.Item1);
UpdateSelection(CurrentSelectionIdx >= 0 ? Items[CurrentSelectionIdx] : null);
return CurrentSelectionIdx;
}
private void OnDesignChanged(DesignChanged.Type type, Design? _1, ITransaction? _2 = null)
{
_isCurrentSelectionDirty = type switch
{
DesignChanged.Type.Created => true,
DesignChanged.Type.Renamed => true,
DesignChanged.Type.ChangedColor => true,
DesignChanged.Type.Deleted => true,
DesignChanged.Type.QuickDesignBar => true,
_ => _isCurrentSelectionDirty,
};
}
private void QuickSelectedDesignTooltip(IDesignStandIn? design)
{
if (!ImGui.IsItemHovered())
if (!Im.Item.Hovered())
return;
if (design is not QuickSelectedDesign q)
return;
using var tt = ImRaii.Tooltip();
var linkedDesign = q.CurrentDesign;
if (linkedDesign != null)
using var tt = Im.Tooltip.Begin();
var linkedDesign = design.CurrentDesign;
if (linkedDesign is not null)
{
ImGui.TextUnformatted("Currently resolving to ");
Im.Text("Currently resolving to "u8);
using var color = ImGuiColor.Text.Push(DesignColors.GetColor(linkedDesign));
ImGui.SameLine(0, 0);
ImGui.TextUnformatted(linkedDesign.Name.Text);
Im.Line.NoSpacing();
Im.Text(linkedDesign.Name.Text);
}
else
{
ImGui.TextUnformatted("No design selected in the Quick Design Bar.");
Im.Text("No design selected in the Quick Design Bar."u8);
}
}
private static void DrawRightAligned(string leftText, string text, Rgba32 color)
protected sealed class DesignFilter : Utf8FilterBase<CacheItem>
{
var start = ImGui.GetItemRectMin();
var pos = start.X + ImGui.CalcTextSize(leftText).X;
var maxSize = ImGui.GetWindowPos().X + ImGui.GetWindowContentRegionMax().X;
var remainingSpace = maxSize - pos;
var requiredSize = ImGui.CalcTextSize(text).X + Im.Style.ItemInnerSpacing.X;
var offset = remainingSpace - requiredSize;
if (ImGui.GetScrollMaxY() == 0)
offset -= Im.Style.ItemInnerSpacing.X;
if (offset < Im.Style.ItemSpacing.X)
ImGuiUtil.HoverTooltip(text);
else
Im.Window.DrawList.Text(start with { X = pos + offset }, color, text);
}
}
public abstract class DesignCombo : DesignComboBase
{
protected DesignCombo(Logger log, DesignChanged designChanged, TabSelected tabSelected,
EphemeralConfig config, DesignColors designColors, Func<IReadOnlyList<Tuple<IDesignStandIn, string>>> generator)
: base(generator, log, designChanged, tabSelected, config, designColors)
{
if (Items.Count == 0)
return;
CurrentSelection = Items[0];
CurrentSelectionIdx = 0;
base.Cleanup();
}
public IDesignStandIn? Design
=> CurrentSelection?.Item1;
public void Draw(float width)
=> Draw(Design, Design?.ResolveName(Config.IncognitoMode) ?? string.Empty, width);
}
public sealed class QuickDesignCombo : DesignCombo
{
public QuickDesignCombo(DesignFileSystem fileSystem,
Logger log,
DesignChanged designChanged,
TabSelected tabSelected,
EphemeralConfig config,
DesignColors designColors)
: base(log, designChanged, tabSelected, config, designColors, () =>
[
.. fileSystem
.Where(kvp => kvp.Key.QuickDesign)
.Select(kvp => new Tuple<IDesignStandIn, string>(kvp.Key, kvp.Value.FullName()))
.OrderBy(d => d.Item2),
])
{
if (config.SelectedQuickDesign != Guid.Empty)
public override bool DrawFilter(ReadOnlySpan<byte> label, Vector2 availableRegion)
{
CurrentSelectionIdx = Items.IndexOf(t => t.Item1 is Design d && d.Identifier == config.SelectedQuickDesign);
if (CurrentSelectionIdx >= 0)
CurrentSelection = Items[CurrentSelectionIdx];
else if (Items.Count > 0)
CurrentSelectionIdx = 0;
using var _ = ImGuiColor.Text.PushDefault();
return base.DrawFilter(label, availableRegion);
}
AllowMouseWheel = MouseWheelType.Unmodified;
SelectionChanged += OnSelectionChange;
public override bool WouldBeVisible(in CacheItem item, int globalIndex)
=> WouldBeVisible(item.Name.Utf8) || WouldBeVisible(item.Incognito.Utf8) || WouldBeVisible(item.FullPath.Utf8);
protected override ReadOnlySpan<byte> ToFilterString(in CacheItem item, int globalIndex)
=> item.Name.Utf8;
}
private void OnSelectionChange(Tuple<IDesignStandIn, string>? old, Tuple<IDesignStandIn, string>? @new)
protected sealed class Cache : FilterComboBaseCache<CacheItem>
{
if (old == null)
private new DesignComboBase Parent
=> (DesignComboBase)base.Parent;
public Cache(DesignComboBase parent)
: base(parent)
{
if (@new?.Item1 is not Design d)
Parent.DesignColors.ColorChanged += OnDesignColorChanged;
Parent.DesignChanged.Subscribe(OnDesignChanged, DesignChanged.Priority.DesignCombo);
}
protected override void ComputeWidth()
=> ComboWidth = UnfilteredItems.Max(d
=> d.Name.Utf8.CalculateSize(false).X + d.FullPath.Utf8.CalculateSize(false).X + 2 * Im.Style.ItemSpacing.X + Im.Style.ScrollbarSize);
protected override void Dispose(bool disposing)
{
Parent.DesignColors.ColorChanged -= OnDesignColorChanged;
Parent.DesignChanged.Unsubscribe(OnDesignChanged);
base.Dispose(disposing);
}
private void OnDesignColorChanged()
=> Dirty |= IManagedCache.DirtyFlags.Custom;
private void OnDesignChanged(DesignChanged.Type type, Design? _1, ITransaction? _2 = null)
{
if (type switch
{
DesignChanged.Type.Created => true,
DesignChanged.Type.Renamed => true,
DesignChanged.Type.ChangedColor => true,
DesignChanged.Type.Deleted => true,
DesignChanged.Type.QuickDesignBar => true,
_ => false,
})
Dirty |= IManagedCache.DirtyFlags.Custom;
}
}
protected override FilterComboBaseCache<CacheItem> CreateCache()
=> new Cache(this);
public readonly struct CacheItem(IDesignStandIn design, Vector4 color, string path, string name)
{
public readonly IDesignStandIn Design = design;
public readonly StringPair Name = new(name);
public readonly StringPair Incognito = new(design.ResolveName(true));
public readonly StringPair FullPath = new(path);
public readonly Vector4 Color = color;
public static string Ordering(CacheItem item)
=> item.FullPath.Utf16.Length > 0 ? item.FullPath.Utf16 : item.Name.Utf16;
}
protected override bool DrawItem(in CacheItem item, int globalIndex, bool selected)
{
using var color = ImGuiColor.Text.Push(item.Color);
var name = Config.IncognitoMode ? item.Incognito.Utf8 : item.Name.Utf8;
var ret = Im.Selectable(name, selected);
if (!item.FullPath.IsEmpty && !Config.IncognitoMode)
{
Im.Line.Same();
color.Push(ImGuiColor.Text, Im.Style[ImGuiColor.TextDisabled]);
ImEx.TextRightAligned(item.FullPath.Utf8);
}
else if (item.Design is QuickSelectedDesign { CurrentDesign: { } d })
{
Im.Line.Same();
color.Push(ImGuiColor.Text, DesignColors.GetColor(d));
ImEx.TextRightAligned(d.ResolveName(Config.IncognitoMode));
}
return ret;
}
protected override float ItemHeight
=> Im.Style.TextHeightWithSpacing;
}
public sealed class QuickDesignCombo : DesignComboBase, IDisposable, IUiService
{
public Design? QuickDesign
{
get;
private set
{
if (field == value)
return;
Config.SelectedQuickDesign = d.Identifier;
Config.Save();
}
else if (@new?.Item1 is not Design d)
{
Config.SelectedQuickDesign = Guid.Empty;
Config.Save();
}
else if (!old.Item1.Equals(@new.Item1))
{
Config.SelectedQuickDesign = d.Identifier;
field = value;
Config.SelectedQuickDesign = field?.Identifier ?? Guid.Empty;
Config.Save();
}
}
public QuickDesignCombo(EphemeralConfig config, DesignChanged designChanged, DesignColors designColors, TabSelected tabSelected,
DesignFileSystem designFileSystem, DesignManager designs)
: base(config, designs, designChanged, designColors, tabSelected, designFileSystem)
{
if (Designs.Designs.TryGetValue(config.SelectedQuickDesign, out var design) && design.QuickDesign)
QuickDesign = design;
DesignChanged.Subscribe(OnDesignChanged, DesignChanged.Priority.DesignCombo);
}
private void OnDesignChanged(DesignChanged.Type type, Design changedDesign, ITransaction? _)
{
switch (type)
{
case DesignChanged.Type.Created:
// If the quick design bar has no selection, select the new design if it supports the bar.
if (QuickDesign is null && changedDesign.QuickDesign)
QuickDesign = changedDesign;
break;
case DesignChanged.Type.Deleted:
// If the deleted design was selected, select the first design that supports the bar, if any.
if (QuickDesign == changedDesign)
QuickDesign = Designs.Designs.FirstOrDefault(d => d.QuickDesign);
break;
case DesignChanged.Type.ReloadedAll:
// If all designs were reloaded, update the selection.
QuickDesign = Designs.Designs.TryGetValue(Config.SelectedQuickDesign, out var design) && design.QuickDesign ? design : null;
break;
case DesignChanged.Type.QuickDesignBar:
// If the quick design support of a design was changed, select the new design if the bar has no selection and the design now supports it,
if (QuickDesign is null && changedDesign.QuickDesign)
QuickDesign = changedDesign;
// or select the first design that supports the bar, if any, if the support was removed from the currently selected design.
else if (QuickDesign == changedDesign && !changedDesign.QuickDesign)
QuickDesign = Designs.Designs.FirstOrDefault(d => d.QuickDesign);
break;
}
}
public bool Draw(Utf8StringHandler<LabelStringHandlerBuffer> label, float width)
{
if (!base.Draw(label, QuickDesign, out var newDesign, width))
return false;
QuickDesign = newDesign as Design;
return true;
}
protected override IEnumerable<CacheItem> GetItems()
=> Designs.Designs
.Where(design => design.QuickDesign)
.Select(CreateItem)
.OrderBy(CacheItem.Ordering);
public void Dispose()
=> DesignChanged.Unsubscribe(OnDesignChanged);
}
public sealed class LinkDesignCombo(
DesignFileSystem fileSystem,
Logger log,
DesignChanged designChanged,
TabSelected tabSelected,
EphemeralConfig config,
DesignColors designColors)
: DesignCombo(log, designChanged, tabSelected, config, designColors, () =>
[
.. fileSystem
.Select(kvp => new Tuple<IDesignStandIn, string>(kvp.Key, kvp.Value.FullName()))
.OrderBy(d => d.Item2),
]);
public sealed class LinkDesignCombo : DesignComboBase, IUiService, IDisposable
{
public Design? NewSelection { get; private set; }
public LinkDesignCombo(EphemeralConfig config, DesignChanged designChanged, DesignColors designColors, TabSelected tabSelected,
DesignFileSystem designFileSystem, DesignManager designs)
: base(config, designs, designChanged, designColors, tabSelected, designFileSystem)
{
DesignChanged.Subscribe(OnDesignChanged, DesignChanged.Priority.DesignCombo);
}
public bool Draw(Utf8StringHandler<LabelStringHandlerBuffer> label, float width)
{
if (!base.Draw(label, NewSelection, out var newSelection, width))
return false;
NewSelection = newSelection as Design;
return true;
}
protected override IEnumerable<CacheItem> GetItems()
=> Designs.Designs.Select(CreateItem)
.OrderBy(CacheItem.Ordering);
public void Dispose()
=> DesignChanged.Unsubscribe(OnDesignChanged);
private void OnDesignChanged(DesignChanged.Type type, Design design, ITransaction? _)
{
if (type is DesignChanged.Type.Deleted && design == NewSelection || type is DesignChanged.Type.ReloadedAll)
NewSelection = null;
}
}
public sealed class RandomDesignCombo(
DesignManager designs,
DesignFileSystem fileSystem,
Logger log,
DesignChanged designChanged,
TabSelected tabSelected,
EphemeralConfig config,
DesignColors designColors)
: DesignCombo(log, designChanged, tabSelected, config, designColors, () =>
[
.. fileSystem
.Select(kvp => new Tuple<IDesignStandIn, string>(kvp.Key, kvp.Value.FullName()))
.OrderBy(d => d.Item2),
])
DesignManager designs,
DesignChanged designChanged,
DesignColors designColors,
TabSelected tabSelected,
DesignFileSystem designFileSystem) : DesignComboBase(config, designs, designChanged, designColors, tabSelected, designFileSystem),
IUiService
{
private Design? GetDesign(RandomPredicate.Exact exact)
{
return exact.Which switch
{
RandomPredicate.Exact.Type.Name => designs.Designs.FirstOrDefault(d => d.Name == exact.Value),
RandomPredicate.Exact.Type.Path => fileSystem.Find(exact.Value.Text, out var c) && c is DesignFileSystem.Leaf l ? l.Value : null,
RandomPredicate.Exact.Type.Identifier => designs.Designs.ByIdentifier(Guid.TryParse(exact.Value.Text, out var g) ? g : Guid.Empty),
RandomPredicate.Exact.Type.Name => Designs.Designs.FirstOrDefault(d => d.Name == exact.Value),
RandomPredicate.Exact.Type.Path => DesignFileSystem.Find(exact.Value.Text, out var c) && c is DesignFileSystem.Leaf l
? l.Value
: null,
RandomPredicate.Exact.Type.Identifier => Designs.Designs.ByIdentifier(Guid.TryParse(exact.Value.Text, out var g)
? g
: Guid.Empty),
_ => null,
};
}
public bool Draw(RandomPredicate.Exact exact, float width)
public bool Draw(RandomPredicate.Exact exact, [NotNullWhen(true)] out Design? newDesign, float width)
{
var design = GetDesign(exact);
return Draw(design, design?.ResolveName(Config.IncognitoMode) ?? $"Not Found [{exact.Value.Text}]", width);
if (Draw(StringU8.Empty, design?.ResolveName(Config.IncognitoMode) ?? $"Not Found [{exact.Value.Text}]", StringU8.Empty, width,
out var newItem)
&& newItem.Design is Design d)
{
newDesign = d;
return true;
}
newDesign = null;
return false;
}
public bool Draw(IDesignStandIn? design, float width)
=> Draw(design, design?.ResolveName(Config.IncognitoMode) ?? string.Empty, width);
protected override IEnumerable<CacheItem> GetItems()
=> Designs.Designs.Select(CreateItem)
.OrderBy(CacheItem.Ordering);
}
public sealed class SpecialDesignCombo(
DesignFileSystem fileSystem,
TabSelected tabSelected,
DesignColors designColors,
Logger log,
DesignChanged designChanged,
AutoDesignManager autoDesignManager,
EphemeralConfig config,
RandomDesignGenerator rng,
QuickSelectedDesign quickSelectedDesign)
: DesignComboBase(() => fileSystem
.Select(kvp => new Tuple<IDesignStandIn, string>(kvp.Key, kvp.Value.FullName()))
.OrderBy(d => d.Item2)
.Prepend(new Tuple<IDesignStandIn, string>(new RandomDesign(rng), string.Empty))
.Prepend(new Tuple<IDesignStandIn, string>(quickSelectedDesign, string.Empty))
.Prepend(new Tuple<IDesignStandIn, string>(new RevertDesign(), string.Empty))
.ToList(), log, designChanged, tabSelected, config, designColors)
public sealed class SpecialDesignCombo : DesignComboBase, IUiService
{
private readonly AutoDesignManager _autoDesigns;
private readonly CacheItem _random;
private readonly CacheItem _revert;
private readonly CacheItem _quick;
public SpecialDesignCombo(EphemeralConfig config,
DesignManager designs,
DesignChanged designChanged,
DesignColors designColors,
TabSelected tabSelected,
DesignFileSystem designFileSystem,
AutoDesignManager autoDesigns,
RandomDesignGenerator rng, QuickSelectedDesign quickSelectedDesign)
: base(config, designs, designChanged, designColors, tabSelected, designFileSystem)
{
_autoDesigns = autoDesigns;
_random = CreateItem(new RandomDesign(rng));
_revert = CreateItem(new RevertDesign());
_quick = CreateItem(quickSelectedDesign);
}
public void Draw(AutoDesignSet set, AutoDesign? design, int autoDesignIndex)
{
if (!Draw(design?.Design, design?.Design.ResolveName(Config.IncognitoMode), Im.ContentRegion.Available.X))
if (!Draw(StringU8.Empty, design?.Design, out var newSelection, Im.ContentRegion.Available.X) || newSelection is null)
return;
if (autoDesignIndex >= 0)
autoDesignManager.ChangeDesign(set, autoDesignIndex, CurrentSelection!.Item1);
_autoDesigns.ChangeDesign(set, autoDesignIndex, newSelection);
else
autoDesignManager.AddDesign(set, CurrentSelection!.Item1);
_autoDesigns.AddDesign(set, newSelection);
}
protected override IEnumerable<CacheItem> GetItems()
=> Designs.Designs
.Select(CreateItem)
.OrderBy(CacheItem.Ordering)
.Prepend(_random)
.Prepend(_quick)
.Prepend(_revert);
}

View file

@ -109,7 +109,7 @@ public sealed class DesignQuickBar : Window, IDisposable
if (_config.QdbButtons.HasFlag(QdbButtons.ApplyDesign))
{
var comboSize = width - _numButtons * (buttonSize.X + spacing.X);
_designCombo.Draw(comboSize);
_designCombo.Draw(StringU8.Empty, comboSize);
Im.Line.Same();
DrawApplyButton(buttonSize);
}
@ -142,7 +142,7 @@ public sealed class DesignQuickBar : Window, IDisposable
private void DrawApplyButton(Vector2 size)
{
var design = _designCombo.Design as Design;
var design = _designCombo.QuickDesign;
var available = 0;
_tooltipBuilder.Clear();

View file

@ -34,14 +34,11 @@ public abstract class BaseItemCombo(FavoriteManager favorites, ItemManager items
return false;
}
public readonly struct CacheItem(EquipItem item) : IDisposable
public readonly struct CacheItem(EquipItem item)
{
public readonly EquipItem Item = item;
public readonly StringPair Name = new(item.Name);
public readonly SizedStringPair Model = new($"({item.PrimaryId.Id}-{item.Variant.Id})");
public void Dispose()
=> Model.Dispose();
public readonly EquipItem Item = item;
public readonly StringPair Name = new(item.Name);
public readonly StringPair Model = new($"({item.PrimaryId.Id}-{item.Variant.Id})");
}
protected sealed class ItemFilter : PartwiseFilterBase<CacheItem>
@ -85,7 +82,7 @@ public abstract class BaseItemCombo(FavoriteManager favorites, ItemManager items
var ret = Im.Selectable(item.Name.Utf8, selected);
Im.Line.Same();
using var color = ImGuiColor.Text.Push(Rgba32.Gray);
ImEx.TextRightAligned(item.Model);
ImEx.TextRightAligned(item.Model.Utf8);
return ret;
}

View file

@ -236,9 +236,9 @@ public sealed class RandomRestrictionDrawer : IService, IDisposable
{
ImEx.TextFrameAligned("that are exactly"u8);
table.NextColumn();
if (_randomDesignCombo.Draw(exact, Im.ContentRegion.Available.X) && _randomDesignCombo.Design is Design d)
if (_randomDesignCombo.Draw(exact, out var newDesign, Im.ContentRegion.Available.X))
{
list[i] = new RandomPredicate.Exact(RandomPredicate.Exact.Type.Identifier, d.Identifier.ToString());
list[i] = new RandomPredicate.Exact(RandomPredicate.Exact.Type.Identifier, newDesign.Identifier.ToString());
_autoDesignManager.ChangeData(_set!, _designIndex, list);
}
@ -314,8 +314,8 @@ public sealed class RandomRestrictionDrawer : IService, IDisposable
"Add a new condition that the design must be assigned to the given color."u8, invalid)
&& Add(new RandomPredicate.Exact(RandomPredicate.Exact.Type.Color, _newText));
if (_randomDesignCombo.Draw(_newDesign, Im.ContentRegion.Available.X - Im.Style.ItemInnerSpacing.X - buttonSize.X))
_newDesign = _randomDesignCombo.CurrentSelection?.Item1 as Design;
if (_randomDesignCombo.Draw(StringU8.Empty, _newDesign, out var newDesign, Im.ContentRegion.Available.X - Im.Style.ItemInnerSpacing.X - buttonSize.X))
_newDesign = newDesign as Design;
Im.Line.SameInner();
if (ImEx.Button("Exact Design"u8, buttonSize, "Add a single, specific design."u8, _newDesign is null))
{

View file

@ -151,12 +151,12 @@ public class DesignLinkDrawer(
{
table.NextColumn();
table.NextColumn();
combo.Draw(Im.ContentRegion.Available.X);
combo.Draw(StringU8.Empty, Im.ContentRegion.Available.X);
table.NextColumn();
string ttBefore, ttAfter;
bool canAddBefore, canAddAfter;
var design = combo.Design as Design;
if (design == null)
var design = combo.NewSelection;
if (design is null)
{
ttAfter = ttBefore = "Select a design first.";
canAddBefore = canAddAfter = false;
@ -180,7 +180,7 @@ public class DesignLinkDrawer(
}
Im.Line.Same();
if (ImEx.Icon.Button(FontAwesomeIcon.ArrowCircleUp.Icon(), ttAfter, !canAddAfter))
if (ImEx.Icon.Button(FontAwesomeIcon.ArrowCircleDown.Icon(), ttAfter, !canAddAfter))
linkManager.AddDesignLink(selector.Selected!, design!, LinkOrder.After);
}

View file

@ -0,0 +1,51 @@
using ImSharp;
using Penumbra.GameData.Enums;
using Penumbra.GameData.Structs;
namespace Glamourer.Gui.Tabs.UnlocksTab;
public readonly struct UnlockCacheItem(in EquipItem item, in EquipItem offhand, in EquipItem gauntlets, in JobGroup jobs)
{
private static readonly StringU8 Always = new("Always"u8);
[Flags]
public enum Dyability : byte
{
No = 1,
Yes = 2,
Two = 4,
}
public readonly EquipItem Item = item;
public readonly StringPair Name = new(item.Name);
public readonly EquipFlag Slot = item.Type.ToSlot().ToFlag();
public required DateTimeOffset UnlockTimestamp
{
get;
init
{
field = value;
UnlockText = value == DateTimeOffset.MinValue ? Always :
value == DateTimeOffset.MaxValue ? StringU8.Empty : new StringU8($"{value.LocalDateTime:g}");
}
}
public readonly StringU8 UnlockText;
public readonly StringPair ItemId = new($"{item.ItemId.Id}");
public readonly StringPair ModelString = new(item.ModelString);
public readonly StringPair OffhandModelString = offhand.Valid ? new StringPair(offhand.ModelString) : StringPair.Empty;
public readonly StringPair GauntletModelString = gauntlets.Valid ? new StringPair(gauntlets.ModelString) : StringPair.Empty;
public readonly StringPair RequiredLevel = new($"{item.Level.Value}");
public required (string, string)[] Mods { get; init; }
public readonly JobFlag Jobs = jobs.Flags;
public readonly StringU8 JobText = jobs.Name.IsEmpty ? new StringU8($"Unknown {jobs.Id.Id}") : jobs.Name;
public required bool Favorite { get; init; }
public readonly bool Tradable = item.Flags.HasFlag(ItemFlags.IsTradable);
public readonly bool Crest = item.Flags.HasFlag(ItemFlags.IsCrestWorthy);
public readonly Dyability Dyable = item.Flags.HasFlag(ItemFlags.IsDyable1)
? item.Flags.HasFlag(ItemFlags.IsDyable2) ? Dyability.Two : Dyability.Yes
: Dyability.No;
}

File diff suppressed because it is too large Load diff

View file

@ -1,5 +1,4 @@
using Dalamud.Bindings.ImGui;
using ImSharp;
using ImSharp;
using Luna;
namespace Glamourer.Gui.Tabs.UnlocksTab;
@ -46,10 +45,10 @@ public sealed class UnlocksTab : Window, ITab<MainTabType>
{
DrawTypeSelection();
if (DetailMode)
_table.Draw(Im.Style.FrameHeightWithSpacing);
_table.Draw();
else
_overview.Draw();
_table.Flags |= ImGuiTableFlags.Resizable;
_table.Flags |= TableFlags.Resizable;
}
public override void Draw()
@ -79,7 +78,7 @@ public sealed class UnlocksTab : Window, ITab<MainTabType>
{
Im.Line.Same();
if (ImEx.Icon.Button(LunaStyle.AutoResizeIcon, "Restore all columns to their original size."u8))
_table.Flags &= ~ImGuiTableFlags.Resizable;
_table.Flags &= ~TableFlags.Resizable;
}
if (!IsOpen)

View file

@ -89,8 +89,7 @@ public static class UiHelpers
using (Im.Disabled(locked))
{
using var id = Im.Id.Push(label);
if (ImEx.TriStateCheckbox(StringU8.Empty, ref apply, ColorId.TriStateCross.Value(), ColorId.TriStateCheck.Value(),
ColorId.TriStateNeutral.Value()))
if (ImEx.TriStateCheckbox(StringU8.Empty, ref apply, ColorId.TriStateNeutral.Value(), ColorId.TriStateCheck.Value(), ColorId.TriStateCross.Value()))
{
(newValue, newApply) = apply switch
{

View file

@ -78,8 +78,8 @@ public class DesignResolver(
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public bool GetQuickDesign(ref DesignBase? design, ref SeString? error)
{
design = quickDesignCombo.Design as Design;
if (design != null)
design = quickDesignCombo.QuickDesign;
if (design is not null)
return true;
error = "You do not have selected any design in the Quick Design Bar.";

View file

@ -7,9 +7,9 @@ using Penumbra.GameData.Structs;
namespace Glamourer.Unlocks;
public class FavoriteManager : ISavable
public sealed class FavoriteManager : ISavable
{
private readonly record struct FavoriteHairStyle(Gender Gender, SubRace Race, CustomizeIndex Type, CustomizeValue Id)
public readonly record struct FavoriteHairStyle(Gender Gender, SubRace Race, CustomizeIndex Type, CustomizeValue Id)
{
public uint ToValue()
=> Id.Value | ((uint)Type << 8) | ((uint)Race << 16) | ((uint)Gender << 24);
@ -27,6 +27,17 @@ public class FavoriteManager : ISavable
private readonly HashSet<FavoriteHairStyle> _favoriteHairStyles = [];
private readonly HashSet<BonusItemId> _favoriteBonusItems = [];
public enum FavoriteType : byte
{
Item,
Stain,
Customization,
BonusItem,
}
/// <summary> Event invoked with type, ID (or <see cref="FavoriteHairStyle"/>) and whether the item was favorited or removed. </summary>
public event Action<FavoriteType, uint, bool>? FavoriteChanged;
public FavoriteManager(SaveService saveService)
{
_saveService = saveService;
@ -135,36 +146,44 @@ public class FavoriteManager : ISavable
public bool TryAdd(ItemId item)
{
if (item.Id == 0 || !_favorites.Add(item))
if (item.Id is 0 || !_favorites.Add(item))
return false;
FavoriteChanged?.Invoke(FavoriteType.Item, item.Id, true);
Save();
return true;
}
public bool TryAdd(BonusItemId item)
{
if (item.Id == 0 || !_favoriteBonusItems.Add(item))
if (item.Id is 0 || !_favoriteBonusItems.Add(item))
return false;
FavoriteChanged?.Invoke(FavoriteType.BonusItem, item.Id, true);
Save();
return true;
}
public bool TryAdd(StainId stain)
{
if (stain.Id == 0 || !_favoriteColors.Add(stain))
if (stain.Id is 0 || !_favoriteColors.Add(stain))
return false;
FavoriteChanged?.Invoke(FavoriteType.Stain, stain.Id, true);
Save();
return true;
}
public bool TryAdd(Gender gender, SubRace race, CustomizeIndex type, CustomizeValue value)
{
if (!TypeAllowed(type) || !_favoriteHairStyles.Add(new FavoriteHairStyle(gender, race, type, value)))
if (!TypeAllowed(type))
return false;
var id = new FavoriteHairStyle(gender, race, type, value);
if (!_favoriteHairStyles.Add(id))
return false;
FavoriteChanged?.Invoke(FavoriteType.Customization, id.ToValue(), true);
Save();
return true;
}
@ -181,6 +200,7 @@ public class FavoriteManager : ISavable
if (!_favorites.Remove(item))
return false;
FavoriteChanged?.Invoke(FavoriteType.Item, item.Id, false);
Save();
return true;
}
@ -190,6 +210,7 @@ public class FavoriteManager : ISavable
if (!_favoriteBonusItems.Remove(item))
return false;
FavoriteChanged?.Invoke(FavoriteType.BonusItem, item.Id, false);
Save();
return true;
}
@ -199,15 +220,18 @@ public class FavoriteManager : ISavable
if (!_favoriteColors.Remove(stain))
return false;
FavoriteChanged?.Invoke(FavoriteType.Stain, stain.Id, false);
Save();
return true;
}
public bool Remove(Gender gender, SubRace race, CustomizeIndex type, CustomizeValue value)
{
if (!_favoriteHairStyles.Remove(new FavoriteHairStyle(gender, race, type, value)))
var id = new FavoriteHairStyle(gender, race, type, value);
if (!_favoriteHairStyles.Remove(id))
return false;
FavoriteChanged?.Invoke(FavoriteType.Customization, id.ToValue(), true);
Save();
return true;
}

2
Luna

@ -1 +1 @@
Subproject commit 3d460349da4ab862961bbb3170ccf4f0fedf0eca
Subproject commit c52743f736892dde62f39e6a2b06fde4096cdff7

@ -1 +1 @@
Subproject commit 6f39fadad5333c73cc1d90219828f169c3bbaa2a
Subproject commit 223fb1b04fee05c439b7679e7f62bc890e5d0885