From 349241d0ab9cf8bd9cfb19031dfe0b12202c42a9 Mon Sep 17 00:00:00 2001
From: Ottermandias <nickroederspam+git1@gmail.com>
Date: Tue, 7 Jan 2025 16:49:19 +0100
Subject: [PATCH] Better attribution of authors in item swap.

---
 Penumbra/Mods/ModCreator.cs               |  4 +--
 Penumbra/UI/AdvancedWindow/ItemSwapTab.cs | 31 ++++++++++++++++++++---
 2 files changed, 29 insertions(+), 6 deletions(-)

diff --git a/Penumbra/Mods/ModCreator.cs b/Penumbra/Mods/ModCreator.cs
index 1af9c1db..bdc16b72 100644
--- a/Penumbra/Mods/ModCreator.cs
+++ b/Penumbra/Mods/ModCreator.cs
@@ -30,12 +30,12 @@ public partial class ModCreator(
     public readonly Configuration Config = config;
 
     /// <summary> Creates directory and files necessary for a new mod without adding it to the manager. </summary>
-    public DirectoryInfo? CreateEmptyMod(DirectoryInfo basePath, string newName, string description = "")
+    public DirectoryInfo? CreateEmptyMod(DirectoryInfo basePath, string newName, string description = "", string? author = null)
     {
         try
         {
             var newDir = CreateModFolder(basePath, newName, Config.ReplaceNonAsciiOnImport, true);
-            dataEditor.CreateMeta(newDir, newName, Config.DefaultModAuthor, description, "1.0", string.Empty);
+            dataEditor.CreateMeta(newDir, newName, author ?? Config.DefaultModAuthor, description, "1.0", string.Empty);
             CreateDefaultFiles(newDir);
             return newDir;
         }
diff --git a/Penumbra/UI/AdvancedWindow/ItemSwapTab.cs b/Penumbra/UI/AdvancedWindow/ItemSwapTab.cs
index 8f1ed8d6..e590eb1e 100644
--- a/Penumbra/UI/AdvancedWindow/ItemSwapTab.cs
+++ b/Penumbra/UI/AdvancedWindow/ItemSwapTab.cs
@@ -12,6 +12,7 @@ using Penumbra.Communication;
 using Penumbra.GameData.Data;
 using Penumbra.GameData.Enums;
 using Penumbra.GameData.Structs;
+using Penumbra.Import.Structs;
 using Penumbra.Meta;
 using Penumbra.Mods;
 using Penumbra.Mods.Groups;
@@ -275,16 +276,38 @@ public class ItemSwapTab : IDisposable, ITab, IUiService
             case SwapType.Hair:
             case SwapType.Tail:
                 return
-                    $"Created by swapping {_lastTab} {_sourceId} onto {_lastTab} {_targetId} for {_currentRace.ToName()} {_currentGender.ToName()}s in {_mod!.Name}.";
+                    $"Created by swapping {_lastTab} {_sourceId} onto {_lastTab} {_targetId} for {_currentRace.ToName()} {_currentGender.ToName()}s in {_mod!.Name}{OriginalAuthor()}";
             case SwapType.BetweenSlots:
                 return
-                    $"Created by swapping {GetAccessorySelector(_slotFrom, true).Item3.CurrentSelection.Item.Name} onto {GetAccessorySelector(_slotTo, false).Item3.CurrentSelection.Item.Name} in {_mod!.Name}.";
+                    $"Created by swapping {GetAccessorySelector(_slotFrom, true).Item3.CurrentSelection.Item.Name} onto {GetAccessorySelector(_slotTo, false).Item3.CurrentSelection.Item.Name} in {_mod!.Name}{OriginalAuthor()}";
             default:
                 return
-                    $"Created by swapping {_selectors[_lastTab].Source.CurrentSelection.Item.Name} onto {_selectors[_lastTab].Target.CurrentSelection.Item.Name} in {_mod!.Name}.";
+                    $"Created by swapping {_selectors[_lastTab].Source.CurrentSelection.Item.Name} onto {_selectors[_lastTab].Target.CurrentSelection.Item.Name} in {_mod!.Name}{OriginalAuthor()}";
         }
     }
 
+    private string OriginalAuthor()
+    {
+        if (_mod!.Author.IsEmpty || _mod!.Author.Text is "TexTools User" or DefaultTexToolsData.Author)
+            return ".";
+
+        return $" by {_mod!.Author}.";
+    }
+
+    private string CreateAuthor()
+    {
+        if (_mod!.Author.IsEmpty)
+            return _config.DefaultModAuthor;
+        if (_mod!.Author.Text == _config.DefaultModAuthor)
+            return _config.DefaultModAuthor;
+        if (_mod!.Author.Text is "TexTools User" or DefaultTexToolsData.Author)
+            return _config.DefaultModAuthor;
+        if (_config.DefaultModAuthor is DefaultTexToolsData.Author)
+            return _mod!.Author;
+
+        return $"{_mod!.Author} (Swap by {_config.DefaultModAuthor})";
+    }
+
     private void UpdateOption()
     {
         _selectedGroup = _mod?.Groups.FirstOrDefault(g => g.Name == _newGroupName);
@@ -296,7 +319,7 @@ public class ItemSwapTab : IDisposable, ITab, IUiService
 
     private void CreateMod()
     {
-        var newDir = _modManager.Creator.CreateEmptyMod(_modManager.BasePath, _newModName, CreateDescription());
+        var newDir = _modManager.Creator.CreateEmptyMod(_modManager.BasePath, _newModName, CreateDescription(), CreateAuthor());
         if (newDir == null)
             return;