ToxicMushroom/Penumbra
1
0
Fork 0
mirror of https://github.com/xivdev/Penumbra.git synced 2025-12-12 18:27:24 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert resource management change. Doesn't work.

Browse source
This commit is contained in:
Ottermandias 2021-09-05 02:01:23 +02:00
parent fe0445434f
commit 3cd9655263
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Penumbra/Interop/ResidentResources.cs
View file

@ -112,16 +112,12 @@ namespace Penumbra.Interop
UnloadCharacterResource( oldResources[ i ] ); UnloadCharacterResource( oldResources[ i ] );
// Easiest way to actually remove a file from the resource manager. // Temporary fix against crashes?
// Not doing this keeps them in memory for some reason,
// and then corrupts the state when entering a loading screen that is not a teleport.
// This increases the references of all loaded files by one temporarily, but there is extra logic for 0-references,
// and they get loaded anew with GetResourceAsync, but this gets redirected and thus the modded resource reference is increased twice.
// Then it reduces the refcount of all reduces by 1 again, but this time for real, so the resource gets ref count -1, leading to problems.
if( handle->RefCount <= 0 ) if( handle->RefCount <= 0 )
{ {
handle->RefCount = 1; handle->RefCount = 1;
handle->DecRef(); handle->IncRef();
handle->RefCount = 1;
} }
} }
} }