review: _selectedModIndex fix, redundant initialization removed.

This commit is contained in:
Ottermandias 2021-01-15 12:06:30 +01:00
parent d24fed6eb9
commit 3df3675500
2 changed files with 14 additions and 5 deletions

View file

@ -156,9 +156,6 @@ namespace Penumbra.Mods
var entry = new ModInfo
{
Priority = ModSettings.Count,
CurrentGroup = 0,
CurrentTop = 0,
CurrentBottom = 0,
FolderName = mod.ModBasePath.Name,
Enabled = true,
Mod = mod

View file

@ -267,7 +267,9 @@ namespace Penumbra.UI
if( ImGui.Button( "Rediscover Mods" ) )
{
ReloadMods();
ReloadMods();
_selectedModIndex = 0;
_selectedMod = null;
}
ImGui.SameLine();
@ -554,7 +556,17 @@ namespace Penumbra.UI
if( ImGui.Button( "Reload JSON" ) )
{
ReloadMods();
_selectedMod = _plugin.ModManager.Mods.ModSettings[ _selectedModIndex ];
// May select a different mod than before if mods were added or deleted, but will not crash.
if (_selectedModIndex < _plugin.ModManager.Mods.ModSettings.Count)
{
_selectedMod = _plugin.ModManager.Mods.ModSettings[_selectedModIndex];
}
else
{
_selectedModIndex = 0;
_selectedMod = null;
}
}
}