Add some log statements.

This commit is contained in:
Ottermandias 2023-10-08 13:19:01 +02:00
parent 717ddba8d2
commit 4378c826f0
7 changed files with 25 additions and 9 deletions

@ -1 +1 @@
Subproject commit c466bd33442dda3ade26f05c9e8d694443564118 Subproject commit 934e991f9a39c7d864501532003b9548ef73f896

@ -1 +1 @@
Subproject commit ac0710e9a116bec8633f3dcde2c9b6e38dffaaa9 Subproject commit 54b56ada57529221d3fc812193ffe65c424c1521

View file

@ -325,6 +325,7 @@ public class ActiveCollections : ISavable, IDisposable
/// </summary> /// </summary>
private void LoadCollections() private void LoadCollections()
{ {
Penumbra.Log.Debug("[Collections] Reading collection assignments...");
var configChanged = !Load(_saveService.FileNames, out var jObject); var configChanged = !Load(_saveService.FileNames, out var jObject);
// Load the default collection. If the string does not exist take the Default name if no file existed or the Empty name if one existed. // Load the default collection. If the string does not exist take the Default name if no file existed or the Empty name if one existed.
@ -389,6 +390,8 @@ public class ActiveCollections : ISavable, IDisposable
} }
} }
Penumbra.Log.Debug("[Collections] Loaded non-individual collection assignments.");
configChanged |= ActiveCollectionMigration.MigrateIndividualCollections(_storage, Individuals, jObject); configChanged |= ActiveCollectionMigration.MigrateIndividualCollections(_storage, Individuals, jObject);
configChanged |= Individuals.ReadJObject(_saveService, this, jObject[nameof(Individuals)] as JArray, _storage); configChanged |= Individuals.ReadJObject(_saveService, this, jObject[nameof(Individuals)] as JArray, _storage);

View file

@ -176,6 +176,7 @@ public class CollectionStorage : IReadOnlyList<ModCollection>, IDisposable
/// </summary> /// </summary>
private void ReadCollections(out ModCollection defaultNamedCollection) private void ReadCollections(out ModCollection defaultNamedCollection)
{ {
Penumbra.Log.Debug("[Collections] Reading saved collections...");
foreach (var file in _saveService.FileNames.CollectionFiles) foreach (var file in _saveService.FileNames.CollectionFiles)
{ {
if (!ModCollectionSave.LoadFromFile(file, out var name, out var version, out var settings, out var inheritance)) if (!ModCollectionSave.LoadFromFile(file, out var name, out var version, out var settings, out var inheritance))
@ -202,6 +203,7 @@ public class CollectionStorage : IReadOnlyList<ModCollection>, IDisposable
} }
defaultNamedCollection = SetDefaultNamedCollection(); defaultNamedCollection = SetDefaultNamedCollection();
Penumbra.Log.Debug($"[Collections] Found {Count} saved collections.");
} }
/// <summary> /// <summary>

View file

@ -27,7 +27,10 @@ public partial class IndividualCollections
public bool ReadJObject(SaveService saver, ActiveCollections parent, JArray? obj, CollectionStorage storage) public bool ReadJObject(SaveService saver, ActiveCollections parent, JArray? obj, CollectionStorage storage)
{ {
if (_actorService.Valid) if (_actorService.Valid)
return ReadJObjectInternal(obj, storage); {
var ret = ReadJObjectInternal(obj, storage);
return ret;
}
void Func() void Func()
{ {
@ -38,14 +41,19 @@ public partial class IndividualCollections
_actorService.FinishedCreation -= Func; _actorService.FinishedCreation -= Func;
} }
Penumbra.Log.Debug("[Collections] Delayed reading individual assignments until actor service is ready...");
_actorService.FinishedCreation += Func; _actorService.FinishedCreation += Func;
return false; return false;
} }
private bool ReadJObjectInternal(JArray? obj, CollectionStorage storage) private bool ReadJObjectInternal(JArray? obj, CollectionStorage storage)
{ {
Penumbra.Log.Debug("[Collections] Reading individual assignments...");
if (obj == null) if (obj == null)
{
Penumbra.Log.Debug($"[Collections] Finished reading {Count} individual assignments...");
return true; return true;
}
var changes = false; var changes = false;
foreach (var data in obj) foreach (var data in obj)
@ -58,7 +66,7 @@ public partial class IndividualCollections
{ {
changes = true; changes = true;
Penumbra.Messager.NotificationMessage("Could not load an unknown individual collection, removed.", Penumbra.Messager.NotificationMessage("Could not load an unknown individual collection, removed.",
NotificationType.Warning); NotificationType.Error);
continue; continue;
} }
@ -86,6 +94,8 @@ public partial class IndividualCollections
} }
} }
Penumbra.Log.Debug($"Finished reading {Count} individual assignments...");
return changes; return changes;
} }

View file

@ -3,7 +3,7 @@ using Penumbra.Util;
namespace Penumbra.Import.Structs; namespace Penumbra.Import.Structs;
// Create an automatically disposing SqPack stream. // Create an automatically disposing SqPack stream.
public class StreamDisposer : PenumbraSqPackStream, IDisposable public class StreamDisposer : PenumbraSqPackStream
{ {
private readonly FileStream _fileStream; private readonly FileStream _fileStream;
@ -11,13 +11,10 @@ public class StreamDisposer : PenumbraSqPackStream, IDisposable
: base(stream) : base(stream)
=> _fileStream = stream; => _fileStream = stream;
public new void Dispose() protected override void Dispose(bool _)
{ {
var filePath = _fileStream.Name; var filePath = _fileStream.Name;
base.Dispose();
_fileStream.Dispose(); _fileStream.Dispose();
File.Delete(filePath); File.Delete(filePath);
} }
} }

View file

@ -327,8 +327,12 @@ public class PenumbraSqPackStream : IDisposable
public void Dispose() public void Dispose()
{ {
Reader.Dispose(); Reader.Dispose();
Dispose(true);
} }
protected virtual void Dispose(bool _)
{ }
public class PenumbraFileInfo public class PenumbraFileInfo
{ {
public uint HeaderSize; public uint HeaderSize;