ToxicMushroom/Penumbra
1
0
Fork 0
mirror of https://github.com/xivdev/Penumbra.git synced 2025-12-12 10:17:22 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use FirstOrDefault instead of manual iteration.

Browse source
This commit is contained in:
Ottermandias 2025-10-24 15:21:57 +02:00
parent 349b62e549
commit 90cffb1759
2 changed files with 89 additions and 95 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Luna

@ -1 +1 @@
Subproject commit 78216203f4570a6194fce9422204d8abb536c828 Subproject commit 8fc11b993d8504982acd95b8d39e6ee7046c1347

16
Penumbra/Mods/Manager/ModStorage.cs
View file

@ -37,17 +37,8 @@ public class ModStorage : IReadOnlyList<Mod>
/// </summary> /// </summary>
public bool TryGetMod(string identifier, [NotNullWhen(true)] out Mod? mod) public bool TryGetMod(string identifier, [NotNullWhen(true)] out Mod? mod)
{ {
foreach (var m in Mods) mod = this.FirstOrDefault(m => string.Equals(m.Identifier, identifier, StringComparison.OrdinalIgnoreCase));
{ return mod is not null;
if (string.Equals(m.Identifier, identifier, StringComparison.OrdinalIgnoreCase))
{
mod = m;
return true;
}
}
mod = null;
return false;
} }
/// <summary> /// <summary>
@ -56,6 +47,9 @@ public class ModStorage : IReadOnlyList<Mod>
/// </summary> /// </summary>
public bool TryGetMod(string identifier, string modName, [NotNullWhen(true)] out Mod? mod) public bool TryGetMod(string identifier, string modName, [NotNullWhen(true)] out Mod? mod)
{ {
if (modName.Length is 0)
return TryGetMod(identifier, out mod);
mod = null; mod = null;
foreach (var m in Mods) foreach (var m in Mods)
{ {